Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xwd
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • app
  • xwd
  • Issues
  • #3

Closed
Open
Created Sep 20, 2019 by Dmitry Markov@dmarkov

QueryColorMap() function in multiVis.c may retrieve incorrect colours

In QueryColorMap XColor array is allocated by malloc() function which does not initialise allocated memory. So if the memory contains some “garbage”, which is not cleared out during array elements initialisation, the array with incorrect data is passed to XQueryColors() often causing problems such as incorrect colour retrieval.

Possible fix: Replace malloc() with calloc(), which initialises allocated memory with 0, for XColor array allocation in QueryColorMap() function

Patch:

@@ -218,7 +218,11 @@
      XColor *colors ;
 
      ncolors = (unsigned) src_vis->map_entries ;
-     *src_colors = colors = (XColor *)malloc(ncolors * sizeof(XColor) ) ;
+     *src_colors = colors = (XColor *)calloc(ncolors, sizeof(XColor));
 
      if(src_vis->class != TrueColor && src_vis->class != DirectColor)
      {
Edited Sep 20, 2019 by Dmitry Markov
Assignee
Assign to
Time tracking