- 20 Nov, 2020 1 commit
-
-
Keith Packard authored
Signed-off-by:
Keith Packard <keithp@keithp.com>
-
- 17 Nov, 2020 4 commits
-
-
Keith Packard authored
Make sure the function succeeded before looking at the return value. Signed-off-by:
Keith Packard <keithp@keithp.com>
-
Keith Packard authored
Fix the test when computing size necessary for true color output to use 'is_truecolor_term' instead of 'is_utf8_locale'. A non-utf8 locale with a true color terminal would have under-allocated the buffer. Also, check for truecolor first to match the output code. This doesn't fix the fact that this code over-allocates by a factor of two in this case, but that at least won't cause memory corruption. Signed-off-by:
Keith Packard <keithp@keithp.com>
-
Keith Packard authored
Make sure we clean up after this call by using the XFreeStringList function. Signed-off-by:
Keith Packard <keithp@keithp.com>
-
Keith Packard authored
Auto-detecting the terminal width and eliding icons that are too wide is a nice new feature, but we shouldn't change the behaviour when that width is not detectable (e.g., when output to a file). Change the default terminal width from 80 to 144 + 8 to get back to the previous output format. Signed-off-by:
Keith Packard <keithp@keithp.com>
-
- 01 Nov, 2020 5 commits
-
-
Pierre-Loup A. Griffais authored
Otherwise looks like this: Icon (48 x 48): (not shown) Icon (64 x 64): (not shown) Icon (128 x 128): (not shown)
-
Pierre-Loup A. Griffais authored
-
Pierre-Loup A. Griffais authored
-
Pierre-Loup A. Griffais authored
We need up to 3 bytes per character in UTF8 mode, not 4.
-
Pierre-Loup A. Griffais authored
Assuming we can query the terminal width.
-
- 11 Apr, 2020 1 commit
-
-
Jason Nader authored
`-help` is mentioned in the manpages, but actually running `xprop -help` results in xprop exiting with status 1 as it doesn't recognise the option. This has been the source of major confusion here: https://github.com/franciscolourenco/done/issues/77#issuecomment-612404448Signed-off-by:
Jason Nader <jason.nader@protonmail.com>
-
- 10 Mar, 2019 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 03 Mar, 2019 1 commit
-
-
Alan Coopersmith authored
dsimple.c:322:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] for (i=0; i<nchildren; i++) { ^ Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 09 Feb, 2019 1 commit
-
-
pmav99 authored
-
- 22 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 17 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 05 May, 2018 1 commit
-
-
Alan Coopersmith authored
Found by gcc 7.3: xprop.c: In function ‘Read_Quoted’: xprop.c:163:8: warning: this ‘else’ clause does not guard... [-Wmisleading-indentation] } else ^~~~ xprop.c:164:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’ ptr++[0] = c; length--; ^~~~~~ Introduced in initial commit to X Consortium RCS in 1987: https://cgit.freedesktop.org/~alanc/xc-historical/commit/xc/programs/xprop/xprop.c?id=18ea83d7457743936e99a574b50e208f7697f096 Actual effect is minimal - for every \-escaped newline in the DFORMAT portion of a xprop formats file, xprop subtracted one byte too many from the count of bytes still available in the buffer, which could lead it to return an error of "Bad format file format: dformat too long." when there was still room left. Since the original buffer size was 10,000 bytes, and the current size is 500,000 bytes, it's unlikely anyone ever hit this in real usage. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 10 Mar, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 26 Jan, 2017 3 commits
-
-
Mihail Konev authored
Signed-off-by:
Mihail Konev <k.mvc@ya.ru>
-
Emil Velikov authored
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Syncs the invocation of configure with the one from the server. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
- 28 Sep, 2015 2 commits
-
-
Eirik Byrkjeflot Anonsen authored
Signed-off-by:
Eirik Byrkjeflot Anonsen <eirik@eirikba.org>
-
Eirik Byrkjeflot Anonsen authored
Signed-off-by:
Eirik Byrkjeflot Anonsen <eirik@eirikba.org>
-
- 22 Sep, 2015 2 commits
-
-
Eirik Byrkjeflot Anonsen authored
Signed-off-by:
Eirik Byrkjeflot Anonsen <eirik@eirikba.org>
-
Eirik Byrkjeflot Anonsen authored
Signed-off-by:
Eirik Byrkjeflot Anonsen <eirik@eirikba.org>
-
- 04 Jun, 2014 4 commits
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
See http://people.gnome.org/~walters/docs/build-api.txtSigned-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 09 Aug, 2013 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 20 Jul, 2013 2 commits
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 23 Jan, 2013 2 commits
-
-
Alan Coopersmith authored
Allows us to get rid of a second copy of the code that differed only in the unicode argument passed on to Format_String. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 20 Jan, 2013 2 commits
-
-
Alan Coopersmith authored
Silences -Wformat-nonliteral warnings about passing through unknown format arguments to vfprintf. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Regroup AC statements under the Autoconf initialization section. Regroup AM statements under the Automake initialization section. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 21 Feb, 2012 1 commit
-
-
lolilolicon authored
Fix "bad format character: u" error for format '8u', e.g.: xprop -root -f _NET_WM_NAME 8u -set _NET_WM_NAME LG3D Signed-off-by:
James Cloos <cloos@jhcloos.com>
-
- 30 Jun, 2011 2 commits
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 09 May, 2011 1 commit
-
-
Jeremy Huddleston Sequoia authored
xprop.c:1011:2: warning: Function call argument is an uninitialized value memcpy(_formatting_buffer, error, strlen(error)+1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ xprop.c:1011:36: note: instantiated from: memcpy(_formatting_buffer, error, strlen(error)+1); ^ ~~~~~ Found-by: clang static analysis Signed-off-by:
Jeremy Huddleston <jeremyhu@apple.com>
-