Skip to content

GitLab

Switch branch/tag
  1. 16 Apr, 2022 3 commits
  3. 09 Jan, 2022 1 commit
  5. 06 Dec, 2021 2 commits
  7. 22 Nov, 2018 1 commit
  9. 17 Nov, 2018 1 commit
  11. 10 Nov, 2018 1 commit
  13. 28 Nov, 2017 1 commit
  15. 06 Nov, 2017 1 commit
  17. 24 Apr, 2017 1 commit
  19. 26 Jan, 2017 3 commits
  21. 23 Jul, 2015 1 commit
  23. 19 Jul, 2015 2 commits
  25. 09 Jun, 2015 1 commit
    • Alan Coopersmith's avatar
      Fix memory leaks when not using alloca · 4fdc960c
      Alan Coopersmith authored 
      

Reported by Oracle Parfait 1.5.1:

Error: Memory leak (CWE 401)
   Memory leak of pointer client_auth allocated with FSalloc((prefix->num_auths * 24))
        at line 256 of difs/dispatch.c in function 'ProcEstablishConnection'.
          client_auth allocated at line 243 with FSalloc((prefix->num_auths * 24)).
          client_auth leaks when (((Atom)ad) - ((Atom)(prefix + 8))) > ((stuff->length << 2) - 4) at line 252.
        malloc called at line 372 of os/utils.c in function 'FSalloc'
        at line 276 of difs/dispatch.c in function 'ProcEstablishConnection'.
          client_auth allocated at line 243 with FSalloc((prefix->num_auths * 24)).
          client_auth leaks when (i + 1) >= ((fsConnClientPrefix*)client->requestBuffer)[1].num_auths at line 251.
        malloc called at line 372 of os/utils.c in function 'FSalloc'

Error: Memory leak (CWE 401)
   Memory leak of pointer acp allocated with FSalloc((stuff->num_auths * 24))
        at line 604 of difs/dispatch.c in function 'ProcCreateAC'.
          acp allocated at line 590 with FSalloc((stuff->num_auths * 24)).
          acp leaks when ((((Atom)ad) - ((Atom)client->requestBuffer)) + 8) > ((stuff->length << 2) - 4) at line 599.
        malloc called at line 372 of os/utils.c in function 'FSalloc'
        at line 622 of difs/dispatch.c in function 'ProcCreateAC'.
          acp allocated at line 590 with FSalloc((stuff->num_auths * 24)).
          acp leaks when (i + 1) >= ((fsCreateACReq*)client->requestBuffer)->num_auths at line 597.
        malloc called at line 372 of os/utils.c in function 'FSalloc'
Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      4fdc960c
  27. 23 Aug, 2014 1 commit
    • Alan Coopersmith's avatar
      Add const to port variable passed to TRANS(ReopenCOTSServer) · 3d9bc5a3
      Alan Coopersmith authored 
      

Before this patch, gcc always warns:
os/xfstrans.c: In function ‘_FontTransGetInetdListenInfo’:
os/xfstrans.c:38:18: warning: initialization discards ‘const’ qualifier from pointer target type [enabled by default]
     char *port = "0";
                  ^

After this patch, with prior versons of libxtrans, gcc will warn about
passing a const to TRANS(ReopenCOTSServer) where non-const is expected.

With both this patch & the libxtrans const patches, there are no warnings.
Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      3d9bc5a3
  29. 22 Aug, 2014 1 commit
  31. 12 Aug, 2014 1 commit
    • Alan Coopersmith's avatar
      Add subdir-objects to automake options · 89926822
      Alan Coopersmith authored 
      

automake 1.14.1 is asking for it:

 warning: possible forward-incompatibility.
 At least a source file is in a subdirectory, but the 'subdir-objects'
 automake option hasn't been enabled.  For now, the corresponding output
 object file(s) will be placed in the top-level directory.  However,
 this behaviour will change in future Automake versions: they will
 unconditionally cause object files to be placed in the same subdirectory
 of the corresponding sources.
 You are advised to start using 'subdir-objects' option throughout your
 project, to avoid future incompatibilities.

and repeating for every source file:
Makefile.am:35: warning: source file 'difs/charinfo.c' is in a subdirectory,
Makefile.am:35: but option 'subdir-objects' is disabled

This quiets it, and brings us into line with the future state.
Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      89926822
  33. 10 Aug, 2014 1 commit
  35. 03 Jun, 2014 2 commits
  37. 24 May, 2014 2 commits
  39. 23 May, 2014 3 commits
  41. 21 May, 2014 7 commits
  43. 25 Apr, 2014 1 commit
  45. 25 Feb, 2014 1 commit
    • Keith Packard's avatar
      Warning fixes. · 2c794527
      Keith Packard authored and Gaetan Nadon's avatar Gaetan Nadon committed 
      

XFS replicates quite a bit of X server infrastructure so that it can
share libXfont. Many of those shared functions are declared in shared
font header files (either fontsproto.h or fontmisc.h). This patch
removes duplicate definitions from the XFS header files and makes sure
the shared header files are included in the right places to get the
functions declared before being defined.

Of course, some of those function types have changed, in particular
CopyISOLatin1Lowered now takes a const char * source parameter.

This patch also stops re-using the 'port' variable in
GetInetdListenInfo when fetching the ReopenInfo. That's not strictly
necessary here, but will be useful when the Reopen API in libxtrans
changes to take a constant parameter.
Reviewed-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
Tested-by: Gaetan Nadon's avatarGaetan Nadon <memsize@videotron.ca>
Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
Signed-off-by: Gaetan Nadon's avatarGaetan Nadon <memsize@videotron.ca>
      2c794527
  47. 06 Jul, 2013 1 commit