1. 02 Mar, 2019 1 commit
  2. 25 Feb, 2019 1 commit
  3. 18 Feb, 2019 2 commits
  4. 01 Jan, 2019 2 commits
  5. 22 Nov, 2018 1 commit
  6. 17 Nov, 2018 1 commit
  7. 16 Aug, 2018 1 commit
  8. 06 May, 2018 1 commit
  9. 03 Oct, 2017 1 commit
  10. 08 Feb, 2017 1 commit
  11. 26 Jan, 2017 3 commits
  12. 29 Jan, 2016 1 commit
  13. 07 Jan, 2016 1 commit
  14. 21 Dec, 2015 3 commits
  15. 19 Oct, 2015 5 commits
    • Jeremy Huddleston Sequoia's avatar
      Fixup various format warnings in PrintProtoDisplay · c0c3ad0c
      Jeremy Huddleston Sequoia authored
      protodpy.c:52:35: warning: format specifies type 'unsigned int' but the argument has type 'struct protoDisplay *' [-Wformat]
          Debug ("ProtoDisplay 0x%x\n", pdpy);
                                 ~~     ^~~~
      protodpy.c:54:20: warning: incompatible pointer types passing 'XdmcpNetaddr' (aka 'char *') to parameter of type 'struct sockaddr *'
            [-Wincompatible-pointer-types]
          PrintSockAddr (pdpy->address, pdpy->addrlen);
                         ^~~~~~~~~~~~~
      ../include/dm_socket.h:46:45: note: passing argument to parameter 'a' here
      extern void PrintSockAddr (struct sockaddr *a, int len);
                                                  ^
      protodpy.c:55:41: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
          Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date);
                         ~~                   ^~~~~~~~~~
                         %lu
      protodpy.c:55:53: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
          Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date);
                             ~~                           ^~~~~~~~~~~~~~~~~~~~
                             %lu
      protodpy.c:57:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat]
          Debug ("\tsessionID %d\n", pdpy->sessionID);
                              ~~     ^~~~~~~~~~~~~~~
                              %lu
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      c0c3ad0c
    • Jeremy Huddleston Sequoia's avatar
      Silence -Wmissing-noreturn warnings · d5aa455a
      Jeremy Huddleston Sequoia authored
      choose.c:463:1: warning: function 'RunChooser' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      chooser.c:1062:1: warning: function 'DoCancel' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      reset.c:81:1: warning: function 'abortReset' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      server.c:154:1: warning: function 'serverPauseAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      server.c:161:1: warning: function 'serverPauseUsr1' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      server.c:236:1: warning: function 'abortOpen' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      server.c:329:1: warning: function 'PingLost' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      server.c:348:1: warning: function 'PingLostSig' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:231:1: warning: function 'catchTerm' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:293:1: warning: function 'SessionPingFailed' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:240:1: warning: function 'catchAlrm' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:249:1: warning: function 'waitAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:330:1: warning: function 'ManageSession' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:471:1: warning: function 'syncTimeout' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      session.c:519:1: warning: function 'SessionExit' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      d5aa455a
    • Jeremy Huddleston Sequoia's avatar
      Add missing prototype for PrintSockAddr · 6cc5153d
      Jeremy Huddleston Sequoia authored
      protodpy.c:53:5: error: implicit declaration of function 'PrintSockAddr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
          PrintSockAddr (pdpy->address, pdpy->addrlen);
          ^
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      6cc5153d
    • Jeremy Huddleston Sequoia's avatar
      Add missing return type (void) for PrintProtoDisplay · 68de9118
      Jeremy Huddleston Sequoia authored
      protodpy.c:49:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
      PrintProtoDisplay (struct protoDisplay *pdpy)
      ^
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      68de9118
    • Jeremy Huddleston Sequoia's avatar
      xdm: Add missing include of <arpa/inet.h> for inet_ntop · 0d8bb02d
      Jeremy Huddleston Sequoia authored
      netaddr.c:226:2: error: implicit declaration of function 'inet_ntop' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
              inet_ntop(a->sa_family, &((struct sockaddr_in6 *) a)->sin6_addr,
              ^
      Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston Sequoia <jeremyhu@apple.com>
      0d8bb02d
  16. 28 Sep, 2015 1 commit
  17. 26 Jul, 2015 1 commit
  18. 15 Mar, 2015 1 commit
  19. 07 Mar, 2015 2 commits
  20. 23 Feb, 2015 1 commit
  21. 05 Nov, 2014 1 commit
    • Alan Coopersmith's avatar
      Only pass -u & -w args to sessreg if --with-{u,w}tmp-file=path specified · cdc7b575
      Alan Coopersmith authored
      If not specified, let sessreg use its builtin defaults instead of
      replicating the logic here (and possibly getting it wrong), especially
      since in sessreg-1.0.8 and earlier, using the -u & -w flags forces
      the use of the utmp/wtmp code and not the newer utmpx/wtmpx code.
      
      If --without-{u,w}tmp-file or --with-{u,w}tmp-file=none is specified,
      pass "none" as arguments to sessreg to disable writing to that file.
      
      v2: better handling of --with & --without arguments when not passing path,
      add documentation of the 3 choices to README
      Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      cdc7b575
  22. 02 Aug, 2014 1 commit
    • Alan Coopersmith's avatar
      Protect against unlikely NULL pointer dereference in FormatChooserArgument · a69c6458
      Alan Coopersmith authored
      NetaddrPort should only return NULL if it wasn't compiled with
      support for the address family in use, but checking to be sure
      makes static analyzer complain less.
      
      Error: Null pointer dereference (CWE 476)
         Read from null pointer port
              at line 219 of xdm/choose.c in function 'FormatChooserArgument'.
                Function NetaddrPort may return constant 'NULL' at line 77,
                 called at line 216.
                Null pointer introduced at line 77 of xdm/netaddr.c in function
                 'NetaddrPort'.
              at line 220 of xdm/choose.c in function 'FormatChooserArgument'.
                Function NetaddrPort may return constant 'NULL' at line 77,
                 called at line 216.
                Null pointer introduced at line 77 of xdm/netaddr.c in function
                 'NetaddrPort'.
      
      [ This bug was found by the Parfait 1.4.0 bug checking tool.
        http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ]
      Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      a69c6458
  23. 03 Jun, 2014 2 commits
  24. 29 Oct, 2013 1 commit
  25. 06 Sep, 2013 1 commit
  26. 20 Aug, 2013 1 commit
  27. 04 Aug, 2013 1 commit
    • Thomas Klausner's avatar
      Add wrapper function for write. · a0ab1f13
      Thomas Klausner authored
      gcc-4.5.4 on NetBSD complains:
      xdm/prngc.c: In function ‘get_prngd_bytes’:
      xdm/prngc.c:133:2: error: passing argument 1 of ‘atomicio’ from incompatible pointer type
      xdm/prngc.c:46:16: note: expected ‘ssize_t (*)(int,  void *, size_t)’ but argument is of type ‘ssize_t (*)(int,  const void *, size_t)’
      
      The problem is that the read(2) and write(2) syscalls differ
      in the const-ness of their second argument. The wrapper
      function gets rid of the difference.
      Signed-off-by: Thomas Klausner's avatarThomas Klausner <wiz@NetBSD.org>
      Signed-off-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      a0ab1f13
  28. 09 Jul, 2013 1 commit