- 30 Apr, 2022 1 commit
-
-
Alan Coopersmith authored
Resolves issue found by Oracle Parfait static analyzer: Error: Uninitialised memory Uninitialised memory [uninitialised-mem] (CWE 456): Possible access to uninitialised memory referenced by 'new->fullname' Memory 'new->fullname' accessed at byte offset '8' at line 357 of app/xdm/chooser/chooser.c in function 'AddHostname'. Write does not overlap at line 355 new allocated at line 329 Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 10 Apr, 2022 4 commits
-
-
Alan Coopersmith authored
Most of these came from a mass bcopy() -> memmove() substitution in 1993 with a commit comment of "ANSIfied for R6". Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Don't try to process returned data values that may not be set Resolves Oracle Parfait issue: Error: Uninitialised memory Uninitialised memory variable [uninitialised-mem-var] (CWE 457): Possible access to uninitialised memory referenced by variable 'length' at line 238 of xdm/xdmcp.c in function 'all_query_respond'. Path in callee avoiding write at line 237 length allocated at line 231 Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Should never happen, but makes Oracle Parfait stop warning: Error: Buffer overrun Read Outside Array Bounds in STD C function [read-outside-array-bounds-call-stdc]: Read outside array bounds in call to memmove. Buffer ((int8*)&in_addr) of size 256 is read at an offset of len Array size is 256 bytes, index <= 1024 at line 130 of xdm/socket.c in function 'GetChooserAddr'. called at line 197 of xdm/choose.c in function 'FormatChooserArgument' with lenp = &addr_len. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Matt Turner authored
Bug: https://bugs.gentoo.org/384371 Signed-off-by:
Matt Turner <mattst88@gmail.com>
-
- 03 Apr, 2022 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 04 Dec, 2021 2 commits
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 01 Nov, 2020 2 commits
-
-
Alan Coopersmith authored
Resolves warning from Oracle Parfait static analyzer: Warning: Dangling pointer Dangling pointer [dangling-pointer]: Invalid pointer is accessible to caller via global addrs at line 664 of xdm/auth.c in function 'doneAddrs'. Invalid pointer accessible via global addrs at line 646 a accessed from addrs at line 658 in function 'doneAddrs' a freed with free at line 662 Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Oracle Parfait static analyser points out it wasn't clear if cast or arithmetic operation in arguments at lines 410, 416, 431, & 433 was intended to be done first, so we'll make it explicit. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 31 Oct, 2020 1 commit
-
-
Matt Turner authored
libsystemd-daemon was merged into libsystemd in 2014, for systemd-209. Fixes: #9 Signed-off-by:
Matt Turner <mattst88@gmail.com>
-
- 22 Jul, 2020 1 commit
-
-
Alan Coopersmith authored
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 02 Mar, 2019 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 25 Feb, 2019 1 commit
-
-
Alan Coopersmith authored
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93359 while avoiding https://bugs.freedesktop.org/show_bug.cgi?id=107368 Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 18 Feb, 2019 2 commits
-
-
changing the printf-like format as strlen returns an unsigned type Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 01 Jan, 2019 2 commits
-
-
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 22 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 17 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 16 Aug, 2018 1 commit
-
-
Signed-off-by:
Adam Jackson <ajax@redhat.com>
-
- 06 May, 2018 1 commit
-
-
Alan Coopersmith authored
Introduced by commit 5222d28e Reported by gcc 7.3: auth.c: In function ‘SaveServerAuthorizations’: auth.c:447:6: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation] if (auths[i]->data_length > 0) ^~ auth.c:452:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’ (void) fflush (auth_file); ^ Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Matthieu Herrb <matthieu@herrb.eu>
-
- 03 Oct, 2017 1 commit
-
-
Matthieu Herrb authored
This prevents a malicious user logging out from calling chmod while still owning /dev/console and thus by-passing the '622' mode that is set here. Issue reported by Tim Chase. Thanks. Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 08 Feb, 2017 1 commit
-
-
Alan Coopersmith authored
As best I can tell, it was historically under section 1 mainly because the old X Consortium Imake configs only supported installing program man pages there, and didn't have an option for using other sections. Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 26 Jan, 2017 3 commits
-
-
Signed-off-by:
Mihail Konev <k.mvc@ya.ru>
-
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Syncs the invocation of configure with the one from the server. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com>
-
- 29 Jan, 2016 1 commit
-
-
From what I can see in the ancient X Consortium archives, the cpp resource was added in X11R4 and documented but never actually used, and removed in X11R5 without remembering to remove it from the man page. Reported-by:
John Smith <wempwer@gmail.com> Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com> Reviewed-by:
Matthieu Herrb <matthieu@herrb.eu> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 07 Jan, 2016 1 commit
-
-
Matthieu Herrb authored
Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 21 Dec, 2015 3 commits
-
-
Matthieu Herrb authored
Nothing has set that since the modularization Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Matthieu Herrb authored
Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Matthieu Herrb authored
Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Adam Jackson <ajax@redhat.com> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 19 Oct, 2015 5 commits
-
-
Jeremy Huddleston Sequoia authored
protodpy.c:52:35: warning: format specifies type 'unsigned int' but the argument has type 'struct protoDisplay *' [-Wformat] Debug ("ProtoDisplay 0x%x\n", pdpy); ~~ ^~~~ protodpy.c:54:20: warning: incompatible pointer types passing 'XdmcpNetaddr' (aka 'char *') to parameter of type 'struct sockaddr *' [-Wincompatible-pointer-types] PrintSockAddr (pdpy->address, pdpy->addrlen); ^~~~~~~~~~~~~ ../include/dm_socket.h:46:45: note: passing argument to parameter 'a' here extern void PrintSockAddr (struct sockaddr *a, int len); ^ protodpy.c:55:41: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date); ~~ ^~~~~~~~~~ %lu protodpy.c:55:53: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat] Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date); ~~ ^~~~~~~~~~~~~~~~~~~~ %lu protodpy.c:57:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat] Debug ("\tsessionID %d\n", pdpy->sessionID); ~~ ^~~~~~~~~~~~~~~ %lu Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
Jeremy Huddleston Sequoia authored
choose.c:463:1: warning: function 'RunChooser' could be declared with attribute 'noreturn' [-Wmissing-noreturn] chooser.c:1062:1: warning: function 'DoCancel' could be declared with attribute 'noreturn' [-Wmissing-noreturn] reset.c:81:1: warning: function 'abortReset' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:154:1: warning: function 'serverPauseAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:161:1: warning: function 'serverPauseUsr1' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:236:1: warning: function 'abortOpen' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:329:1: warning: function 'PingLost' could be declared with attribute 'noreturn' [-Wmissing-noreturn] server.c:348:1: warning: function 'PingLostSig' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:231:1: warning: function 'catchTerm' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:293:1: warning: function 'SessionPingFailed' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:240:1: warning: function 'catchAlrm' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:249:1: warning: function 'waitAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:330:1: warning: function 'ManageSession' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:471:1: warning: function 'syncTimeout' could be declared with attribute 'noreturn' [-Wmissing-noreturn] session.c:519:1: warning: function 'SessionExit' could be declared with attribute 'noreturn' [-Wmissing-noreturn] Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
Jeremy Huddleston Sequoia authored
protodpy.c:53:5: error: implicit declaration of function 'PrintSockAddr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] PrintSockAddr (pdpy->address, pdpy->addrlen); ^ Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
Jeremy Huddleston Sequoia authored
protodpy.c:49:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int] PrintProtoDisplay (struct protoDisplay *pdpy) ^ Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
Jeremy Huddleston Sequoia authored
netaddr.c:226:2: error: implicit declaration of function 'inet_ntop' is invalid in C99 [-Werror,-Wimplicit-function-declaration] inet_ntop(a->sa_family, &((struct sockaddr_in6 *) a)->sin6_addr, ^ Signed-off-by:
Jeremy Huddleston Sequoia <jeremyhu@apple.com>
-
- 28 Sep, 2015 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 26 Jul, 2015 1 commit
-
-
Egbert Eich authored
It is not guaranteed that argc > 0. So make sure we don't crash if no valid command line arguments are given. Signed-off-by:
Egbert Eich <eich@suse.de> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 15 Mar, 2015 1 commit
-
-
Matthieu Herrb authored
A new 'inpColor' resource is added for that. Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-