Skip to content

GitLab

Switch branch/tag
  1. 05 Jan, 2021 1 commit
  3. 29 May, 2016 1 commit
  5. 31 Dec, 2015 1 commit
  7. 30 Dec, 2015 1 commit
  9. 26 Dec, 2015 1 commit
  11. 21 Oct, 2015 1 commit
  13. 18 Nov, 2014 5 commits
  15. 10 Dec, 2013 1 commit
  17. 25 Apr, 2013 1 commit
  19. 16 Aug, 2012 1 commit
  21. 01 Jun, 2012 1 commit
  23. 29 Apr, 2012 1 commit
  25. 28 Apr, 2012 1 commit
  27. 27 Apr, 2012 3 commits
  29. 22 Apr, 2012 2 commits
  31. 30 Mar, 2012 3 commits
  33. 05 Mar, 2012 1 commit
  35. 19 Feb, 2012 1 commit
  37. 17 Feb, 2012 3 commits
    • Ken Thomases's avatar
      Fix "un-zooming" on certain windows which weren't reacting properly · 24818cfb
      Ken Thomases authored and Jeremy Huddleston Sequoia's avatar Jeremy Huddleston Sequoia committed 
      Regression from: 682660f8



The prior code sometimes tested for a maximized window by comparing the
current frame with

	[_screen zoomed_rect:X11RectOrigin(_current_frame)]

but other times compared it with

	[self validate_frame_rect:[_screen zoomed_rect:X11RectOrigin(_current_frame)]]

The latter is more correct and takes WM size hints, like the resize
increments, into account.  My code standardized on the former, though.  The
old code was wrong in some cases, mine is wrong in all cases.

The long story:

My understanding is that quartz-wm's behavior is based on Cocoa's.
NSWindow's -isZoomed method tests if the window's frame equals the zoomed
frame computed for the window.  So, any change of the window's frame
potentially changes whether it is considered zoomed or not.  Quartz-wm
behaves similarly.

There are two aspects of what "is considered zoomed" might mean.  There's the
method in the above patch, -is_maximized, in the quartz-wm code.  That
compares the current frame (well, "intended" frame) with a computed zoomed
frame.  Then, there's the question of whether quartz-wm puts the
_NET_WM_STATE_MAXIMIZED_{HORZ,VERT} atoms in the window's _NET_WM_STATE
property.

My changes were intended to get the latter part to match the former.

However, I also inadvertently made the computed zoomed frame not meet the
is-it-zoomed test for windows with resize increments and, probably, a maximum
size smaller than the screen.  Quartz-wm would compute one zoomed frame for
the window, set the frame to that, and then subsequently compare against a
possibly different frame to determine if the window was zoomed.
Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston <jeremyhu@apple.com>
      24818cfb
    • Jeremy Huddleston Sequoia's avatar
      Fix possible error during make install · 9848c838
      Jeremy Huddleston Sequoia authored 
      

Fix an issue with 'make install' if we are installing over a
previous install.
Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston <jeremyhu@apple.com>
      9848c838
    • Jeremy Huddleston Sequoia's avatar
      Provide the dock-support API as a dylib · c724411a
      Jeremy Huddleston Sequoia authored 
      

This should allow easier building on and deployment to different
versions of Mac OS X.
Signed-off-by: Jeremy Huddleston Sequoia's avatarJeremy Huddleston <jeremyhu@apple.com>
      c724411a
  39. 11 Feb, 2012 2 commits
  41. 10 Feb, 2012 2 commits
  43. 28 Jan, 2012 2 commits
  45. 17 Jan, 2012 2 commits
  47. 30 Dec, 2011 2 commits