GitLab

We're not seriously maintaining this tool, we should stop pretending.
Signed-off-by: Adam Jackson <ajax@redhat.com>

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

http://marc.info/?l=openbsd-misc&m=145123363601391&w=2

We need to turn off IEXTEN to make the tty transparent.  I thought
ICANON would cover this (as it does on Linux), but apparently it's a
BSD-ism that LNEXT operates independently of ICANON.  That isn't a bug
either; both the OpenBSD code and the rather different FreeBSD code
explicitly handle it this way.

IEXTEN is part of POSIX, even if the actual behavior is
"implementation-defined", so I don't think it needs an ifdef.
Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>

See http://people.gnome.org/~walters/docs/build-api.txtSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

charset.c:360:2: warning: Potential leak of memory pointed to by 'c'
        return NULL;
        ^~~~~~~~~~~
1 warning generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Simply included a bunch of .h files and had no code of its own.

Flagged by Solaris ld -z guidance:
ld: guidance: removal of unused file recommended: locale.o
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Duplication introduced when merging in changes in commit fddfe30cSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>

-D_XOPEN_SOURCE was originally added for Linux in commit e7510863
and then updated to -D_XOPEN_SOURCE=500 in commit e1a00221 to
expose strdup() in glibc headers.

As noted in bug 47792 though, the posix_openpt() function is not
visible unless that's raised to 600.

Instead of continually chasing the standards ourselves, switch to letting
autoconf handle that for us.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>

Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Julien Cristau <jcristau@debian.org>
Reviewed-by: Matthieu Herrb <matthieu.herrb@laas.fr>

Silences warnings of:
charset.c: In function ‘IdentityRecode’:
charset.c:42:51: warning: unused parameter ‘self’ [-Wunused-parameter]
charset.c: In function ‘NullReverse’:
charset.c:84:26: warning: unused parameter ‘n’ [-Wunused-parameter]
charset.c:84:59: warning: unused parameter ‘self’ [-Wunused-parameter]
other.c: In function ‘mapping_utf8’:
other.c:108:44: warning: unused parameter ‘s’ [-Wunused-parameter]
other.c: In function ‘reverse_utf8’:
other.c:114:44: warning: unused parameter ‘s’ [-Wunused-parameter]
luit.c: In function ‘sigwinchHandler’:
luit.c:463:21: warning: unused parameter ‘sig’ [-Wunused-parameter]
luit.c: In function ‘sigchldHandler’:
luit.c:470:20: warning: unused parameter ‘sig’ [-Wunused-parameter]
luit.c: In function ‘parent’:
luit.c:657:12: warning: unused parameter ‘pid’ [-Wunused-parameter]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

After the fork it is undefined wether parent or child runs
first. So there can be a race: if the child runs before the
terminal of the parent is set up correctly luit may hang.
This patch sets up the terminal before forking and undoes
the settings in the child.
Signed-off-by: Mike FABIAN <mfabian@redhat.com>
Signed-off-by: Egbert Eich <eich@freedesktop.org>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Error: Memory leak (CWE 401)
   Memory leak of pointer 'c' allocated with malloc(80)
        at line 297 of app/luit/charset.c in function 'getFontencCharset'.
          'c' allocated at line 290 with malloc(80).
        at line 303 of app/luit/charset.c in function 'getFontencCharset'.
          'c' allocated at line 290 with malloc(80).

[ This bug was found by the Parfait 0.4.2 bug checking tool.
  For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Instead of opening /dev/ptmx directly, we should use the proper
posix_openpt() function to obtain a pseudo-terminal. Some operating
systems, such as FreeBSD 8 and later, implement pseudo-terminal master
device nodes as a special file descriptor type, like sockets. They do
not support creation of pseudo-terminals through /dev/ptmx.
Signed-off-by: Ed Schouten <ed@80386.nl>
Reviewed-by: Guillem Jover <guillem@hadrons.org>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

NetBSD and FreeBSD still don't _POSIX_SAVED_IDS

https://bugs.freedesktop.org/show_bug.cgi?id=41513Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

If libfontenc needs it, it will either be linked with it or
provide -lz in its pkg-config library requirements.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Dan Nicholson <dbn.lists@gmail.com>

This removes a false-positive from static analysis results.
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

The nroff .I macro on Solaris was truncating these strings when
displayed using the "man" command
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

This silences an Autoconf warning

This silences an Automake warning.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Jesse Adkins <jesserayadkins@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

AC_PROG_CC & AC_PROG_INSTALL are provided by XORG_DEFAULT_OPTIONS now
PKG_CONFIG_MODULES handles AC_SUBST of the CFLAGS & LIBS variables
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Unrelated to the previous patches, the new value simply reflects
the reality that the minimum level for autoconf to configure
all x.org modules is 2.60 dated June 2006.

ftp://ftp.gnu.org/gnu/autoconf/autoconf-2.60.tar.gzSigned-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Use MAN_SUBST now supplied in XORG_MANPAGE_SECTIONS
The value of MAN_SUBST is the same for all X.Org packages.

Use AC_PROG_SED now supplied by XORG_DEFAULT_OPTIONS
Use the appropriate platform version of sed
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

To match XORG_MANPAGE_SECTIONS macro expectations.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

To match the luit.man expectations.
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

luit doesn't #include any Xlib headers or call any Xlib functions,
just attempts to read Xlib's locale.aliases files if it can find it.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

    * add -alias option to allow override of locale.alias pathname.
    * improve fix waitForInput as suggested in Freedesktop #26383.
    * fix warnings from clang --analyze
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

X.Org bug#26383 <http://bugs.freedesktop.org/26383>
Acked-by: Juliusz Chroboczek <jch@pps.jussieu.fr>
Signed-off-by: Julien Cristau <jcristau@debian.org>