GitLab

From the reporter on #xorg-devel:

-!- thrig [thrig@unaffilaited/thrig] has joined #xorg-devel
<thrig> where does the code for bitmap live? there's a crash (or who
        knows on some platforms) if you `bitmap -size 42`

Found by using:
  codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Clears 169 out of 240 -Wdiscarded-qualifiers warnings from gcc 7.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

the ability to set single dots in the programm Bitmap depend on the state
of num_lock. This is a long standing bug that affect all versions
of bitmap.

the problem was that the corresponding function was erroneously checking
event->xbutton.state. Removing that check solved the problem for the user.
Signed-off-by: wharms <wharms@bfs.de>

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

StripFilename() allocates a new string for its result, so after we're
done with it, free it instead of just losing the pointer to it.

Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:

Error: Memory leak (CWE 401)
   Memory leak of pointer basename allocated with StripFilename(filename)
        at line 712 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
          basename allocated at line 691 with StripFilename(filename).
          basename leaks when i >= data_length at line 702.
Error: Memory leak (CWE 401)
   Memory leak of pointer basename allocated with StripFilename(filename)
        at line 715 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
          basename allocated at line 691 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

StripFilename() already allocates a new string for its result,
we don't need to duplicate it and then lose the pointer to the
first one.

Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:

Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1119 of Bitmap.c in function 'BWReadFile'.
          pointer allocated at line 1106 with StripFilename(filename).
          pointer leaks when StripFilename(filename) != NULL at line 1106.
Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1119 of Bitmap.c in function 'BWReadFile'.
          pointer allocated at line 1106 with StripFilename(filename).

Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1222 of Bitmap.c in function 'BWWriteFile'.
          pointer allocated at line 1202 with StripFilename(filename).
          pointer leaks when StripFilename(filename) != NULL at line 1202.
Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1222 of Bitmap.c in function 'BWWriteFile'.
          pointer allocated at line 1202 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

See http://people.gnome.org/~walters/docs/build-api.txt

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Graphics.c:569:10: warning: The result of the '<<' expression is undefined
        while (!QueryFlood(BW, x, y, value) && (x < x_right))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Graphics.c:470:7: note: expanded from macro 'QueryFlood'
    ((GetBit(BW->bitmap.image, x, y) !=\
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Graphics.c:66:9: note: expanded from macro 'GetBit'
            (1 << ((x) % 8))) ? 1 : 0))
             ~~^~~~~~~~~~~~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

atobm.c:248:6: warning: Potential leak of memory pointed to by 'slist'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
atobm.c:259:6: warning: Potential leak of memory pointed to by 'old'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
atobm.c:259:6: warning: Potential leak of memory pointed to by 'slist'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
3 warnings generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Bitmap.c:906:17: warning: declaration shadows a local variable [-Wshadow]
        unsigned char *image_data;
                       ^
Bitmap.c:799:11: note: previous declaration is here
    char *image_data, *buffer_data;
          ^
Bitmap.c:907:8: warning: declaration shadows a local variable [-Wshadow]
        char *buffer_data;
              ^
Bitmap.c:799:24: note: previous declaration is here
    char *image_data, *buffer_data;
                       ^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Bitmap.c:1246:8: warning: Dereference of null pointer
        **str = '\0';
        ~~~~~~^~~~~~
1 warning generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>

Fix Automake warning: AC_OUTPUT should be used without arguments.
www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Files
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

This also now catches errors when fopen() or fdopen() fail, before
we try to fwrite() to a null FILE pointer.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Remove stray backslash.
(Added sometime between X11R4 and X11R5; 21+ years old.)

Use two spaces between sentences, not one or two or three.
Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Signed-off-by: James Cloos <cloos@jhcloos.com>

Found by Parfait 0.5.0.1 bug checking tool:
   Leaked X Resource pix
        at line 393 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
          pix initialized at line 388 with XCreatePixmap(...).
        at line 414 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
          pix initialized at line 409 with XCreatePixmap(...).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Moves -lm from being hardcoded in Makefile.am to being added via
AC_SEARCH_LIBS in configure.ac setting it in $(MATH_LIBS)

Using lrint() [returns long int] instead of rint() [returns double]
clears a bunch of gcc warnings of the form:
"cast from function call of type ‘double’ to non-matching type ‘short int’"
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Fixes many gcc --Wwrite-string warnings of the form:

Bitmap.c: In function ‘BWTPaste’:
Bitmap.c:1913:7: warning: passing argument 2 of ‘BWEngageRequest’ discards qualifiers from pointer target type
Bitmap.h:190:16: note: expected ‘BWRequest’ but argument is of type ‘const char *’
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

It only includes <X11/Xos.h>, no headers or functions from libX11.
Due to a typo in Makefile.am (also fixed) it wasn't actually linking
with libX11 even though it had x11 in its PKG_CHECK_MODULES list.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>