Commits · master · xorg / app / bitmap

02 Jun, 2019 1 commit

Use _CONST_X_STRING to make libXt declare String as const char * · 3a2473af

Alan Coopersmith authored Jun 01, 2019

Clears 169 out of 240 -Wdiscarded-qualifiers warnings from gcc 7.3
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

3a2473af

10 Feb, 2019 1 commit
- bitmap 1.0.9 · 6dcc9c80
  Alan Coopersmith authored Feb 10, 2019
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  6dcc9c80
22 Nov, 2018 1 commit
- Update configure.ac bug URL for gitlab migration · d0e0bdea
  Alan Coopersmith authored Nov 21, 2018
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  d0e0bdea
17 Nov, 2018 1 commit
- Update README for gitlab migration · b674422c
  Alan Coopersmith authored Nov 16, 2018
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  b674422c
24 Sep, 2017 1 commit

same time ago the user Frederic Baldit complained (on xorg) that · 99b0d80d

Walter Harms authored Sep 24, 2017

the ability to set single dots in the programm Bitmap depend on the state
of num_lock. This is a long standing bug that affect all versions
of bitmap.

the problem was that the corresponding function was erroneously checking
event->xbutton.state. Removing that check solved the problem for the user.
Signed-off-by: wharms <wharms@bfs.de>

99b0d80d

26 Jan, 2017 3 commits

autogen: add default patch prefix · f9174d18
Mihail Konev authored Jan 26, 2017
```
Signed-off-by: Mihail Konev <k.mvc@ya.ru>
```
f9174d18

autogen.sh: use quoted string variables · 24c90b9f

Emil Velikov authored Mar 09, 2015

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

24c90b9f

autogen.sh: use exec instead of waiting for configure to finish · 37d922c3

Peter Hutterer authored Jan 24, 2017

Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

37d922c3

17 Jan, 2015 1 commit
- bitmap 1.0.8 · 2f5eae70
  Alan Coopersmith authored Jan 16, 2015
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  2f5eae70
30 Dec, 2014 2 commits

Stop memory leak in XmuWriteBitmapDataToFile() · dacae587

Alan Coopersmith authored Dec 29, 2014

StripFilename() allocates a new string for its result, so after we're
done with it, free it instead of just losing the pointer to it.

Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:

Error: Memory leak (CWE 401)
Memory leak of pointer basename allocated with StripFilename(filename)
at line 712 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
basename allocated at line 691 with StripFilename(filename).
basename leaks when i >= data_length at line 702.
Error: Memory leak (CWE 401)
Memory leak of pointer basename allocated with StripFilename(filename)
at line 715 of Bitmap.c in function 'XmuWriteBitmapDataToFile'.
basename allocated at line 691 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

dacae587

Stop memory leaks from XtNewString(StripFilename(filename)) · 8df1a843

Alan Coopersmith authored Dec 29, 2014

StripFilename() already allocates a new string for its result,
we don't need to duplicate it and then lose the pointer to the
first one.

Fixes errors found by Oracle Parfait 1.5.1 bug checking tool:

Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1119 of Bitmap.c in function 'BWReadFile'.
          pointer allocated at line 1106 with StripFilename(filename).
          pointer leaks when StripFilename(filename) != NULL at line 1106.
Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1119 of Bitmap.c in function 'BWReadFile'.
          pointer allocated at line 1106 with StripFilename(filename).

Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1222 of Bitmap.c in function 'BWWriteFile'.
          pointer allocated at line 1202 with StripFilename(filename).
          pointer leaks when StripFilename(filename) != NULL at line 1202.
Error: Memory leak (CWE 401)
   Memory leak of pointer pointer allocated with StripFilename(filename)
        at line 1222 of Bitmap.c in function 'BWWriteFile'.
          pointer allocated at line 1202 with StripFilename(filename).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

8df1a843

02 Jun, 2014 2 commits

autogen.sh: Honor NOCONFIGURE=1 · a0db0f6c

Alan Coopersmith authored Jun 01, 2014

See http://people.gnome.org/~walters/docs/build-api.txtSigned-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

a0db0f6c

configure: Drop AM_MAINTAINER_MODE · 8fb1efcc
Alan Coopersmith authored Jun 01, 2014
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
8fb1efcc

02 Jan, 2014 5 commits

Use '& 7' instead '% 8' to silence clang analyzer warning · d0911d13

Jeremy Huddleston Sequoia authored Jan 01, 2014

Graphics.c:569:10: warning: The result of the '<<' expression is undefined
        while (!QueryFlood(BW, x, y, value) && (x < x_right))
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~
Graphics.c:470:7: note: expanded from macro 'QueryFlood'
    ((GetBit(BW->bitmap.image, x, y) !=\
      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Graphics.c:66:9: note: expanded from macro 'GetBit'
            (1 << ((x) % 8))) ? 1 : 0))
             ~~^~~~~~~~~~~~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

d0911d13

Demacro modernization of NewSList to plug a memory leak during error handling · e3fe7950

Jeremy Huddleston Sequoia authored Jan 01, 2014

atobm.c:248:6: warning: Potential leak of memory pointed to by 'slist'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
atobm.c:259:6: warning: Potential leak of memory pointed to by 'old'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
atobm.c:259:6: warning: Potential leak of memory pointed to by 'slist'
            NewSList ();
            ^~~~~~~~~~~
atobm.c:209:3: note: expanded from macro 'NewSList'
                fprintf (stderr, "%s:  unable to allocate char array\n", \
                ^~~~~~~
3 warnings generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

e3fe7950

Silence -Wbad-function-cast · a59538d5
Jeremy Huddleston Sequoia authored Jan 01, 2014
```
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
```
a59538d5

Avoid shadow declarations · e7086abb

Jeremy Huddleston Sequoia authored Jan 01, 2014

Bitmap.c:906:17: warning: declaration shadows a local variable [-Wshadow]
        unsigned char *image_data;
                       ^
Bitmap.c:799:11: note: previous declaration is here
    char *image_data, *buffer_data;
          ^
Bitmap.c:907:8: warning: declaration shadows a local variable [-Wshadow]
        char *buffer_data;
              ^
Bitmap.c:799:24: note: previous declaration is here
    char *image_data, *buffer_data;
                       ^
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

e7086abb

assert to avoid a NULL dereference · 1e236565

Jeremy Huddleston Sequoia authored Jan 01, 2014

Bitmap.c:1246:8: warning: Dereference of null pointer
        **str = '\0';
        ~~~~~~^~~~~~
1 warning generated.
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

1e236565

23 Nov, 2013 1 commit

Print which option was in error along with usage message · 15d32602

Alan Coopersmith authored Nov 04, 2013

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Gaetan Nadon <memsize@videotron.ca>

15d32602

26 Oct, 2013 1 commit

config: replace deprecated use of AC_OUTPUT with AC_CONFIG_FILES · 64bc2b97

Gaetan Nadon authored Oct 25, 2013

Fix Automake warning: AC_OUTPUT should be used without arguments.
www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Files
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

64bc2b97

06 Jun, 2013 1 commit
- Use table markup in preference to various low-level constructions. · a78fc882
  Eric S. Raymond authored Jun 06, 2013
  
  a78fc882
18 May, 2013 1 commit
- bitmap 1.0.7 · 10584a7e
  Alan Coopersmith authored May 17, 2013
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  10584a7e
21 Apr, 2013 3 commits
- Mark usage() functions as noreturn, as suggested by gcc · d028190d
  Alan Coopersmith authored Apr 21, 2013
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  d028190d
- Simplify & unify error path between mktemp & mkstemp versions · f3656623
  Alan Coopersmith authored Apr 21, 2013
```
This also now catches errors when fopen() or fdopen() fail, before
we try to fwrite() to a null FILE pointer.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  f3656623
- Fix genererate typo in bmtoa error messages · 24969564
  Alan Coopersmith authored Apr 21, 2013
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  24969564
21 Jan, 2013 1 commit
- Combine usage messages into a single string · 7b5ba88d
  Alan Coopersmith authored Jan 20, 2013
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  7b5ba88d
22 Sep, 2012 1 commit

bitmap.man: Fix some typos. · 0d42abae

Bjarni Ingi Gislason authored Sep 22, 2012

Remove stray backslash.
(Added sometime between X11R4 and X11R5; 21+ years old.)

Use two spaces between sentences, not one or two or three.
Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Signed-off-by: James Cloos <cloos@jhcloos.com>

0d42abae

30 May, 2012 1 commit

Fix pixmap leak in error paths of BWGetUnzoomedPixmap · 53d99608

Alan Coopersmith authored May 29, 2012

Found by Parfait 0.5.0.1 bug checking tool:
   Leaked X Resource pix
        at line 393 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
          pix initialized at line 388 with XCreatePixmap(...).
        at line 414 of Bitmap.c in function 'BWGetUnzoomedPixmap'.
          pix initialized at line 409 with XCreatePixmap(...).
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

53d99608

09 Mar, 2012 1 commit
- bitmap 1.0.6 · a7909448
  Alan Coopersmith authored Mar 08, 2012
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
  a7909448
21 Dec, 2011 1 commit

Use lrint() from math library if available · 67ab4479

Alan Coopersmith authored Dec 20, 2011

Moves -lm from being hardcoded in Makefile.am to being added via
AC_SEARCH_LIBS in configure.ac setting it in $(MATH_LIBS)

Using lrint() [returns long int] instead of rint() [returns double]
clears a bunch of gcc warnings of the form:
"cast from function call of type ‘double’ to non-matching type ‘short int’"
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

67ab4479

15 Oct, 2011 5 commits

Constify strings in atobm · 1c2b70d1
Alan Coopersmith authored Oct 14, 2011
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
1c2b70d1
Constify strings in bmtoa · 3fc1a649
Alan Coopersmith authored Oct 14, 2011
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
3fc1a649

Strip trailing whitespace · a8ee8e93

Alan Coopersmith authored Oct 14, 2011

Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

a8ee8e93

Constify filename string handling · 64eacd36
Alan Coopersmith authored Oct 14, 2011
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
64eacd36

Add const to char * in BWRequest typedef · ca7bf97b

Alan Coopersmith authored Oct 14, 2011

Fixes many gcc --Wwrite-string warnings of the form:

Bitmap.c: In function ‘BWTPaste’:
Bitmap.c:1913:7: warning: passing argument 2 of ‘BWEngageRequest’ discards qualifiers from pointer target type
Bitmap.h:190:16: note: expected ‘BWRequest’ but argument is of type ‘const char *’
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

ca7bf97b

05 Mar, 2011 1 commit
- man: use correct section number when referring to X · 6e997556
  Gaetan Nadon authored Mar 04, 2011
```
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>
```
  6e997556
18 Feb, 2011 1 commit

atobm only depends on xproto, not x11 · 98e43d4e

Alan Coopersmith authored Feb 17, 2011

It only includes <X11/Xos.h>, no headers or functions from libX11.
Due to a typo in Makefile.am (also fixed) it wasn't actually linking
with libX11 even though it had x11 in its PKG_CHECK_MODULES list.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

98e43d4e

15 Jan, 2011 3 commits

Use autoconf standard HAVE_MKSTEMP define instead of old imake HAS_MKSTEMP · b3f10a08
Alan Coopersmith authored Jan 15, 2011
```
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
```
b3f10a08

config: Add missing AC_CONFIG_SRCDIR · ff81a4e4

Alan Coopersmith authored Jan 15, 2011

Regroup AC statements under the Autoconf initialization section.
Regroup AM statements under the Automake initialization section.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

ff81a4e4

Use fputs instead of fprintf with no format arg to print usage message. · 2afe9a69

Alan Coopersmith authored Jan 14, 2011

Clear gcc warning of:
BitEdit.c:986: warning: format not a string literal and no format arguments
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Dirk Wallenstein <halsmit@t-online.de>

2afe9a69