Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • X xkeyboard-config
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 59
    • Issues 59
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xkbdesc
  • xkeyboard-config
  • Merge requests
  • !242

Move left/right quotes one key to the right, place lower quotes on AB04

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael von Glasow requested to merge mvglasow/xkeyboard-config:quote into master Jul 18, 2021
  • Overview 0
  • Commits 1
  • Pipelines 3
  • Changes 10

latin(basic) currently has left upper quotation marks on AB04 (letter V) and right upper quotation marks on AB05 (letter B); double quotes on layer 3, single quotes on layer 4. Lower quotation marks, standard at the beginning of a quote in some European languages, are not included.

Some layouts move the upper quotes one key to the right, placing them on AB05 and AB06, and add single quotes on AB04. Examples are de(basic) and de(deadtilde). ipa does the same on layers 5/6.

In latin(basic), layer 3/4 of AB06 (letter N) is just a duplicate of layers 1/2 and thus should be free to reassign. I would therefore implement the same change in latin(basic).

I analyzed the layouts which inherit from latin to make sure this change does not break one of them – right upper quotes would become unreachable after the change where a keyboard layout inherits layer 3/4 of AB03/AB04 from latin(basic), but not layer 3/4 of AB06. Corrections were made to the following ones:

  • it(basic) and nl(basic) have Ntilde on AB06; ml(basic) has U019D; pl(legacy), pl(szl) and pl(csb) have Nacute; za(basic) has U1E4A; macintosh_vndr/de(basic) has asciitilde. AB04 and AB05 were overridden to keep the previous behavior- for those layouts.
  • pt(colemak) has definitions of AB04/AB05 which look redundant but would prevent changes to latin(basic) from taking effect; these definitions were dropped.
  • sun_vndr/lt(sun_type6) does not inherit from latin(standard) but has similar mappings; the same changes were applied here.
  • Definitions of AB04–AB06 in de(basic) have become redundant and were dropped.

While I have tried to prevent undesired side effects, if anyone wants to conduct further tests, I would greatly appreciate this.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: quote