- 21 Feb, 2019 1 commit
-
-
Currently we are going to print a message about the mismatch, yet continue regardless. Return false from the function since that's what the caller already expects and handles. Fixes: 03e3116a ("import latest renderer code") Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com>
-
- 18 Feb, 2019 7 commits
-
-
Erik Faye-Lund authoredThis tracks more accurately what exactly needs to be updated. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>
-
Erik Faye-Lund authored
We're going to have to do this anyway, so let's just do it cleanly right away. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
These settings can't change in the lifetime of the texture-view, so let's set them up front instead of re-setting them on every re-emit. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
There's no point in changing the texture-binding unless we're going to do something with the texture-stage. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
This means less needless work per frame, as this binding will never change. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
The result is the same, we just skip a bit quicker over unused entries. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
This function was added but never used. Let's get rid of it. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Fixes: 5d2dde49
("strings: move to 3 strings, and patch extensions onto end of string 0 (v2)")
Reviewed-by: Gurchetan Singh <gurchetansingh@chromium.org>
-
- 15 Feb, 2019 7 commits
-
-
Reviewed-by:
Robert Foss <robert.foss@collabora.com> Signed-off-by:
Jakob Bornecrantz <jakob@collabora.com>
-
Advertise the cap. Reviewed-by:Gert Wollny <gert.wollny@collabora.com>
-
Mostly uses same functionality as inline write. Reviewed-by: -
A transfer won't occur in context zero if the transfer command comes from submit_cmd. We need to restore prior state. With the recent framebuffer binding cleanups, we really only need to worry about the framebuffer. Reviewed-by: -
This can be shared by VIRGL_CCMD_TRANSFER3D and VIRGL_CCMD_RESOURCE_INLINE_WRITE. Reviewed-by: -
Like inline write, but uses resource's iovecs. Reviewed-by: -
Gert Wollny authored
The test requires a framebuffer configuration that softpipe doesn't support and leads to inconsistent results. When run directly on softpipe all these tests fail because of the framebuffer error, but with virglrenderer we don't report this error and the results that are read back might be random. Signed-off-by:
-
- 13 Feb, 2019 7 commits
-
-
Add issue for tracking this set of failures. virgl/virglrenderer#82 And add a previously unseen flavour of this failure. dEQP-GLES31.functional.shaders.builtin_functions.precision.frexp.highp_vertex.scalar Reviewed-by:
-
Reviewed-by:
-
Reviewed-by:
-
Reviewed-by:
-
This reverts commit 16de5085 . Reviewed-by:
-
d9a4be4d broke a number of tests when running on a GLES host because tgsitargettogltarget may return PIPE_BUFFER which is 0. So, instead of simply reverting the commit make it more explicit that we check for PIPE_BUFFER to make it clearer that this condition may actually trigger. Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Signed-off-by: -
Alexander Kanavin authored
Otherwise, a failure happens with gold linker: ../src/.libs/libvirglrenderer.so: error: undefined reference to 'drmPrimeHandleToFD' https://errors.yoctoproject.org/Errors/Details/222046/ Signed-off-by:
Alexander Kanavin <alex.kanavin@gmail.com> Signed-off-by:
Dave Airlie <airlied@redhat.com>
-
- 11 Feb, 2019 1 commit
-
-
Dave Airlie authored
Instead of enumerating all the GL buffer types, just use the is_buffer flag. Reviewed-by:
Elie Tournier <elie.tournier@collabora.com> Signed-off-by:
-
- 10 Feb, 2019 5 commits
-
-
Dave Airlie authored
This saves adding the padding and just appends the ext strings v2: use emit_hdr for the precision strings (Gert) Reviewed-By:
-
Dave Airlie authored
This uses the string array helpers to pass around the glsl strings for the program. This could be expanded on to provide more than 2 strings easily Reviewed-By:
-
Dave Airlie authored
This will make things easier in a later patch. Suggested by Gert. Reviewed-By:
-
Dave Airlie authored
v2: add assert, lose + 1 (Gert) v2.1: use debug printf Reviewed-By:
-
Dave Airlie authored
Reviewed-By:
-
- 08 Feb, 2019 10 commits
-
-
Gert Wollny authored
when virgl_renderer_init is called from qemu for initializing D-GL no context type flags are set and the context remains at NONE. Assume in this case that gl_colorspace is true, otherwise the feat_srgb_write_control flag will be cleared and the guest only gets OpenGL 2.1 compatibility. Signed-off-by:
-
Gert Wollny authored
As of 2018/11/30 EXT_texture_sRGB_R8 is also a valid extension for desktop GL. Hence, move the format into the joined list so that it can be picked up if the D-GL host supports it. Signed-off-by:
-
Gert Wollny authored
The old mesa version had a bug in handling EXT_texture_sRGB_R8 exposing the texture type even though the extension was not supported by the API. Bump also libdrm since it needs the update. Signed-off-by:
-
Erik Faye-Lund authored
We can't cache the current states on the texture-view, as multiple views can point to the same texture. Instead, we need to cache the state on the texture. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Fixes: 8d288c4b
("vrend: update texture state on a per view base")
Reviewed-by: -
Erik Faye-Lund authored
tgsitargettogltarget never returns a value that evaluates to zero, so this condition can't trigger. Let's drop the code. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
Texture views with emulated alpha also needs to get their border-color swizzled. So let's check the texture-view instead of the resource. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
This is going to make a difference for the next patch. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
Using GLenum here makes it sound like this is used for OpenGL formats, and not for pipe_format, which it really is. So let's change the type to reflect what it really is. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
This toggle only affect fixed-function fragment-shading, which we don't use at all. So let's not waste time setting unused state. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: -
Erik Faye-Lund authored
We shouldn't call glTexBuffer unless we know the feature is enabled, otherwise a rouge client might be able to crash the host. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by:
-
- 07 Feb, 2019 2 commits
-
-
Gert Wollny authored
v2: Instead of releasing the UBO's at the end don't reference count them. The guest keeps track of these resources and their reference counts, so it will not release the UBO's without re-setting the binding during the live time of a client progra, However, at final clean up the UBO's are not rebound before the resourse is released in the guest side resulting in the memory leak. When we skip the ref-counting on the host side the resourses are cleaned up correctly without breaking the program otherwise. Fixes resource leaks: Direct leak of 2448 byte(s) in 9 object(s) allocated from: #0 0x7fe3151aba68 in __interceptor_calloc (/usr/lib64/gcc/x86_64-pc-linux-gnu/7.3.0/libasan.so+0xdba68) #1 0x7fe314b89ea6 in vrend_renderer_resource_create ../../../../virgl-gitlab/src/vrend_renderer.c:5834 #2 0x7fe314b52b44 in virgl_renderer_resource_create ../../../../virgl-gitlab/src/virglrenderer.c:63 #3 0x560533f27852 in vtest_create_resource2 ../../../../virgl-gitlab/vtest/vtest_renderer.c:432 #4 0x560533f254fa in vtest_main_run_renderer ../../../../virgl-gitlab/vtest/vtest_server.c:359 #5 0x560533f244df in main ../../../../virgl-gitlab/vtest/vtest_server.c:105 #6 0x7fe313919ac9 in __libc_start_main (/lib64/libc.so.6+0x21ac9) Signed-off-by: -
Gert Wollny authored
vrend_debug.h is not installed but we need the typedef for the debug callback. Fixes: 70fefe33 virgl: expose function to set output callback Signed-off-by:
-
