Slatian authored May 21, 2024 and Simon Lees committed May 21, 2024

* Uses a shell implementation ( !24) of `which` in the `desktop_file_to_binary` to avoid tripping over unexpected output from `command -v`
* In addition it also makes the parsing a bit more standards compliant than it previously was.
* Adds a developer script to easier test internal functions in the xdg-utils-common.in file

Fixes: #252

Slatian authored Feb 08, 2024 and Simon Lees committed Feb 08, 2024

Adds a script for developers that builds a given xdg-util using the Makefile, shellchecks it and calculates the lines in the source file.

This should allow easier shellchecking of the final output and avoid getting used to false positives.

This also disables SC3043 (`local <name>` statements without an declaration) which causes more noise than necessary.

Slatian authored Jan 23, 2024 and Simon Lees committed Jan 23, 2024

This replaces calls to `realpath -f` which isn't available on all shells. (fix #66)

Slatian authored Dec 04, 2023 and Simon Lees committed Dec 04, 2023

Original patch by ssk-wh

Rebased and shellchecked (quoting)

Slatian authored Dec 01, 2023 and Simon Lees committed Dec 03, 2023

This fixes autotests with Dash prior 0.5.11 and Bash of any version.

See also: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=975228

Original patch by Nicolas Guriev.

Rebased and updated.

Added a reporting issues section to xdg-open in the hopes that more issues will be attributed correctly

Slatian authored Nov 17, 2023 and Simon Lees committed Nov 27, 2023

* Replace backticks with `"$(`
* Quote variables and replacements (non un-quotes seemed intentional)
* Moved `local` variable definitions to their own lines so they don't clash with value assignment
* fixed formattting in `open_envvar`

Not fixed:
* SC3037 (warning): In POSIX sh, echo flags are undefined.
  (Fixing those is a bit more involved)

Slatian authored Nov 16, 2023 and Simon Lees committed Nov 27, 2023

See also: https://www.gnu.org/software/autoconf/manual/autoconf-2.70/html_node/Changed-Directory-Variables.html

(cherry picked from commit 14bc86bc0b329346c36a05c08320b27b85cda14b)

(Rebased from b0c38f04 by Slatian)

* Replace legacy backticks with "$(
* Fix ``for `echo $a | sed 's/:/ /g'`; …`` antipattern usinf IFS=:
* Quote a lot of filepaths to avoid time of check time od use inconsistencies
* Quote all other use of variables
	* for none of them not-quoting seemend intentional
	* even where it just "doen't hurt"
	* except for `for` loops 😉
* disable checks for mispelled variables where the spelling is intentional
* move the `local` bashisms to thwir own lines so that when a posix shell trips over them the script shouldn't fail because of them.

Did *not* fix:
* local is posix "incompatible" (SC3043) (but worked around it)
* SC2086 (info): Double quote to prevent globbing and word splitting. For `$xdg_redirect_output` pattern.

Slatian authored Oct 15, 2023 and Simon Lees committed Nov 15, 2023

* Added a .shellcheckrc file
* Replace legacy backticks with `"$(`
* Comment where `read -r` is inteletially placed and where the `-r` is omitted.
* Add quotes where they don't hurt
* fix iterating over user and system_dirs by using IFS properly in `open_generic_xdg_mime`
* Moved some `local` declarations out of the way
* Remove unused variable from `open_envvar`
* Disable checks fir the scary looking part of `open_envvar`
* Removed unneccessary variable in `open_flatpak`
*

Did *not* fix:
* `local` is posix "incompatible"

Slatian authored Sep 24, 2023 and Simon Lees committed Nov 15, 2023

with an always quote, unless intended policy
except for SC2268 (x prefixes)

Slatian authored Nov 14, 2023 and Simon Lees committed Nov 14, 2023

Now it shouldn't require a change for every KDE major version.

Slatian authored Nov 14, 2023 and Simon Lees committed Nov 14, 2023

* Converted the READMEs to Markdown
* Added useful links (like the one to the [DocBook guide](https://tdg.docbook.org/))
* Updated obviously out of date content
* Added some Notes
* Added test byproducts to `tests/.gitignore`

My hope is that this makes the xdg-utils seem less like a dead project and lowers the barrier for contributing.

Harald Sitter authored Sep 22, 2023 and Marco Martin committed Oct 25, 2023

prefer the modern setting and if that is not available fall back to the
legacy setting. this ensures that clients can correctly identify the
"modern" default browser rather than the legacy one (there is
opportunity for disagreement between the two settings because of the
defect fixed in d11b33ec)

Slatian authored Oct 04, 2023 and Simon Lees committed Oct 11, 2023

* which was replaced with command -v

The function was added in 8c2615d3 to be used by open_generic
but that one does the filetype querying itself now.

Slatian authored Oct 03, 2023 and Simon Lees committed Oct 09, 2023

This will:
* make sure that applications that indicate that they don't support URIs don't get started when opening URIs
* when handling a file:// url, make sure tht applications that supports URIs will get the file URI

Fixes: #169

Slatian authored Oct 03, 2023 and Simon Lees committed Oct 09, 2023

This is because commit: c22a09fc
Fixes issue: #227

The issue was raised in [1]. The earlier fix [2] makes xdg-mime always
pick the first item from a list, and that differs from the standard [3].

> If the application is no longer installed, the next application in the
> list is attempted, and so on.

A latter fix [4] implements the standard-compliant behavior, while it
does not actually work until [2] is reverted.

[1] https://bugs.freedesktop.org/show_bug.cgi?id=44163
[2] xdg/xdg-utils@a5ec775d
[3] https://specifications.freedesktop.org/mime-apps-spec/1.0.1/ar01s04.html
[4] xdg/xdg-utils@1f8e58d5