Skip to content

Draft: wayland/output: remove outdated TODO

YaoBing Xiao requested to merge (removed):output into master

if create_immed fails, a fatal protocol error will occur as a Wayland client.

dmabuf->height=-1, wayland log:

[1852940.440] {Default Queue}  -> zwp_linux_dmabuf_v1#17.create_params(new id zwp_linux_buffer_params_v1#3)
[1852940.452] {Default Queue}  -> zwp_linux_buffer_params_v1#3.add(fd 326, 0, 0, 5120, 16777216, 8)
[1852940.456] {Default Queue}  -> zwp_linux_buffer_params_v1#3.add(fd 327, 1, 3768320, 640, 16777216, 8)
[1852940.459] {Default Queue}  -> zwp_linux_buffer_params_v1#3.add(fd 328, 2, 3784704, 64, 16777216, 8)
[1852940.462] {Default Queue}  -> zwp_linux_buffer_params_v1#3.create_immed(new id wl_buffer#30, 1280, -1, 875713112, 0)
[1852940.466] {Default Queue}  -> zwp_linux_buffer_params_v1#3.destroy()
[1852940.470] {Default Queue}  -> wl_surface#26.attach(wl_buffer#30, 0, 0)
[1852940.473] {Default Queue}  -> wl_surface#26.damage_buffer(0, 0, 2147483647, 2147483647)
[1852940.476] {Default Queue}  -> wl_surface#26.frame(new id wl_callback#31)
[1852940.480] {Default Queue}  -> wp_presentation#14.feedback(wl_surface#26, new id wp_presentation_feedback#32)
[1852940.483] {Default Queue}  -> xdg_surface#27.ack_configure(9882)
[1852940.485] {Default Queue}  -> wl_surface#26.commit()
[1852940.529] {Default Queue}  -> wl_compositor#4.create_surface(new id wl_surface#33)
[1852940.533] {Default Queue}  -> wl_surface#33.attach(nil, 0, 0)
[1852940.536] {Default Queue}  -> wl_surface#33.commit()
00:00:00.048 [DEBUG] [backend/wayland/pointer.c:459] creating pointer for output 'WL-1' from seat 'seat0'
[1852940.586] {Default Queue}  -> xdg_activation_v1#13.activate("not-granted-666", wl_surface#26)
00:00:00.048 [INFO] [tinywl/tinywl.c:1051] Running Wayland compositor on WAYLAND_DISPLAY=wayland-1
[1852940.617] {Display Queue} wl_display#1.error(nil, 6, "size overflow for plane 0")
[destroyed object]: error 6: size overflow for plane 0

ref: https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml?ref_type=heads#L376

Merge request reports

Loading