Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • wlroots wlroots
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 337
    • Issues 337
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 150
    • Merge requests 150
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • wlrootswlroots
  • wlrootswlroots
  • Merge requests
  • !3448

Draft: Introduce wlr_configurable

  • Review changes

  • Download
  • Patches
  • Plain diff
Open Kirill Primak requested to merge vyivel/wlroots:configurable into master Feb 07, 2022
  • Overview 0
  • Commits 7
  • Pipelines 1
  • Changes 14
shimarin $ ~/opt/wlroots grep "// First find the ack'ed configure" types -R | wc -l 
4

https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)


Closes #3206

This MR introduces wlr_configurable, a simple abstraction used to keep track of sent and received configures. Configurable objects don't receive a configure event immediately; instead, the event is delayed, allowing for protocol extensions to send their own configures alongside the way in any order. A wlr_configure which can store multiple object-specific configures tied to the same configure serial is used to achieve that.

TODO: add docs

Breaking changes

  • wlr_xdg_surface_configure has been removed.
  • wlr_xdg_surface.events.{ack_,}configure now have wlr_configure instead of wlr_xdg_surface_configure as their argument.
Edited Feb 08, 2022 by Kirill Primak
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: configurable