In clients/window.c and the corresponding .h we have the function window_set_preferred_format(), which is not being used. Instead, we have this: window->preferred_format = foo.

I don't think it's necessary to have this function, because this kind of assignment is being made only once and it's already pretty clear.