Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
W
weston
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 211
    • Issues 211
    • List
    • Boards
    • Labels
    • Milestones
  • Merge Requests 61
    • Merge Requests 61
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Packages
    • Packages
    • Container Registry
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • wayland
  • weston
  • Issues
  • #323

Closed
Open
Opened Dec 01, 2019 by Pekka Paalanen@pq0 of 14 tasks completed0/14 tasks
  • Report abuse
  • New issue
Report abuse New issue

RDP-backend to-do from review

Wishing for the RDP-backend to improve, I read through its code. These are my notes. I did not bother to open a new issue for each single one, but feel free to open Issues or MRs as you see fit, mention them here and I will update this description with a link.

  • seat release, needs safe wl_global removal in libweston core from #322
  • call weston_head_set_monitor_strings() when creating the head
  • weston_head_set_physical_size() parameters from remote screen physical size? #324
  • drop manually created shadow buffer, seems unused
  • prevent mode list from growing unlimited in ensure_matching_mode()
  • rdp_output_repaint(): implement frame-dropping or throttle to transmission framerate to avoid slow-motion updates in the remote?
  • rdp_peer_refresh_raw():
    • marker.frameID++ uninitialized?
    • what if heightIncrement starts zero due to a very wide rect?
  • rdp_peer_refresh_nsc():
    • suspicious #ifdef-skipping of memset() to zero; would be better to use unconditional initialization
    • why does it use damage extents instead of rects?
  • rdp_peer_refresh_rfx():
    • suspicious #ifdef-skipping of memset() to zero; would be better to use unconditional initialization
    • why offset ptr by extents x1, y1?
  • log RDP remote actions with a new debug scope, e.g. rdp_peer_refresh_*(), input events, connects and disconnects
  • clean up #ifdefs for old freerdp versions according to what the build requires today
Edited Dec 01, 2019 by Pekka Paalanen
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
1
Labels
RDP backend
Assign labels
  • View project labels
Reference: wayland/weston#323