weston issueshttps://gitlab.freedesktop.org/wayland/weston/-/issues2024-03-12T10:14:20Zhttps://gitlab.freedesktop.org/wayland/weston/-/issues/884Cannot link to Wayland Cursor statically2024-03-12T10:14:20ZJordan WilliamsCannot link to Wayland Cursor staticallyWeston's clients can only be built against the Wayland Cursor library when it is built as a shared library. When attempting to link against a static version of Wayland, there are duplicate symbols due to the symbol `os_create_anonymous_f...Weston's clients can only be built against the Wayland Cursor library when it is built as a shared library. When attempting to link against a static version of Wayland, there are duplicate symbols due to the symbol `os_create_anonymous_file` from the `os-compatibility.c` file. This file does in fact, appear to be used directly in the Wayland source code as part of Wayland Cursor as seen [here](https://gitlab.freedesktop.org/wayland/wayland/-/blob/main/cursor/os-compatibility.h?ref_type=heads). I hit this same issue in libdecor previously, as described in [this issue](https://gitlab.freedesktop.org/libdecor/libdecor/-/issues/66).
This can probably just be fixed by renaming the symbol to avoid the conflict.
The build failure follows below for reference.
```
[272/379] Linking target clients/weston-simple-egl
FAILED: clients/weston-simple-egl
gcc -o clients/weston-simple-egl clients/weston-simple-egl.p/meson-generated_.._.._protocol_fractional-scale-v1-protocol.c.o clients/weston-simple-egl.p/meson-generated_.._.._protocol_tearing-control-v1-protocol.c.o clients/weston-simple-egl.p/meson-generated_.._.._protocol_viewporter-protocol.c.o clients/weston-simple-egl.p/meson-generated_.._.._protocol_xdg-shell-protocol.c.o clients/weston-simple-egl.p/meson-generated_.._.._protocol_ivi-application-protocol.c.o clients/weston-simple-egl.p/simple-egl.c.o clients/weston-simple-egl.p/.._shared_matrix.c.o -Wl,--as-needed -Wl,--no-undefined -fuse-ld=lld -Wl,-rpath,/home/jordan/.conan2/p/b/libgl3ac61fc112c8e/p/lib -Wl,-rpath-link,/home/jordan/.conan2/p/b/libgl3ac61fc112c8e/p/lib -Wl,--start-group shared/libshared.a -lm /home/jordan/.conan2/p/b/wayla86eca9b4f04c0/p/lib/libwayland-client.a -lpthread -lrt /home/jordan/.conan2/p/b/libffd42f788d90937/p/lib/libffi.a /home/jordan/.conan2/p/b/wayla86eca9b4f04c0/p/lib/libwayland-server.a /home/jordan/.conan2/p/b/pixma4271311a66625/p/lib/libpixman-1.a /home/jordan/.conan2/p/b/xkbco529ba226868c9/p/lib/libxkbcommon.a /home/jordan/.conan2/p/b/libgl3ac61fc112c8e/p/lib/libEGL.so /home/jordan/.conan2/p/b/libgl3ac61fc112c8e/p/lib/libGLdispatch.so -ldl /usr/lib64/libX11.so /home/jordan/.conan2/p/b/wayla86eca9b4f04c0/p/lib/libwayland-egl.a /home/jordan/.conan2/p/b/libgl3ac61fc112c8e/p/lib/libGLESv2.so /home/jordan/.conan2/p/b/wayla86eca9b4f04c0/p/lib/libwayland-cursor.a -Wl,--end-group
ld.lld: error: duplicate symbol: os_create_anonymous_file
>>> defined at os-compatibility.c:179 (../src/shared/os-compatibility.c:179)
>>> libshared.a.p/os-compatibility.c.o:(os_create_anonymous_file) in archive shared/libshared.a
>>> defined at os-compatibility.c:119 (../src/cursor/os-compatibility.c:119)
>>> os-compatibility.c.o:(.text+0x37) in archive /home/jordan/.conan2/p/b/wayla86eca9b4f04c0/p/lib/libwayland-cursor.a
collect2: error: ld returned 1 exit status
[291/379] Compiling C object clients/weston-editor.p/editor.c.o
ninja: build stopped: subcommand failed.
```https://gitlab.freedesktop.org/wayland/weston/-/issues/872Memory leaks in weston-simple-im2024-01-31T10:13:11ZWismillMemory leaks in weston-simple-imThere are memory leaks in `clients/simple-im.c`. Using `valgrind --leak-check=full` I get the following:
```
==31113== Memcheck, a memory error detector
==31113== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==31113==...There are memory leaks in `clients/simple-im.c`. Using `valgrind --leak-check=full` I get the following:
```
==31113== Memcheck, a memory error detector
==31113== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al.
==31113== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info
==31113== Command: ./clients/weston-simple-im
==31113== Parent PID: 31112
==31113==
==31113==
==31113== HEAP SUMMARY:
==31113== in use at exit: 177,621 bytes in 1,865 blocks
==31113== total heap usage: 16,290 allocs, 14,425 frees, 762,183 bytes allocated
==31113==
==31113== 17,168 (376 direct, 16,792 indirect) bytes in 1 blocks are definitely lost in loss record 39 of 42
==31113== at 0x484A7BF: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31113== by 0x487E01E: wl_display_connect_to_fd (in /usr/lib64/libwayland-client.so.0.22.0)
==31113== by 0x487E29C: wl_display_connect (in /usr/lib64/libwayland-client.so.0.22.0)
==31113== by 0x402284: main (simple-im.c:492)
==31113==
==31113== 160,453 (136 direct, 160,317 indirect) bytes in 1 blocks are definitely lost in loss record 42 of 42
==31113== at 0x484A7BF: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==31113== by 0x48A4BB7: xkb_state_new (in /usr/lib64/libxkbcommon.so.0.0.0)
==31113== by 0x40198C: input_method_keyboard_keymap (simple-im.c:206)
==31113== by 0x4AD8961: ??? (in /usr/lib64/libffi.so.8.1.2)
==31113== by 0x4AD52DE: ??? (in /usr/lib64/libffi.so.8.1.2)
==31113== by 0x4AD7F25: ffi_call (in /usr/lib64/libffi.so.8.1.2)
==31113== by 0x487AA22: ??? (in /usr/lib64/libwayland-client.so.0.22.0)
==31113== by 0x487B202: ??? (in /usr/lib64/libwayland-client.so.0.22.0)
==31113== by 0x487B493: wl_display_dispatch_queue_pending (in /usr/lib64/libwayland-client.so.0.22.0)
==31113== by 0x40238A: main (simple-im.c:518)
==31113==
==31113== LEAK SUMMARY:
==31113== definitely lost: 512 bytes in 2 blocks
==31113== indirectly lost: 177,109 bytes in 1,863 blocks
==31113== possibly lost: 0 bytes in 0 blocks
==31113== still reachable: 0 bytes in 0 blocks
==31113== suppressed: 0 bytes in 0 blocks
==31113==
==31113== For lists of detected and suppressed errors, rerun with: -s
==31113== ERROR SUMMARY: 2 errors from 2 contexts (suppressed: 0 from 0)
```https://gitlab.freedesktop.org/wayland/weston/-/issues/783clients/stacking various improvements2023-07-25T07:08:23ZMarius Vladclients/stacking various improvements> A potential further follow-up from this would be improving the stacking client to allow a new window (similar to 'n') to create a new non-fullscreen window that also explicitly calls set_parent(nil).
The last part would probably need a...> A potential further follow-up from this would be improving the stacking client to allow a new window (similar to 'n') to create a new non-fullscreen window that also explicitly calls set_parent(nil).
The last part would probably need a toytoolkit adjustment as this is skipped entirely if the last parent match current one (which would be true in case of NULL -- or by default). With that I'd like to match what the gtk client is doing with the ability to turn on or off gtk_window_set_transient_for(). It seems that we have some unhandled corner cases.
Obviously also include your changes as well. Probably better to just add a couple of additional keys to do these.
https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/1261#note_1949810https://gitlab.freedesktop.org/wayland/weston/-/issues/601Split up clients/ into their own repository2022-08-10T07:25:22ZMarius VladSplit up clients/ into their own repositoryAs the $subj says, this issue is about taking out clients/ directory out of weston and move them into their own repository.
Would like to get some feedback on what other people think about that. Presumably this would be called wayland-...As the $subj says, this issue is about taking out clients/ directory out of weston and move them into their own repository.
Would like to get some feedback on what other people think about that. Presumably this would be called wayland-clients, or wayland-demo-clients, somewhere along those lines.
simple-clients we currently have would probably make the gist of it, but probably also some of the demo clients. In weston, we'll just have desktop-shell client, ivi one, and the screenshooter (IDK maybe a few more?). I guess also that some the clients might need a bit of work to deal with compositors not implementing certain protocols, but I see it the other way around as well, people adding protocols in clients such that it supports those extensions.
One of the issue people pointed was that clients/ would depend on libweston, and that's a fact that we have today (well not directly obviously, but in the meson build part), so I had a stab at it trying build only simple-clients out of clients/ directory. See https://gitlab.freedesktop.org/mvlad/weston/-/commits/wip/mvlad/only-clients-build for an example. Note that was just a hack but it is technically possible if we decide this is not really helpful and potentially go on this route, which was the initial thing I tried.https://gitlab.freedesktop.org/wayland/weston/-/issues/566Demote weston-terminal to a demo or remove it2022-01-10T20:59:57ZSimon Sercontact@emersion.frDemote weston-terminal to a demo or remove itI'm not sure it's a good idea for the Weston project to maintain a fully-fledged terminal emulator. I think it would be better to keep it as a demo instead. That way users can lower their expectations in terms of support and feature requ...I'm not sure it's a good idea for the Weston project to maintain a fully-fledged terminal emulator. I think it would be better to keep it as a demo instead. That way users can lower their expectations in terms of support and feature requests.
Potential action items:
- Clearly label it as a demo in the README
- Move it from the Meson option `tools` to `demo-clients`
- Don't install it by defaulthttps://gitlab.freedesktop.org/wayland/weston/-/issues/559Missing mouse support in weston-terminal2022-01-10T20:27:51ZDemi Marie Obenourdemiobenour@gmail.comMissing mouse support in weston-terminalweston-terminal doesn’t have mouse support.weston-terminal doesn’t have mouse support.https://gitlab.freedesktop.org/wayland/weston/-/issues/558Missing escape sequences in weston-terminal2022-01-10T20:27:49ZDemi Marie Obenourdemiobenour@gmail.comMissing escape sequences in weston-terminalweston-terminal is missing support for some escape sequences used by Vim.weston-terminal is missing support for some escape sequences used by Vim.https://gitlab.freedesktop.org/wayland/weston/-/issues/441The ball in weston-simple-damage leaves a trail after itself2022-01-13T22:20:18ZVlad ZahorodniiThe ball in weston-simple-damage leaves a trail after itselfIf weston-simple-damage runs with weston, the ball leaves a trail after itself. This bug can be also reproduced with kwin. It doesn't matter if transformed buffers are provided.If weston-simple-damage runs with weston, the ball leaves a trail after itself. This bug can be also reproduced with kwin. It doesn't matter if transformed buffers are provided.https://gitlab.freedesktop.org/wayland/weston/-/issues/371Fix Cairo vs. wl_shm pixel formats on big-endian2023-04-12T09:00:00ZPekka Paalanenppaalanen@gmail.comFix Cairo vs. wl_shm pixel formats on big-endianBackground: wayland/wayland#11
Weston clients, that use Cairo for drawing, use the Cairo ARGB format. They ~~translate~~ map this format unconditionally to `WL_SHM_FORMAT_ARGB8888` which is correct on little-endian machines.
That is wr...Background: wayland/wayland#11
Weston clients, that use Cairo for drawing, use the Cairo ARGB format. They ~~translate~~ map this format unconditionally to `WL_SHM_FORMAT_ARGB8888` which is correct on little-endian machines.
That is wrong on big-endian machines. On big-endian machines, the Cairo ARGB format corresponds to `WL_SHM_FORMAT_BGRA8888` instead.
If Weston running on big-endian machine does not support `WL_SHM_FORMAT_BGRA8888`, then that support will need to be added.https://gitlab.freedesktop.org/wayland/weston/-/issues/280toytoolkit’s keyboard_repeat_func() is producing unusable timestamps2019-10-17T11:42:40ZLink Mauvetoytoolkit’s keyboard_repeat_func() is producing unusable timestampsWhen using `window_set_key_handler()`, pressed and released events work as expected, but the timerfd-driven key repeats, generated from the `keyboard_repeat_func()` callback, all share the pressed event’s timestamp `input->repeat_time`.
...When using `window_set_key_handler()`, pressed and released events work as expected, but the timerfd-driven key repeats, generated from the `keyboard_repeat_func()` callback, all share the pressed event’s timestamp `input->repeat_time`.
This prevents the timestamp from being used in any usable fashion.https://gitlab.freedesktop.org/wayland/weston/-/issues/95Use HiDPI cursors in clients where applicable2018-06-30T11:17:38ZBugzilla Migration UserUse HiDPI cursors in clients where applicable## Submitted by Link Mauve
Assigned to **Wayland bug list**
**[Link to original bug (#101609)](https://bugs.freedesktop.org/show_bug.cgi?id=101609)**
## Description
Clients currently always use a scale=1 cursor, which looks worse ...## Submitted by Link Mauve
Assigned to **Wayland bug list**
**[Link to original bug (#101609)](https://bugs.freedesktop.org/show_bug.cgi?id=101609)**
## Description
Clients currently always use a scale=1 cursor, which looks worse than it could on HiDPI outputs.
### Depends on
* [Bug 101608](https://bugs.freedesktop.org/show_bug.cgi?id=101608)https://gitlab.freedesktop.org/wayland/weston/-/issues/89Add autohide option for panels2018-06-30T11:15:56ZBugzilla Migration UserAdd autohide option for panels## Submitted by Bug Report
Assigned to **Wayland bug list**
**[Link to original bug (#100272)](https://bugs.freedesktop.org/show_bug.cgi?id=100272)**
## Description
Please add a autohide option or a function call for panels that a...## Submitted by Bug Report
Assigned to **Wayland bug list**
**[Link to original bug (#100272)](https://bugs.freedesktop.org/show_bug.cgi?id=100272)**
## Description
Please add a autohide option or a function call for panels that autohide. Maximized windows can then cover the whole screen without patching weston.https://gitlab.freedesktop.org/wayland/weston/-/issues/83[weston-terminal] xterm mouse tracking protocol2018-06-30T11:12:45ZBugzilla Migration User[weston-terminal] xterm mouse tracking protocol## Submitted by Telnet User
Assigned to **Wayland bug list**
**[Link to original bug (#97919)](https://bugs.freedesktop.org/show_bug.cgi?id=97919)**
## Description
weston-terminal doesn't support xterm mouse tracking protocol[1]. ...## Submitted by Telnet User
Assigned to **Wayland bug list**
**[Link to original bug (#97919)](https://bugs.freedesktop.org/show_bug.cgi?id=97919)**
## Description
weston-terminal doesn't support xterm mouse tracking protocol[1]. Mouse tracking makes it easy to navigate inside apps that support it, e.g. links browser, vim (via set mouse=a), and emacs (via xterm-mouse-mode).
It would be better to add mouse tracking support into weston-terminal for better interactive terminal use.
[1] http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-Mouse-Trackinghttps://gitlab.freedesktop.org/wayland/weston/-/issues/75ASAN reports heap-buffer-overflow in terminal2018-06-30T11:08:02ZBugzilla Migration UserASAN reports heap-buffer-overflow in terminal## Submitted by comicfans44
Assigned to **Wayland bug list**
**[Link to original bug (#94760)](https://bugs.freedesktop.org/show_bug.cgi?id=94760)**
## Description
hard to re-produce
```
=========================================...## Submitted by comicfans44
Assigned to **Wayland bug list**
**[Link to original bug (#94760)](https://bugs.freedesktop.org/show_bug.cgi?id=94760)**
## Description
hard to re-produce
```
=================================================================
==1113==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60b00000876e at pc 0x40e426 bp 0x7ffe02b09400 sp 0x7ffe02b093f0
READ of size 1 at 0x60b00000876e thread T0
#0 0x40e425 in handle_special_char clients/terminal.c:1906
#1 0x40e7a0 in handle_char clients/terminal.c:1952
#2 0x4135f6 in terminal_data clients/terminal.c:2169
#3 0x4135f6 in io_handler clients/terminal.c:3018
#4 0x430f24 in display_run clients/window.c:5970
#5 0x406184 in main clients/terminal.c:3106
#6 0x7fa3092d959f in __libc_start_main (/lib64/libc.so.6+0x2059f)
#7 0x406388 in _start (/usr/bin/weston-terminal+0x406388)
0x60b00000876e is located 0 bytes to the right of 110-byte region [0x60b000008700,0x60b00000876e)
allocated by thread T0 here:
#0 0x7fa30b2b4935 in calloc (/usr/lib/gcc/x86_64-pc-linux-gnu/4.9.3/libasan.so.1+0x57935)
#1 0x40fea7 in zalloc shared/zalloc.h:38
#2 0x40fea7 in terminal_resize_cells clients/terminal.c:782
#3 0x40fea7 in resize_handler clients/terminal.c:872
SUMMARY: AddressSanitizer: heap-buffer-overflow clients/terminal.c:1906 handle_special_char
Shadow bytes around the buggy address:
0x0c167fff9090: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff90a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff90b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
0x0c167fff90c0: fa fa fa fa fa fa fa fa fa fa 00 00 00 00 00 00
0x0c167fff90d0: 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa fa
=>0x0c167fff90e0: 00 00 00 00 00 00 00 00 00 00 00 00 00[06]fa fa
0x0c167fff90f0: fa fa fa fa fa fa 00 00 00 00 00 00 00 00 00 00
0x0c167fff9100: 00 00 00 fa fa fa fa fa fa fa fa fa 00 00 00 00
0x0c167fff9110: 00 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa
0x0c167fff9120: fa fa 00 00 00 00 00 00 00 00 00 00 00 00 00 fa
0x0c167fff9130: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Contiguous container OOB:fc
ASan internal: fe
==1113==ABORTING
```https://gitlab.freedesktop.org/wayland/weston/-/issues/53Use toytoolkit in a test for interactive window move2018-06-30T10:54:01ZBugzilla Migration UserUse toytoolkit in a test for interactive window move## Submitted by Pekka Paalanen
Assigned to **Wayland bug list**
**[Link to original bug (#83990)](https://bugs.freedesktop.org/show_bug.cgi?id=83990)**
## Description
Write a test, that:
1. creates a window with normal decorations...## Submitted by Pekka Paalanen
Assigned to **Wayland bug list**
**[Link to original bug (#83990)](https://bugs.freedesktop.org/show_bug.cgi?id=83990)**
## Description
Write a test, that:
1. creates a window with normal decorations using toytoolkit
2. check the window position via the test extension
3. sends fake input events
3.1. move the pointer over the window title bar
3.2. button down
3.3. move the pointer to another place
3.4. button up
4. check the window position via the test extension, that it moved correctly
This sounds simple, but requires one to write the infrastructure for using toytoolkit in tests, maybe change how wl_test pointer events are done, and add a way to query surface location.
For examples, see https://github.com/01org/wayland-fits for the test protocol and the weston plugin.
If bug #83987 is implemented, can also add screenshot based verification, which would make sure that toytoolkit draws decorations properly. But that opens a whole new road for adding tests.
### Blocking
* [Bug 83980](https://bugs.freedesktop.org/show_bug.cgi?id=83980)https://gitlab.freedesktop.org/wayland/weston/-/issues/45Weston-editor text deleted when inserting new text2018-06-30T10:50:35ZBugzilla Migration UserWeston-editor text deleted when inserting new text## Submitted by Anu Reddy
Assigned to **Wayland bug list**
**[Link to original bug (#83778)](https://bugs.freedesktop.org/show_bug.cgi?id=83778)**
## Description
Steps to Reproduce:
1. Launch weston
2. Execute weston-editor
3. Usi...## Submitted by Anu Reddy
Assigned to **Wayland bug list**
**[Link to original bug (#83778)](https://bugs.freedesktop.org/show_bug.cgi?id=83778)**
## Description
Steps to Reproduce:
1. Launch weston
2. Execute weston-editor
3. Using weston-keyboard, type some text into Entry field.
4. Now, touch anywhere within the line to insert new text
5. Observe that text gets selected.
5. When you try to type new text, the selected text will be deleted. See attached video for more info.
Software Stack
wayland (HEAD) remotes/origin/HEAD-0-g44bf13b
drm (HEAD) heads/master-16-gd686160
mesa (HEAD) remotes/origin/10.2-0-g7ffc855
libva (HEAD) libva-1.3.1-0-g053f70f
intel-driver (HEAD) 1.3.1-0-ga720bc8
cairo (HEAD) remotes/origin/1.12-0-g4b65497
libinput (HEAD) heads/master-163-gbb10ec8https://gitlab.freedesktop.org/wayland/weston/-/issues/40terminal: console not clearing on exit from vim, vi or nano2018-06-30T10:44:54ZBugzilla Migration Userterminal: console not clearing on exit from vim, vi or nano## Submitted by kabeer
Assigned to **Wayland bug list**
**[Link to original bug (#82766)](https://bugs.freedesktop.org/show_bug.cgi?id=82766)**
## Description
Created attachment 104816
Screenshot of bug while using vim in weston c...## Submitted by kabeer
Assigned to **Wayland bug list**
**[Link to original bug (#82766)](https://bugs.freedesktop.org/show_bug.cgi?id=82766)**
## Description
Created attachment 104816
Screenshot of bug while using vim in weston console
I am new to community. While testing weston I found that screen is not clearing when we exit from any of the console editors. This problem persists with vim,vi and nano.
Screenshot is attached
**Attachment 104816**, "Screenshot of bug while using vim in weston console":
![WestonVimBug](/uploads/cb8d850200540f14839649790b152b86/WestonVimBug.png)
Version: 1.5.0https://gitlab.freedesktop.org/wayland/weston/-/issues/28weston dnd client render issues2018-06-30T10:14:02ZBugzilla Migration Userweston dnd client render issues## Submitted by Brian Lovin
Assigned to **Wayland bug list**
**[Link to original bug (#56298)](https://bugs.freedesktop.org/show_bug.cgi?id=56298)**
## Description
System Environment:
--------------------------
Distro: Ubuntu 12.0...## Submitted by Brian Lovin
Assigned to **Wayland bug list**
**[Link to original bug (#56298)](https://bugs.freedesktop.org/show_bug.cgi?id=56298)**
## Description
System Environment:
--------------------------
Distro: Ubuntu 12.04
Arch: x86_64
cairo master db488a1703d4ef3bcbd54138b51c01600a2f4d3a
dri2proto master 4eeacce4c4a300b938b7e3fb78a8e443c491780b
drm master 844d75e5a0b3b8f3466a24256955e886275fb298
glproto master ec1eec4355ee4a6c5134f2178192f10b6d28a87a
kbproto master 391a1f6de6315fc0196d407d800597488315cccb
libX11 master d45b3fc19fbe95c41afc4e51d768df6d42332010
libxkbcommon master 3477d9e4480f4f2607d371345cc1c09bb8a35c78
macros master 0890e4003aacfa7113ab3f4e3ad7c5636f8e922a
mesa master df3721fd2e10ef27ce12a0c1025c9770137fa8f7
pixman master 2e17b6dd4ee7c32684fb7ffc70d3ad3ebf7cb2ef
wayland master 0371668dcca5aa29c0fc4b59b974e40bcf073563
weston master 4e07236e8702ff22e2398214a15f7d1e7561caf6
Detailed Description:
-----------------------------
I have observed multiple issues with rendering under the DnD client - I combined them all into this one bug.
Issue 1: When a flower is dropped it "flashes" for a brief moment only when mouse is stopped, if mouse cursor is in movement the flower won't flash
Issue 2: When a flower is clicked it moves a couple pixels - even if the mouse hasn't moved.
Issue 3: When you release the mouse button after draging and dropping, but don't move the mouse the incorrect cursor is displayed.
Issue 4: When DND client is spun around it's axis and a flower is picked up to be dragged it "snaps" back to it's original position - sometimes off the mouse cursor
Steps to Reproduce:
----------------------------
1. start weston under X11 or DRM mode
2. ./dnd
3. Drag and drop items (same window is OK), click items, spin window and drop items, release mouse and observe the incorrect cursorhttps://gitlab.freedesktop.org/wayland/weston/-/issues/8Toytoolkit could use a fallback cursor2023-07-04T15:34:32ZBugzilla Migration UserToytoolkit could use a fallback cursor## Submitted by Pekka Paalanen `@pq`
Assigned to **Pekka Paalanen `@pq`**
**[Link to original bug (#7343)](https://phabricator.freedesktop.org/T7343)**
## Description
If toytoolkit tries to load a cursor that does not exist, it wi...## Submitted by Pekka Paalanen `@pq`
Assigned to **Pekka Paalanen `@pq`**
**[Link to original bug (#7343)](https://phabricator.freedesktop.org/T7343)**
## Description
If toytoolkit tries to load a cursor that does not exist, it will complain and presumably continue with no image for that cursor. This likely leads to the cursor disappearing when attempting to use a cursor not found. It would be much better, if in addition to complaining, toytoolkit would fall back to a cursor that is obviously wrong.
This issue was encountered with the Weston DND demo, when no real cursor theme was available, and the new dnd cursors are not found in libwayland-cursor.
Should the fallback cursor be provided by toytoolkit itself, or by libwayland-cursor default cursors, or by picking some default cursor already provided by libwayland-cursor?