1. 06 Feb, 2019 11 commits
    • Alexandros Frantzis's avatar
      tests: Add tests for per commit zwp_buffer_release_v1 behavior · c715c750
      Alexandros Frantzis authored
      Add tests to check that the zwp_buffer_release_v1 events are emitted per
      surface commit.
      
      To be able to test this we need to use a renderer that holds the buffer
      until the next buffer is committed, hence we use the pixman renderer.
      
      Changes in v7:
        - Remove references to obsolete noop-hold renderer.
      
      Changes in v5:
        - Meson support.
      
      Changes in v4:
        - Use the pixman renderer instead of the (now gone) noop-hold
          renderer.
      Signed-off-by: Alexandros Frantzis's avatarAlexandros Frantzis <alexandros.frantzis@collabora.com>
      c715c750
    • Alexandros Frantzis's avatar
      libweston: Support zwp_surface_synchronization_v1.get_release · 67629674
      Alexandros Frantzis authored
      Implement the get_release request of the zwp_surface_synchronization_v1
      interface.
      
      This commit implements the zwp_buffer_release_v1 interface. It supports
      the zwp_buffer_release_v1.fenced_release event for surfaces rendered by
      the GL renderer, and the zwp_buffer_release_v1.immediate_release event
      for other cases.
      
      Note that the immediate_release event is safe to be used for surface
      buffers used as planes in the DRM backend, since the backend releases
      them only after the next page flip that doesn't use the buffers has
      finished.
      
      Changes in v7:
        - Remove "partial" from commit title and description.
        - Fix inverted check when clearing used_in_output_repaint flag.
      
      Changes in v5:
        - Use the new, generic explicit sync server error reporting function.
        - Introduce and use weston_buffer_release_move.
        - Introduce internally and use weston_buffer_release_destroy.
      
      Changes in v4:
        - Support the zwp_buffer_release_v1.fenced_release event.
        - Support release fences in the GL renderer.
        - Assert that pending state buffer_release is always NULL after a
          commit.
        - Simplify weston_buffer_release_reference.
        - Move removal of destroy listener before resource destruction to
          avoid concerns about use-after-free in
          weston_buffer_release_reference
        - Rename weston_buffer_release_reference.busy_count to ref_count.
        - Add documentation for weston_buffer_release and ..._reference.
      
      Changes in v3:
        - Raise NO_BUFFER for get_release if no buffer has been committed,
          don't raise UNSUPPORTED_BUFFER for non-dmabuf buffers,
          so get_release works for all valid buffers.
        - Destroy the buffer_release object after sending an event.
        - Track lifetime of buffer_release objects per commit, independently
          of any buffers.
        - Use updated protocol interface names.
        - Use correct format specifier for resource ids.
      
      Changes in v2:
        - Raise UNSUPPORTED_BUFFER at commit if client has requested a
          buffer_release, but the committed buffer is not a valid linux_dmabuf.
        - Remove tests that are not viable anymore due to our inability to
          create dmabuf buffers and fences in a unit-test environment.
      Signed-off-by: Alexandros Frantzis's avatarAlexandros Frantzis <alexandros.frantzis@collabora.com>
      67629674
    • Alexandros Frantzis's avatar
      libweston: Support zwp_surface_synchronization_v1.set_acquire_fence · acff29b3
      Alexandros Frantzis authored
      Implement the set_acquire_fence request of the
      zwp_surface_synchronization_v1 interface.
      
      The implementation uses the acquire fence in two ways:
      
      1. If the associated buffer is used as GL render source, an
         EGLSyncKHR is created from the fence and used to synchronize
         access.
      2. If the associated buffer is used as a plane framebuffer,
         the acquire fence is treated as an in-fence for the atomic
         commit operation. If in-fences are not supported and the buffer
         has an acquire fence, we don't consider it for plane placement.
      
      If the used compositor/renderer doesn't support explicit
      synchronization, we don't advertise the protocol at all. Currently only
      the DRM and X11 backends when using the GL renderer advertise the
      protocol for production use.
      
      Issues for discussion
      ---------------------
      
      a. Currently, a server-side wait of EGLSyncKHR is performed before
         using the EGLImage/texture during rendering. Unfortunately, it's not clear
         from the specs whether this is generally safe to do, or we need to
         sync before glEGLImageTargetTexture2DOES. The exception is
         TEXTURE_EXTERNAL_OES where the spec mentions it's enough to sync
         and then glBindTexture for any changes to take effect.
      
      Changes in v5:
        - Meson support.
        - Make explicit sync server error reporting more generic, supporting
          all explicit sync related interfaces not just
          wp_linux_surface_synchronization.
        - Fix typo in warning for missing EGL_KHR_wait_sync extension.
        - Support minor version 2 of the explicit sync protocol (i.e., support
          fences for opaque EGL buffers).
      
      Changes in v4:
        - Introduce and use fd_clear and and fd_move helpers.
        - Don't check for a valid buffer when updating surface acquire fence fd
          from state.
        - Assert that pending state acquire fence fd is always clear
          after a commit.
        - Clarify that WESTON_CAP_EXPLICIT_SYNC applies to just the
          renderer.
        - Check for EGL_KHR_wait_sync before using eglWaitSyncKHR.
        - Dup the acquire fence before passing to EGL.
      
      Changes in v3:
        - Keep acquire_fence_fd in surface instead of buffer.
        - Clarify that WESTON_CAP_EXPLICIT_SYNC applies to both backend and
          renderer.
        - Move comment about non-ownership of in_fence_fd to struct
          drm_plane_state definition.
        - Assert that we don't try to use planes with in-fences when using the
          legacy KMS API.
        - Remove unnecessary info from wayland error messages.
        - Handle acquire fence for subsurface commits.
        - Guard against self-update in fd_update.
        - Disconnect the client if acquire fence EGLSyncKHR creation or wait
          fails.
        - Use updated protocol interface names.
        - User correct format specifier for resource ids.
        - Advertise protocol for X11 backend with GL renderer.
      
      Changes in v2:
        - Remove sync file wait fallbacks.
        - Raise UNSUPPORTED_BUFFER error at commit if we have an acquire
          fence, but the committed buffer is not a valid linux_dmabuf.
        - Don't put buffers with in-fences on planes that don't support
          in-fences.
        - Don't advertise explicit sync protocol if backend does not
          support explicit sync.
      Signed-off-by: Alexandros Frantzis's avatarAlexandros Frantzis <alexandros.frantzis@collabora.com>
      acff29b3
    • Alexandros Frantzis's avatar
      libweston: Introduce an internal linux sync file API · c0e2f926
      Alexandros Frantzis authored
      Introduce an internal API for dealing with linux sync files,
      and use it in the codebase to replace ad-hoc sync file management.
      
      The linux_sync_file_is_valid function is not currently used, but will be
      utilized in upcoming commits to implement the
      zwp_linux_explicit_synchronization_unstable_v1 protocol.
      
      Changes in v5:
        - Meson support.
      
      Changes in v3:
        - Use parameter name in function documentation.
        - Move kernel UAPI to separate header file.
      
      Changes in v2:
        - Add function documentation
        - Remove linux_sync_file_wait()
      Signed-off-by: Alexandros Frantzis's avatarAlexandros Frantzis <alexandros.frantzis@collabora.com>
      c0e2f926
    • Alexandros Frantzis's avatar
      libweston: Introduce zwp_linux_explicit_synchronization_v1 · 27d7c395
      Alexandros Frantzis authored
      Introduce support for the zwp_linux_explicit_synchronization_unstable_v1
      protocol with an implementation of the zwp_linux_explicit_synchronization_v1
      interface.
      
      Explicit synchronization provides a more versatile notification
      mechanism for buffer readiness and availability, and can be used to
      improve efficiency by integrating with related functionality in display
      and graphics APIs.
      
      In addition, the per-commit nature of the release events provided by
      this protocol potentially offers a solution to a deficiency of the
      wl_buffer.release event (see
      wayland#46).
      
      Support for this protocol depends on the capabilities of the backend, so
      we don't register it by default but provide a function which each
      backend will need to call. In this commit only the headless backend when
      using the noop renderer supports this to enable testing.
      
      Note that the zwp_surface_synchronization_v1 interface, which contains
      the core functionality of the protocol, is not implemented in this
      commit. Support for it will be added in future commits.
      
      Changes in v7:
        - Added some information in the commit message about the benefits of
          the explicit sync protocol.
      
      Changes in v6:
        - Fall back to advertising minor version 1 of the explicit sync protocol,
          although we support minor version 2 features, until the new
          wayland-protocols version is released.
      
      Changes in v5:
        - Meson support.
        - Advertise minor version 2 of the explicit sync protocol.
      
      Changes in v4:
        - Enable explicit sync support in the headless backend for all
          renderers.
      
      Changes in v3:
        - Use wl_resource_get_version() instead of hardcoding version 1.
        - Use updated protocol interface names.
        - Use correct format specifier for resource id.
        - Change test name to 'linux-explicit-synchronization.weston'
          (s/_/-/g).
      
      Changes in v2:
        - Move implementation to separate file so protocol can be registered
          on demand by backends.
        - Register protocol in headless+noop backend for testing purposes.
      Signed-off-by: Alexandros Frantzis's avatarAlexandros Frantzis <alexandros.frantzis@collabora.com>
      27d7c395
    • Pekka Paalanen's avatar
      tests: use weston_compositor_exit · a37920e7
      Pekka Paalanen authored
      Use the proper function to exit instead of the libwayland one, to allow main
      handle_exit() to be called.
      
      This is just to unify the exit paths.
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
      a37920e7
    • Pekka Paalanen's avatar
      ivi-shell: use weston_compositor_exit · 818c20e7
      Pekka Paalanen authored
      Use the proper function to exit instead of the libwayland one, to allow main
      handle_exit() to be called.
      
      This is just to unify the exit paths.
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
      818c20e7
    • Pekka Paalanen's avatar
      desktop-shell: use weston_compositor_exit · 052032d7
      Pekka Paalanen authored
      Use the proper weston_compositor_exit API instead of wl_display_terminate() to
      allow the compositor main to prepare for exit, and most importantly to set the
      exit error code as appropriate.
      
      I have some brokenness in my test suite running, and weston-desktop-shell was
      crashing at start, yet the tests did not notice. With this patch, the tests
      where the helper crashes are properly marked as failed.
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
      052032d7
    • Eric Toombs's avatar
      weston: add more libinput config options · 6e229ca2
      Eric Toombs authored
      This is so that, for instance, people using weston as their main Wayland
      compositor can invert the sense of two finger scrolling or change
      pointer acceleration using weston.ini, rather than having to edit C
      code.
      
      All of the options that libinput itself exposes through its API are now
      exposed in weston.ini.  The new options are called `tap-and-drag`,
      `tap-and-drag-lock`, `disable-while-typing`, `middle-emulation`,
      `left-handed`, `rotation`, `accel-profile`, `accel-speed`,
      `scroll-method`, `natural-scroll`, and `scroll-button`. I have
      successfully tested everything except for `rotation`, out of a lack of
      hardware support.
      
      weston now depends directly on libevdev for turning button name strings into
      kernel input codes. This was needed for the `scroll-button` config
      option. (weston already depends indirectly on libevdev through
      libinput, so I figured people would be OK with this.) As a practical
      matter for debian-style packagers, weston now has a build dependency on
      libevdev-dev.
      
      Right now, the code applies the same options to all attached devices
      that a given option is relevant for. There are plans for multiple
      [libinput] sections, each with different device filters, for users who
      need more control here.
      Signed-off-by: Eric Toombs's avatarEric Toombs <3672-ewtoombs@users.noreply.gitlab.freedesktop.org>
      6e229ca2
    • Eric Toombs's avatar
      weston: deprecate enable_tap in favour of enable-tap · 9d222038
      Eric Toombs authored
      This is to increase consistency in config option naming in weston.ini.
      (Prefer hyphens over underscores to separate words.)
      
      If enable_tap is present in weston.ini, an obnoxious error message is
      logged with weston_log(). In terms of configuration, if enable-tap is
      present, enable_tap is ignored.
      Signed-off-by: Eric Toombs's avatarEric Toombs <3672-ewtoombs@users.noreply.gitlab.freedesktop.org>
      9d222038
    • Eric Toombs's avatar
  2. 01 Feb, 2019 1 commit
  3. 31 Jan, 2019 10 commits
  4. 29 Jan, 2019 1 commit
  5. 25 Jan, 2019 2 commits
  6. 23 Jan, 2019 4 commits
  7. 22 Jan, 2019 1 commit
  8. 17 Jan, 2019 3 commits
  9. 10 Jan, 2019 1 commit
  10. 09 Jan, 2019 2 commits
  11. 07 Jan, 2019 1 commit
    • Pekka Paalanen's avatar
      tests: remove remnants of buffer-count test · 91bf16be
      Pekka Paalanen authored
      The buffer-count test was added in
      40c0c3f9 and removed in
      4938f93f, but the removal left around
      the dependency to EGL headers in weston-test.c.
      
      Removal of those unneeded includes allows us to drop the EGL dependency
      completely from weston-test.c build.
      
      For the Meson build this means that there are no dependency('egl')
      directives anymore without the user friendly error message.
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pq@iki.fi>
      91bf16be
  12. 31 Dec, 2018 3 commits