Skip to content
Commit d4eafbaa authored by Pekka Paalanen's avatar Pekka Paalanen Committed by Daniel Stone
Browse files

backend-wayland: fix pixman buffer size



As wayland-backend is blitting the output decorations into the output
buffer itself, it pretends towards the pixman-renderer that there is no
decorations area. The pixman_image_create_bits() call wraps the
previously allocated buffer with an offset so that pixman-renderer will
paint in the right position.

The bug is that this pixman image was using the original buffer width
and height, instead of the composited area width and height. So the
pixman image looks too big to pixman-renderer, but the renderer didn't
care. The image being too big does risk access out of bounds in
pixman-renderer.

I found this when I was making renderers explicitly aware of the
frambuffer size and resizing, added asserts, and they surprisingly
failed. This fixes that.

Signed-off-by: default avatarPekka Paalanen <pekka.paalanen@collabora.com>
parent 214d48bb
Loading
Loading
Loading
Pipeline #654751 passed with stages
in 2 minutes and 8 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment