Skip to content
Commit 56d3ea12 authored by Derek Foreman's avatar Derek Foreman
Browse files

xcb-client-helper: Call xcb_wait_for_event directly



We're currently calling ppoll() before calling xcb_wait_for_event(), which
may be due to initially trying to make this non-blocking.

However, xcb_wait_for_event() reads all events available - even if there
are more than one.

There are a handful of X properties we're sent that we don't explicitly
ask for, and if these end up in the same read, we could theoretically
end up in a poll() with nothing coming in.

Drop the extra ppoll() and just let xcb_wait_for_event() do the blocking
for us.

I'm hoping this fixes the occasional timeout in the xwayland test, but
it's a reasonable code simplification even if it doesn't.

Signed-off-by: default avatarDerek Foreman <derek.foreman@collabora.com>
parent 2d3cca3d
Loading
Loading
Loading
Pipeline #1152563 passed with stages
in 4 minutes and 44 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment