Skip to content
Snippets Groups Projects
Commit 2b69bc08 authored by Théo Maillart's avatar Théo Maillart Committed by Marius Vlad
Browse files

gl-renderer: clip subimage dimensions to its buffer ones


A window freeze can occur in specific use cases like when using a kiosk
shell. It scales surfaces to fit the compositor size and the transformation
to buffer space can, in some cases, round the size one pixel higher than
the texture size, making glTexSubImage2D() refuse the size argument and
generate a GL_INVALID_VALUE without updating the texture.
This commit ensures the GL renderer doesn't exceed the texture size.

Here is how the issue was reproduced:
	$ weston --renderer=gl --backend=wayland --width=1920 --height=1080 --shell=kiosk
	$ gst-launch-1.0 videotestsrc ! video/x-raw,height=590,width=500 ! waylandsink display=wayland-1

Signed-off-by: default avatarThéo Maillart <tmaillart@freebox.fr>
parent bfb2dfae
1 merge request!1692gl-renderer: clip subimage dimensions to its buffer ones
Checking pipeline status
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment