Commit 0bbe624b authored by Pekka Paalanen's avatar Pekka Paalanen

xwm: explain the read_properties() in xserver_map_shell_surface()

To me it was not obvious that this call is necessary, so provide some
rationale.
Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Daniel Stone's avatarDaniel Stone <daniels@collabora.com>
parent 9f5a1031
......@@ -2659,6 +2659,15 @@ xserver_map_shell_surface(struct weston_wm_window *window,
wm->server->compositor->xwayland_interface;
struct weston_wm_window *parent;
/* This should be necessary only for override-redirected windows,
* because otherwise MapRequest handler would have already updated
* the properties. However, if X11 clients set properties after
* sending MapWindow, here we can still process them. The decorations
* have already been drawn once with the old property values, so if the
* app changes something affecting decor after MapWindow, we glitch.
* We only hit xserver_map_shell_surface() once per MapWindow and
* wl_surface, so better ensure we get the window type right.
*/
weston_wm_window_read_properties(window);
/* A weston_wm_window may have many different surfaces assigned
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment