Skip to content
Commit 0aac3dd3 authored by Derek Foreman's avatar Derek Foreman
Browse files

xwm: Don't send synthetic ConfigureNotify to windows that were mapped O-R



It's entirely possible, if ridiculous, for an X11 client to change a
window's override redirect flag while it's mapped. If this changes from
true to false we will start receiving Configure requests for the window.

That leads us to a crash when we try to query the window's current
position from the shell to send a configure notify event, as the shell
doesn't know about the surface.

Instead of trying to cleverly handle this, mostly go back to the behaviour
these clients would've seen before commit cf5aca5a and don't send them
a synthetic configure notify.

We also specifically check in weston_wm_handle_configure_request for
the same condition, and early return there, bypassing a couple of
other things we would've done previously.

Signed-off-by: default avatarDerek Foreman <derek.foreman@collabora.com>
parent 3387afd5
Loading
Loading
Loading
Pipeline #653601 passed with stages
in 4 minutes and 29 seconds
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment