Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
W
weston
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 273
    • Issues 273
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 114
    • Merge Requests 114
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • wayland
  • weston
  • Issues
  • #338

Closed
Open
Opened Jan 13, 2020 by Pekka Paalanen@pqMaintainer

weston_log_ctx_compositor_*() API problems

  • weston_log_ctx_compositor_create() should be called weston_log_ctx_create() because it has no relation to any compositor.

  • weston_log_ctx_compositor_setup() should be folded into weston_compositor_create() and disappear.

  • weston_log_ctx_compositor_destroy() takes a weston_compositor as argument, how is one supposed to destroy a log context that was never associated with any weston_compositor? Instead, weston_log_ctx_destroy() should take a weston_log_context as the argument.

The last one is not trivial because of weston_log_context::global which needs to be destroyed with weston_compositor. Maybe that variable should live in struct weston_compositor instead?

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: wayland/weston#338