GitLab

Wishing for the RDP-backend to improve, I read through its code. These are my notes. I did not bother to open a new issue for each single one, but feel free to open Issues or MRs as you see fit, mention them here and I will update this description with a link.

• seat release, needs safe wl_global removal in libweston core from #322
• call weston_head_set_monitor_strings() when creating the head
• weston_head_set_physical_size() parameters from remote screen physical size? #324 (closed)
• drop manually created shadow buffer, seems unused
• prevent mode list from growing unlimited in ensure_matching_mode()
• rdp_output_repaint(): implement frame-dropping or throttle to transmission framerate to avoid slow-motion updates in the remote?
• rdp_peer_refresh_raw():
  • marker.frameID++ uninitialized?
  • what if heightIncrement starts zero due to a very wide rect?
• rdp_peer_refresh_nsc():
  • suspicious #ifdef-skipping of memset() to zero; would be better to use unconditional initialization
  • why does it use damage extents instead of rects?
• rdp_peer_refresh_rfx():
  • suspicious #ifdef-skipping of memset() to zero; would be better to use unconditional initialization
  • why offset ptr by extents x1, y1?
• log RDP remote actions with a new debug scope, e.g. rdp_peer_refresh_*(), input events, connects and disconnects
• clean up #ifdefs for old freerdp versions according to what the build requires today