Valgrind error on shutdown

Submitted by Rob Bradford

Assigned to Wayland bug list

Link to original bug (#68157)

Description

When running with the RDP backend (which removes and adds seats) the following valgrind error occurs on shutdown:

valgrind shows:

==6506== Invalid read of size 8
==6506==    at 0x419F89: unbind_input_method (text-backend.c:743)
==6506==    by 0x4E3AA8D: destroy_resource (wayland-server.c:434)
==6506==    by 0x4E407B9: for_each_helper (wayland-util.c:353)
==6506==    by 0x4E407F5: wl_map_for_each (wayland-util.c:359)
==6506==    by 0x4E3ADA5: wl_client_destroy (wayland-server.c:574)
==6506==    by 0x41A4E8: text_backend_notifier_destroy (text-backend.c:931)
==6506==    by 0x408EE8: wl_signal_emit (wayland-server.h:171)
==6506==    by 0x41058D: main (compositor.c:3429)
==6506==  Address 0x8825a30 is 112 bytes inside a block of size 120 free'd
==6506==    at 0x4C2AF7C: free (vg_replace_malloc.c:446)
==6506==    by 0x41A111: input_method_notifier_destroy (text-backend.c:797)
==6506==    by 0x4106A8: wl_signal_emit (wayland-server.h:171)
==6506==    by 0x413DE5: weston_seat_release (input.c:1573)
==6506==    by 0x88343B3: rdp_peer_context_free (compositor-rdp.c:603)
==6506==    by 0x883445D: rdp_client_activity (compositor-rdp.c:622)
==6506==    by 0x4E3C967: wl_event_source_fd_dispatch (event-loop.c:86)
==6506==    by 0x4E3D318: wl_event_loop_dispatch (event-loop.c:421)
==6506==    by 0x4E3B615: wl_display_run (wayland-server.c:836)
==6506==    by 0x41056C: main (compositor.c:3423)
==6506== 
==6506== Invalid write of size 8
==6506==    at 0x419F95: unbind_input_method (text-backend.c:745)
==6506==    by 0x4E3AA8D: destroy_resource (wayland-server.c:434)
==6506==    by 0x4E407B9: for_each_helper (wayland-util.c:353)
==6506==    by 0x4E407F5: wl_map_for_each (wayland-util.c:359)
==6506==    by 0x4E3ADA5: wl_client_destroy (wayland-server.c:574)
==6506==    by 0x41A4E8: text_backend_notifier_destroy (text-backend.c:931)
==6506==    by 0x408EE8: wl_signal_emit (wayland-server.h:171)
==6506==    by 0x41058D: main (compositor.c:3429)
==6506==  Address 0x88259c0 is 0 bytes inside a block of size 120 free'd
==6506==    at 0x4C2AF7C: free (vg_replace_malloc.c:446)
==6506==    by 0x41A111: input_method_notifier_destroy (text-backend.c:797)
==6506==    by 0x4106A8: wl_signal_emit (wayland-server.h:171)
==6506==    by 0x413DE5: weston_seat_release (input.c:1573)
==6506==    by 0x88343B3: rdp_peer_context_free (compositor-rdp.c:603)
==6506==    by 0x883445D: rdp_client_activity (compositor-rdp.c:622)
==6506==    by 0x4E3C967: wl_event_source_fd_dispatch (event-loop.c:86)
==6506==    by 0x4E3D318: wl_event_loop_dispatch (event-loop.c:421)
==6506==    by 0x4E3B615: wl_display_run (wayland-server.c:836)
==6506==    by 0x41056C: main (compositor.c:3423)

Copied from https://bugs.freedesktop.org/show_bug.cgi?id=67231 (about a different but similar issue)