Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
W
weston
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 273
    • Issues 273
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 117
    • Merge Requests 117
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • wayland
  • weston
  • Issues
  • #250

Closed
Open
Opened Jun 06, 2019 by Pekka Paalanen@pqMaintainer

Move `#ifdef HAVE_DRM_ATOMIC` code into new file

There is a big chunk of code under #ifdef HAVE_DRM_ATOMIC in drm.c. It is easy to add new code inside that chunk without realizing it, leading to problems like !48 (comment 172224) .

All that code should be moved into a new source file drm-atomic.c, built conditional on what triggers HAVE_DRM_ATOMIC. When drm-atomic.c is not built, a private header needs to provide stub functions returning failures, so that we can drop almost all #ifdef HAVE_DRM_ATOMIC from drm.c.

Few special cases that still need #ifdef HAVE_DRM_ATOMIC in drm.c may remain.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: wayland/weston#250