Commit 2e5ad925 authored by Harish Krupo's avatar Harish Krupo Committed by Simon Ser
Browse files

data-device: send INVALID_FINISH when operation != dnd

The documentation of wl_data_offer::finish states that it should be
used to signify that a drag and drop operation is completed. So send
WL_DATA_OFFER_ERROR_INVALID_FINISH when the client calls the finish
request but the operation isn't dnd.
Signed-off-by: Harish Krupo's avatarHarish Krupo <>
(cherry picked from commit 737ac0d4)
parent 48e1c427
......@@ -427,6 +427,7 @@ struct weston_data_source {
struct weston_seat *seat;
bool accepted;
bool actions_set;
bool set_selection;
uint32_t dnd_actions;
enum wl_data_device_manager_dnd_action current_dnd_action;
enum wl_data_device_manager_dnd_action compositor_action;
......@@ -220,6 +220,13 @@ data_offer_finish(struct wl_client *client, struct wl_resource *resource)
if (!offer->source || offer->source->offer != offer)
if (offer->source->set_selection) {
"finish only valid for drag n drop");
/* Disallow finish while we have a grab driving drag-and-drop, or
* if the negotiation is not at the right stage
......@@ -1145,6 +1152,7 @@ weston_seat_set_selection(struct weston_seat *seat,
seat->selection_data_source = source;
seat->selection_serial = serial;
source->set_selection = true;
if (keyboard)
focus = keyboard->focus;
......@@ -1267,6 +1275,7 @@ create_data_source(struct wl_client *client,
source->dnd_actions = 0;
source->current_dnd_action = WL_DATA_DEVICE_MANAGER_DND_ACTION_NONE;
source->compositor_action = WL_DATA_DEVICE_MANAGER_DND_ACTION_NONE;
source->set_selection = false;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment