From 0e451e8dc38b1539e6e2b0ae6f5c871d3edab70a Mon Sep 17 00:00:00 2001 From: "Jan Alexander Steffens (heftig)" <heftig@archlinux.org> Date: Sat, 14 Sep 2024 06:35:09 +0200 Subject: [PATCH] libweston/noop-renderer: Check shm_buffer for NULL Copy the check from the pixman renderer. Fixes: https://gitlab.freedesktop.org/wayland/weston/-/issues/953 Signed-off-by: Jan Alexander Steffens (heftig) <heftig@archlinux.org> --- libweston/noop-renderer.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/libweston/noop-renderer.c b/libweston/noop-renderer.c index 06b4aebc1f..58d0b66819 100644 --- a/libweston/noop-renderer.c +++ b/libweston/noop-renderer.c @@ -94,6 +94,12 @@ noop_renderer_attach(struct weston_paint_node *pnode) } shm_buffer = buffer->shm_buffer; + /* This can happen if a SHM wl_buffer gets destroyed before we attach, + * because wayland-server just nukes the wl_shm_buffer from underneath + * us. */ + if (!shm_buffer) + return; + data = wl_shm_buffer_get_data(shm_buffer); stride = buffer->stride; height = buffer->height; -- GitLab