Commit 678c8681 authored by Michael Forney's avatar Michael Forney Committed by Simon Ser

Avoid pointer arithmetic on `void *`

The pointer operand to the binary `+` operator must be to a complete
object type. Since we are working with byte sizes, use `char *` for
arithmetic instead.
Signed-off-by: Michael Forney's avatarMichael Forney <mforney@mforney.org>
parent 55d04481
Pipeline #40636 passed with stage
in 2 minutes and 13 seconds
......@@ -131,7 +131,7 @@ wl_array_add(struct wl_array *array, size_t size)
array->alloc = alloc;
}
p = array->data + array->size;
p = (char *)array->data + array->size;
array->size += size;
return p;
......
......@@ -87,8 +87,7 @@ TEST(array_add)
/* verify the data */
for (i = 0; i < iterations; ++i) {
const int index = datasize * i;
struct mydata* check = (struct mydata*)(array.data + index);
struct mydata* check = (struct mydata*)array.data + i;
assert(check->a == i * 3);
assert(check->b == 20000 - i);
......@@ -121,9 +120,8 @@ TEST(array_copy)
/* check the copy */
for (i = 0; i < iterations; i++) {
const int index = sizeof(int) * i;
int *s = (int *)(source.data + index);
int *c = (int *)(copy.data + index);
int *s = (int *)source.data + i;
int *c = (int *)copy.data + i;
assert(*s == *c); /* verify the values are the same */
assert(s != c); /* ensure the addresses aren't the same */
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment