Skip to content
  • Derek Foreman's avatar
    tests: Test for use after free in resource destruction signals · 58ee271b
    Derek Foreman authored
    
    
    For years it's been common practice to free the object containing
    the wl_listener inside resource destruction notifiers, but not
    remove the listener from the list.
    
    That is: It's been safe to assume (when only one listener is present)
    that the wl_listener will never be touched again, since this is
    a destruction callback.
    
    Recently some patches were reviewed that made some positive changes
    to our internal signal handling code, but would've violated this
    assumption, and changed free()d memory in several existing compositors
    (weston, mutter, enlightenment).
    
    Since the breakage was extremely subtle, codify this assumption in
    a test case (thus promoting it to an ABI promise).
    
    Reviewed-by: default avatarPekka Paalanen <pekka.paalanen@collabora.co.uk>
    Reviewed-by: default avatarMarkus Ongyerth <wl@ongy.net>
    Signed-off-by: default avatarDerek Foreman <derekf@osg.samsung.com>
    58ee271b