Skip to content

wayland-util: avoid memcpy(NULL) in wl_array_copy()

Pekka Paalanen requested to merge pq/wayland:mr/array-copy-fix into main

The problem was found running Weston, with both Weston and Wayland built with ASan:

../../git/wayland/src/wayland-util.c:150:2: runtime error: null pointer passed as argument 1, which is declared to never be null
../../git/wayland/src/wayland-util.c:150:2: runtime error: null pointer passed as argument 2, which is declared to never be null

This turns out to be caused by copying an empty array into an empty array.

That seems to be completely valid thing to do, and wl_array_init() initializes the pointers to NULL and size to zero. Copying initialized arrays must always be valid.

The error are caused by calling memcpy() with NULL pointers. It doesn't explode, because also the size is zero.

Fix the problem by calling memcpy() only if size is not zero. This should keep things like copying an empty array into a non-empty array work.

Merge request reports