Skip to content

log: remove "%m" from format strings by using strerror(errno)

Antonio Borneo requested to merge borneoa/wayland:fix-log into master

The printf() format specifier "%m" is a glibc extension to print the string returned by strerror(errno). While supported by other libraries (e.g. uClibc and musl), it is not widely portable.

In Wayland code the format string is often passed to a logging function that calls other syscalls before the conversion of "%m" takes place. If one of such syscall modifies the value in errno, the conversion of "%m" will incorrectly report the error string corresponding to the new value of errno.

Remove all the occurrences of the specifier "%m" in Wayland code by using directly the string returned by strerror(errno).

Signed-off-by: Antonio Borneo borneo.antonio@gmail.com

Merge request reports