1. 16 Mar, 2017 1 commit
  2. 23 Feb, 2017 1 commit
  3. 26 Jan, 2017 1 commit
  4. 26 Jul, 2016 1 commit
  5. 16 Jan, 2016 1 commit
  6. 12 Jun, 2015 1 commit
  7. 15 May, 2015 1 commit
    • Michael Vetter's avatar
      remove trailing whitespaces · b409c919
      Michael Vetter authored
      Remove trailing whitespaces because they are not needed and jumping to
      the end of al ine should do just that and not jump to the whitespace.
      b409c919
  8. 28 Jan, 2015 1 commit
  9. 04 Nov, 2014 1 commit
    • Benjamin Herr's avatar
      connection: Leave fd open in wl_connection_destroy · 391820b0
      Benjamin Herr authored
      Calling close() on the same file descriptor that a previous call to
      close() already closed is wrong, and racy if another thread received
      that same file descriptor as a eg. new socket or actual file.
      
      There are two situations where wl_connection_destroy() would close its
      file descriptor and then another function up in the call chain would
      close the same file descriptor:
      
        * When wl_client_create() fails after calling wl_connection_create(),
          it will call wl_connection_destroy() before returning. However, its
          caller will always close the file descriptor if wl_client_create()
          fails.
      
        * wl_display_disconnect() unconditionally closes the display file
          descriptor and also calls wl_connection_destroy().
      
      So these two seem to expect wl_connection_destroy() to leave the file
      descriptor open. The other caller of wl_connection_destroy(),
      wl_client_destroy(), does however expect wl_connection_destroy() to
      close its file descriptor, alas.
      
      This patch changes wl_connection_destroy() to indulge this majority of
      two callers by simply not closing the file descriptor. For the benefit
      of wl_client_destroy(), wl_connection_destroy() then returns the
      unclosed file descriptor so that wl_client_destroy() can close it
      itself.
      
      Since wl_connection_destroy() is a private function called from few
      places, changing its semantics seemed like the more expedient way to
      address the double-close() problem than shuffling around the logic in
      wl_client_create() to somehow enable it to always avoid calling
      wl_connection_destroy().
      Signed-off-by: default avatarBenjamin Herr <ben@0x539.de>
      Reviewed-by: default avatarMarek Chalupa <mchqwerty@gmail.com>
      Reviewed-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.co.uk>
      391820b0
  10. 06 May, 2014 1 commit
  11. 21 Apr, 2014 1 commit
  12. 15 Jan, 2014 1 commit
  13. 05 Jun, 2013 1 commit
  14. 19 Mar, 2013 1 commit
  15. 17 Mar, 2013 1 commit
    • Jonas Ådahl's avatar
      client: Invoke new_id closure arguments as pointers instead of integers · cb73bffe
      Jonas Ådahl authored
      This commit adds a flags parameter to wl_closure_invoke(). The so far
      added flags are ment to specify if the invokation is client side or
      server side. When on the server side, closure arguments of type 'new_id'
      should be invoked as a integer id while on the client side they should
      be invoked as a pointer to a proxy object.
      
      This fixes a bug happening when the address of a client side 'new_id'
      proxy object did not fit in a 32 bit integer.
      
      krh: Squashed test suite compile fix from Jason Ekstrand.
      Signed-off-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      cb73bffe
  16. 03 Dec, 2012 2 commits
  17. 11 Oct, 2012 1 commit
    • Kristian Høgsberg's avatar
      Change filedescriptor API to be thread safe · 53d24713
      Kristian Høgsberg authored
      The update callback for the file descriptors was always a bit awkward and
      un-intuitive.  The idea was that whenever the protocol code needed to
      write data to the fd it would call the 'update' function.  This function
      would adjust the mainloop so that it polls for POLLOUT on the fd so we
      can eventually flush the data to the socket.
      
      The problem is that in multi-threaded applications, any thread can issue
      a request, which writes data to the output buffer and thus triggers the
      update callback.  Thus, we'll be calling out with the display mutex
      held and may call from any thread.
      
      The solution is to eliminate the udpate callback and just require that
      the application or server flushes all connection buffers before blocking.
      This turns out to be a simpler API, although we now require clients to
      deal with EAGAIN and non-blocking writes.  It also saves a few syscalls,
      since the socket will be writable most of the time and most writes will
      complete, so we avoid changing epoll to poll for POLLOUT, then write and
      then change it back for each write.
      53d24713
  18. 24 Jul, 2012 1 commit
  19. 02 Jul, 2012 1 commit
  20. 30 Jun, 2012 1 commit
    • Dylan Noblesmith's avatar
      tests: fix make check for out-of-tree builds · b486e3ab
      Dylan Noblesmith authored
      It was failing with missing include files.
      
      While here, destroy the ugly "../src/..." include
      paths used in the tests that was just hacking around
      this problem in the Makefile:
      
      sed -i s/..\\/src\\/// tests/*.c
      b486e3ab
  21. 15 Jun, 2012 1 commit
  22. 08 May, 2012 1 commit
  23. 22 Apr, 2012 2 commits
  24. 13 Apr, 2012 1 commit
  25. 24 Mar, 2012 2 commits
  26. 23 Mar, 2012 4 commits
  27. 21 Mar, 2012 1 commit
  28. 06 Mar, 2012 3 commits
  29. 03 Mar, 2012 2 commits