1. 29 Oct, 2020 5 commits
    • Simon Ser's avatar
      protocol: deprecate non-current wl_output.mode · 6741dafb
      Simon Ser authored
      The current wl_output.mode event has several issues when used to advertise
      modes that aren't current:
      - It's not possible to remove some modes. This is an issue for virtual
        outputs and when the kernel prunes some modes because of link limitations.
      - wl_output.mode fails to carry metadata such as aspect ratio, which results
        in duplicated or missing modes.
      - It's not clear, given the current set of protocols, how non-current modes
        are useful to clients. Xwayland ignores non-current modes.
      GNOME and wlroots already only advertise the current mode because of these
      If a protocol needs the clients to know about all available modes, it should
      advertise these modes itself instead of relying on wl_output.mode.
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
      Closes: #92
    • Simon Ser's avatar
      protocol: make it clear wl_surface.enter/leave are not for frame throttling · d42b39cc
      Simon Ser authored
      Some clients rely on wl_surface.enter/leave to start/stop their rendering
      There are cases where this doesn't work:
      - Some compositors don't send wl_surface.leave when a toplevel is hidden.
        For instance Sway doesn't send this event when a toplevel is on an inactive
        workspace (but doesn't send wl_surface.frame events).
      - Some compositors might still want applications to continue to render even if
        away from outputs. For instance a compositor that allows to screen record
        individual toplevels might not send a wl_surface.enter event for hidden
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
    • Ganjing0224's avatar
    • Alyssa Ross's avatar
      doc: make reproducible · e53e0edf
      Alyssa Ross authored
      This setting makes Docbook section IDs consistent, and should allow
      Wayland builds that include documentation to be fully reproducible.
      Signed-off-by: Alyssa Ross's avatarAlyssa Ross <hi@alyssa.is>
    • Nick Yamane's avatar
      protocol: Clarify how clients can cancel a drag operation · 53dd9979
      Nick Yamane authored
      Explicitly say that destroying a wl_data_source previously used in a
      wl_data_device::start_drag request will cancel the DND session. This
      is currently the only way to do it from client side (besides those
      "indirect" ones already documented) and all compositors work like that
      but it is not clear spec-wise it is the expected behaviour.
      Signed-off-by: Nick Yamane's avatarNick Diego Yamane <nickdiego@igalia.com>
  2. 04 Sep, 2020 2 commits
    • Valentin's avatar
      Fix undefined behavior · 1ab6a818
      Valentin authored
      Without the casts the bytes accesses get converted to int. but int is
      not guaranteed to be 4 bytes large. Even when it is 4 bytes large
      `bytes[3] << 24` does not fit because int is signed.
      Signed-off-by: default avatarValentin Kettner <vakevk@gmail.com>
    • Valentin's avatar
      Use fixed size integer type · fc3beac7
      Valentin authored
      This type is meant to be 4 bytes large as seen in _XcursorReadUInt which
      always reads 4 bytes. An unsigned int is often 4 bytes large but this
      isnt' guaranteed so it is cleaner to use the exact type we want.
      Signed-off-by: default avatarValentin Kettner <vakevk@gmail.com>
  3. 18 Aug, 2020 1 commit
  4. 14 Aug, 2020 1 commit
  5. 16 Jun, 2020 1 commit
    • Simon Ser's avatar
      protocol: disambiguate key codes in wl_keyboard.key · 1dfd2169
      Simon Ser authored
      Explain that wl_keyboard.key yields platform-specific key codes.
      Some compositors use Linux key codes (defined in the
      linux/input-event-codes.h header file, e.g. KEY_ESC), however
      clients should not assume that this is always the case. The only
      reliable way for clients to interpret key codes is to feed them
      into a keyboard mapping.
      Signed-off-by: Simon Ser's avatarSimon Ser <contact@emersion.fr>
  6. 12 Jun, 2020 2 commits
  7. 05 Jun, 2020 5 commits
  8. 04 Jun, 2020 2 commits
    • Peter Hutterer's avatar
      gitlab CI: update to use the fdo ci templates · cf20f241
      Peter Hutterer authored
      Instead of building a new debian image every time we build the repo, let's build
      it once and re-use it. This way we're more  likely to spot actual bugs vs issues
      with the distribution (or mirrors). This is the same approach mesa, gstreamer,
      libinput, etc. already use.
      The pipeline consists of two parts: container-build and distribution-image. Both
      use the FDO_DISTRIBUTION_... variables to do their thing, the former to build an
      image, the latter to use that image. The container-build step is a noop if an
      image with that tag already exists in the registry, the templates take care of
      all that.
      The .debian.buster section groups the variables needed to easily extend all jobs
      requiring buster. Not all variables are used by all jobs but meh.
      The grouping is slightly odd because some debian-specific variables are in
      the global variables and others in the .debian.buster section. This grouping
      will make things easier if we extend to build on other distributions - then we
      have all packages and tags in one place.
      Because buster doesn't have a recent-enough version of meson, we install that
      from pip.
      Fixes #79
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
    • Peter Hutterer's avatar
      editorconfig: add settings for the .gitlab-ci.yml file · 94c036d7
      Peter Hutterer authored
      Different indentation and we don't want a fixed line length here, wrapping yaml
      is prone to introduce bugs.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.com>
  9. 03 Jun, 2020 1 commit
  10. 29 Apr, 2020 1 commit
  11. 23 Apr, 2020 1 commit
    • Guido Günther's avatar
      scanner: Guard interface declarations · cc8b6aa3
      Guido Günther authored
      This allows to include client and server headers in the same file
      fixing warnings like
      In file included from ../subprojects/wlroots/include/wlr/types/wlr_layer_shell_v1.h:16,
                       from ../src/desktop.h:16,
                       from ../src/server.h:13,
                       from ../tests/testlib.c:8:
      tests/59830eb@@footest@sta/wlr-layer-shell-unstable-v1-protocol.h:80:34: warning: redundant redeclaration of ‘zwlr_layer_shell_v1_interface’ [-Wredundant-decls]
         80 | extern const struct wl_interface zwlr_layer_shell_v1_interface;
            |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from ../tests/testlib.h:8,
                       from ../tests/testlib.c:7:
      tests/59830eb@@footest@sta/wlr-layer-shell-unstable-v1-client-protocol.h:77:34: note: previous declaration of ‘zwlr_layer_shell_v1_interface’ was here
         77 | extern const struct wl_interface zwlr_layer_shell_v1_interface;
            |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from ../subprojects/wlroots/include/wlr/types/wlr_layer_shell_v1.h:16,
                       from ../src/desktop.h:16,
                       from ../src/server.h:13,
                       from ../tests/testlib.c:8:
      tests/59830eb@@footest@sta/wlr-layer-shell-unstable-v1-protocol.h:106:34: warning: redundant redeclaration of ‘zwlr_layer_surface_v1_interface’ [-Wredundant-decls]
        106 | extern const struct wl_interface zwlr_layer_surface_v1_interface;
            |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      In file included from ../tests/testlib.h:8,
                       from ../tests/testlib.c:7:
      tests/59830eb@@footest@sta/wlr-layer-shell-unstable-v1-client-protocol.h:103:34: note: previous declaration of ‘zwlr_layer_surface_v1_interface’ was here
        103 | extern const struct wl_interface zwlr_layer_surface_v1_interface;
      Signed-off-by: Guido Günther's avatarGuido Günther <agx@sigxcpu.org>
      Closes: #158
  12. 16 Apr, 2020 2 commits
  13. 07 Apr, 2020 1 commit
  14. 18 Mar, 2020 3 commits
  15. 13 Mar, 2020 1 commit
    • Matt Turner's avatar
      meson: Add option to control building wayland-scanner · 618663c7
      Matt Turner authored
      Wayland requires a binary, wayland-scanner, to be run during the build
      process. For any configuration other than native builds (including
      cross compiling and even 32-bit x86 builds on an x86-64 build machine)
      Wayland's build process builds and uses its own wayland-scanner.
      For any builds using a cross file, wayland-scanner is built for the host
      machine and therefore cannot be executed during the build of the Wayland
      libraries. Instead builds using a cross file must execute the build
      machine's wayland-scanner (typically /usr/bin/wayland-scanner).
      As such, to build Wayland's libraries for a non-native ABI a package
      manager must build and install /usr/bin/wayland-scanner first. But then
      the build for the native ABI then rebuilds wayland-scanner itself and
      doesn't use the system's, and worse, wants to install its own, which
      conflicts with the /usr/bin/wayland-scanner already installed!
      So, add the -Dscanner=... option to control whether to install
      Signed-off-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
  16. 09 Mar, 2020 1 commit
    • Matt Turner's avatar
      meson: Require wayland-scanner of a matching version · 5ddb8dff
      Matt Turner authored
      We have always built libwayland with the scanner from the same build so
      that the generated code and installed headers are exactly up-to-date
      with the libwayland version. If libwayland was to use a scanner later
      than itself, the scanner might do things that are not available in the
      libwayland at hand, leading to a broken build or a broken library
      Signed-off-by: Matt Turner's avatarMatt Turner <mattst88@gmail.com>
  17. 05 Mar, 2020 1 commit
  18. 24 Feb, 2020 1 commit
    • Tomek Bury's avatar
      util: fix compiler warning · ef40f82a
      Tomek Bury authored
      conversion to 'wl_fixed_t {aka int}' from 'int64_t {aka long int}'
      may alter its value [-Werror=conversion]
  19. 23 Feb, 2020 3 commits
  20. 15 Feb, 2020 1 commit
    • Jan Beich's avatar
      meson/tests: add missing dependencies on protocol headers · 0fc00fff
      Jan Beich authored
      In file included from ../tests/connection-test.c:43:
      In file included from ../tests/test-compositor.h:30:
      ../src/wayland-client.h:40:10: fatal error: 'wayland-client-protocol.h' file not found
       #include "wayland-client-protocol.h"
      In file included from ../tests/display-test.c:45:
      In file included from ../src/wayland-server.h:104:
      src/wayland-server-protocol.h:4454:2: error: unterminated /* comment
      In file included from ../tests/cpp-compile-test.cpp:2:
      In file included from src/wayland-server-protocol.h:8:
      In file included from ../src/wayland-server.h:104:
      src/wayland-server-protocol.h:3:2: error: unterminated conditional directive
      ../tests/headers-protocol-test.c:33:2: error: including wayland-server-protocol.h did not include wayland-server.h!
       #error including wayland-server-protocol.h did not include wayland-server.h!
      In file included from ../tests/headers-protocol-test.c:26:
      In file included from src/wayland-client-protocol.h:8:
      In file included from ../src/wayland-client.h:40:
      src/wayland-client-protocol.h:1358:2: error: unterminated conditional directive
       #ifndef WL_SHM_FORMAT_ENUM
      In file included from ../tests/protocol-logger-test.c:34:
      In file included from ../src/wayland-client.h:40:
      src/wayland-client-protocol.h:2613:1: error: unterminated /* comment
      ../tests/resources-test.c:49:36: error: use of undeclared identifier 'wl_seat_interface'
              res = wl_resource_create(client, &wl_seat_interface, 4, 0);
  21. 11 Feb, 2020 2 commits
  22. 04 Feb, 2020 2 commits