Commit b5f97895 authored by Pekka Paalanen's avatar Pekka Paalanen Committed by Derek Foreman
Browse files

contributing: how to read the review rules

This is to avoid fighting around the letter of the guidelines. This is
not a protocol spec.
Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <>
Reviewed-by: Daniel Stone's avatarDaniel Stone <>
Reviewed-by: Derek Foreman's avatarDerek Foreman <>
parent 7cbaa871
......@@ -206,6 +206,11 @@ people with commit access, there needs to be at least one Acked-by from
someone with commit access. A person with commit access is expected to be
able to evaluate the patch with respect to the project scope and architecture.
The below review guidelines are intended to be interpreted in spirit, not by
the letter. There may be circumstances where some guidelines are better
ignored. We rely very much on the judgement of reviewers and commit rights
During review, the following matters should be checked:
- The commit message explains why the change is being made.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment