Commit c62be976 authored by Simon Ser's avatar Simon Ser
Browse files

linux-dmabuf: send protocol error on invalid format/modifier

Now that compositors must send INVALID to advertise support for
implicit modifiers, we can make it a protocol error to add a
DMA-BUF plane with an unsupported format + modifier pair.
Signed-off-by: Simon Ser's avatarSimon Ser <>
Reviewed-by: Daniel Stone's avatarDaniel Stone <>
parent 8a5cd28a
Pipeline #451901 passed with stages
in 45 seconds
......@@ -247,10 +247,8 @@
compression, etc. driver-specific modifications to the base format
defined by the DRM fourcc code.
Warning: It should be an error if the format/modifier pair was not
advertised by zwp_linux_dmabuf_feedback_v1. This is not enforced yet
because some implementations always accept DRM_FORMAT_MOD_INVALID. Also
version 2 of this protocol does not have the modifier event.
Starting from version 4, the invalid_format protocol error is sent if
the format + modifier pair was not advertised as supported.
This request raises the PLANE_IDX error if plane_idx is too large.
The error PLANE_SET is raised if attempting to set a plane that
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment