Commit 6ad41986 authored by Stefan Kost's avatar Stefan Kost
Browse files

ext/ladspa/: Add some thoughts and FIXME's.

Original commit message from CVS:
* ext/ladspa/gstladspa.c:
* ext/ladspa/gstsignalprocessor.c:
Add some thoughts and FIXME's.
parent 7a1019a2
2008-03-20 Stefan Kost <ensonic@users.sf.net>
* ext/ladspa/gstladspa.c:
* ext/ladspa/gstsignalprocessor.c:
Add some thoughts and FIXME's.
2008-03-20 Stefan Kost <ensonic@users.sf.net>
 
* gst/bayer/gstbayer2rgb.c:
......
......@@ -89,7 +89,16 @@ gst_ladspa_base_init (gpointer g_class)
if (LADSPA_IS_PORT_AUDIO (p)) {
gchar *name = g_strdup ((gchar *) desc->PortNames[j]);
/* FIXME: group stereo pairs into a stereo pad
* ladspa-fx have "XXX (Left)" and "XXX (Right)"
* where XXX={In,Input,Out,Output}
*/
GST_DEBUG ("LADSPA port name: \"%s\"", name);
/* replaces all spaces with underscores, and then remaining special chars
* with '-'
* FIXME: why, pads can have any name
*/
g_strdelimit (name, " ", '_');
g_strcanon (name, G_CSET_A_2_Z G_CSET_a_2_z G_CSET_DIGITS "_-><=", '-');
GST_DEBUG ("GStreamer pad name: \"%s\"", name);
......
......@@ -35,7 +35,7 @@
GST_DEBUG_CATEGORY_STATIC (gst_signal_processor_debug);
#define GST_CAT_DEFAULT gst_signal_processor_debug
/* FIXME: this is mono only */
static GstStaticCaps template_caps =
GST_STATIC_CAPS (GST_AUDIO_FLOAT_STANDARD_PAD_TEMPLATE_CAPS);
......@@ -71,6 +71,8 @@ gst_signal_processor_pad_template_get_type (void)
return type;
}
/* FIXME: better allow the caller to pass on the template, right now this can
* only create mono pads */
void
gst_signal_processor_class_add_pad_template (GstSignalProcessorClass * klass,
const gchar * name, GstPadDirection direction, guint index)
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment