Skip to content

render_client_dispatch_create_context the intent on failure is not clear

The function does ...

   bool ok = render_client_create_context(client, &req->create_context, &remote_fd);
   if (!ok)
      return false;
    
   ...

   const struct render_client_op_create_context_reply reply = {
      .ok = ok,
   };
   if (!ok)
      return render_socket_send_reply(&client->socket, &reply, sizeof(reply));

The second time we test for !ok the statement is basically dead code, but it is not clear whether the intent is to just return with false, or whether to send a reply with the error. One of the two if (!ok) should go away, but which?

Edited by Gert Wollny
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information