Do not keep bus, address, vid and pid of the USB device
in SpiceUsbDeviceInfo structure. Getters for these properties
can easily obtain them from respective backend device.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

As a step toward possibility to present emulated USB devices
to the guest, we remove the knowledge about libusb and
usbredirhost (which depends on libusb) from all the modules
and concentrate it in one (usb backend) which presents
abstract USB objects and internal API to all other modules.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

schedule_frame() was expecting to be called at least 1 ms before having
to display the frame which is wrong: being called 0 ms before is
acceptable too. Thankfully the frame would usually be the last decoded
frame and would thus be displayed anyway.
Also reverse the inequality to make it easier to understand.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Victor Toso <victortoso@redhat.com>

When GDK_SCALE is != 1 and egl is used, the image presented does not
fit to the window (scale of 2 is often used with hidpi monitors).
Usually this is not a problem since all components are adjusted by
gdk/gtk but with egl, pixel-based data is not being scaled. In this
case window's scale value can be used in order to determine whether
to use a pixel resource with higher resolution data.

In order to reproduce the problem set spice with virgl/Intel-vGPU
and run spice-gtk with GDK_SCALE=2

This issue was also reported at freedesktop gitlab repo:
spice/spice-gtk#99



Signed-off-by: Snir Sheriber <ssheribe@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

François Gouget authored Jun 10, 2019 and Snir Sheriber committed Jun 10, 2019

The mm_time is an unsigned 32 bit int but spice_mmtime_diff() returns a
signed 32 bit int. That's reasonable because we normally subtract
frame times which should be at most seconds apart.
But last_mm_time was zero on stream startup, resulting in an overflow
and an uncalled for warning for the first frame in
spice_gst_decoder_queue_frame() if the uptime was greater than about
25 days.

Signed-off-by: Francois Gouget <fgouget@codeweavers.com>
Acked-by: Snir Sheriber <ssheribe@redhat.com>

Victor Toso authored May 31, 2019 and Frediano Ziglio committed May 31, 2019

As libusb_strerror() does exactly what spice_usbutil_libusb_strerror()
is doing. Notice that we can change the description language with
libusb_setlocale() but keeping it in English by default (as it is) for
now.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Apply the same workaround in 3c9b37bf
for Meson.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Marc-André Lureau <marcandre.lureau@gmail.com>

Marc-André Lureau authored Jan 16, 2019 and Frediano Ziglio committed May 29, 2019

- Fix the following warnings:
./spice-gtk-sections.txt:467: warning: No declaration found for SPICE_GTK_CHECK_VERSION.
./spice-gtk-sections.txt:468: warning: No declaration found for SPICE_GTK_MAJOR_VERSION.
./spice-gtk-sections.txt:469: warning: No declaration found for SPICE_GTK_MICRO_VERSION.
./spice-gtk-sections.txt:470: warning: No declaration found for SPICE_GTK_MINOR_VERSION.

- fixxref for glib and gtk (thus requires gtk+ to build doc)

- And other minor simplifications.

After autotools is removed, we should try to use --rebuild-types. For
now I prefer not to touch it :)

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

J W authored May 27, 2019 and Frediano Ziglio committed May 29, 2019

Acked-by: Frediano Ziglio <fziglio@redhat.com>

This should have been removed by commit 96ed6b7a ("pygtk: remove bindings
leftover")

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Otherwise we break meson builds with "meson.build:44:0: ERROR:
Subproject exists but has no meson.build file"

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

This extra empty line makes the v0.24 section have extra line between
each element of the list in the Markdown. Just removing it to keep all
sections similar.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

In order to have gitlab interface to handle this file as Markdown
and properly feed the changelog section.
Add to EXTRA_DIST to include the renamed file to release's tarball.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

No other significant changes in the content were done besides format.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

In order to have gitlab interface to handle this file as Markdown.
Add to EXTRA_DIST to include the renamed file to release's tarball.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

It seems sometimes the working directory is not properly cleaned
causing some issue.
Make sure it's clean before doing a out-of-tree build (which have
problems with not cleaned directory).

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Left from previous commit f90a9068
"build: Do not generate ChangeLog file"

Acked-by: Frediano Ziglio <fziglio@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>

There's already a hand written change log and people can look
at repository history.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

This is a regression from commit aae07fb3 in 2017-03-27 by Victor Toso
<me@victortoso.com>. The message is handled by channel-webdav and
should not be exposed nor handled elsewhere.

Found this while inspecting the code, there is not real side effect
as no one trying to handle port-data from webdav's channel-port.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Snir Sheriber authored May 07, 2019 and Frediano Ziglio committed May 07, 2019

Acked-by: Frediano Ziglio <fziglio@redhat.com>

Victor Toso authored May 07, 2019 and Frediano Ziglio committed May 07, 2019

Not really interesting to keep tracking what is inside or not
USE_USBREDIR on channel-usbredir itself. When usbredir is disabled,
just dummy functions are needed with spice-client.h include.

After this patch, on channel-usbredir.c, we have a single #ifdef
USE_USBREDIR and the #else block is defined in the end of the file.

This patch also adds #ifdef USE_USBREDIR for channel-usbredir-priv.h
as none those functions are defined when usbredir is disabled.

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Otherwise we'll get

    g_type_add_instance_private: assertion 'private_size > 0' failed

Signed-off-by: Victor Toso <victortoso@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Headers macros (HAVE_*_H) are guarding some include in the code.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

Jeremy White authored Apr 30, 2019 and Frediano Ziglio committed May 01, 2019

This mitigates a fairly rare problem we see with our kiosk mode clients.
That is, normally if something goes wrong with a client connection
(e.g. the session is killed, or the server is restarted ), the kiosk will
exit on disconnect, and we get a chance to retry the connection, or
present the user with a 'server down' style message.

But in the case of a serious network problem or a server hard power
cycle (i.e. no TCP FIN packets can flow), our end user behavior is not
ideal - the kiosk appears to hang solid, requiring a power cycle.

That's because we've got the stock keepalive timeouts, or about 2 hours
and 11 minutes, before the client sees the disconnect.

This change will cause the client to recognize the server has vanished
without a TCP FIN after 75 seconds.

See this thread:
  https://lists.freedesktop.org/archives/spice-devel/2017-March/036553.html

As well as this bug:
  https://bugzilla.redhat.com/show_bug.cgi?id=1436589



Signed-off-by: Jeremy White <jwhite@codeweavers.com>

Roman Bogorodskiy authored Apr 27, 2019 and Frediano Ziglio committed Apr 27, 2019

Currently, spice-gtk uses PKG_CHECK_MODULES(SSL, openssl) to detect
openssl CFLAGS and LIBS. And spice-common defines and uses
SPICE_CHECK_OPENSSL macro which calls
PKG_CHECK_MODULES(OPENSSL, openssl).

This means that in order to override openssl CFLAGS or LIBS a user will
have to set both OPENSSL_(CFLAGS|LIBS) and SSL_(CFLAGS|LIBS).

To make this more consistent, make spice-gtk use the
SPICE_CHECK_OPENSSL macro from spice-common.

Signed-off-by: Roman Bogorodskiy <bogorodskiy@gmail.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Clean all git modules, not only the main one.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Christophe de Dinechin <dinechin@redhat.com>

"devices" is translated to "dispositivi" (plural) not "dispositivo"
(singular).
In other occurrences "Some devices" is correctly translated to
"Qualche dispositivo".

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Snir Sheriber <ssheribe@redhat.com>

build-aux/meson/check-spice-common was removed by commit
57645fac
("build-sys: remove meson/check-spice-common")

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>

Uri Lublin authored Apr 23, 2019 and Frediano Ziglio committed Apr 24, 2019

Signed-off-by: Uri Lublin <uril@redhat.com>

Uri Lublin authored Apr 23, 2019 and Frediano Ziglio committed Apr 24, 2019

Fix out-of-tree builds.

Uri Lublin (1):
      codegen Makefile: add common/ to --include client_marshallers.h

David Jaša authored Apr 18, 2019 and Frediano Ziglio committed Apr 22, 2019

Signed-off-by: David Jaša <djasa@redhat.com>
Acked-by: Jakub Janku <jjanku@redhat.com>

Jakub Janků authored Apr 18, 2019 and Frediano Ziglio committed Apr 18, 2019

Translation strings for spice options are already present
in the respective PO files.

g_option_group_set_translation_domain() call needs to be made,
so that the strings marked with N_() actually get translated at runtime.

Signed-off-by: Jakub Janků <jjanku@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Jakub Janků authored Apr 17, 2019 and Frediano Ziglio committed Apr 18, 2019

_() should not be used in conjunction with ngettext(),
otherwise it's impossible to properly translate the message into
languages that have multiple plural forms, such as Czech.

Additionally, spice-gtk must use dngettext instead of ngettext,
otherwise the translation strings are searched within a wrong domain.

Fix ngettext usage in usb-device-widget.c and
update the PO files accordingly.

Signed-off-by: Jakub Janků <jjanku@redhat.com>
Acked-by: Frediano Ziglio <fziglio@redhat.com>

Spice gtk-session would try to synchronize the modifiers state whenever
the keymap changes, but doing so is inherently racy.

While the there is a keyboard grab in effect, all key events are
forwarded to the guest, hence all modifiers key press get processed by
the kernel on the guest.

Trying to synchronize the modifiers will generate additional key press/
release events which will result in the opposite effect and effectively
desynchronize the modifier states in the guest.

Synchronizing modifiers from the host should therefore be limited to
focus change, as actual press/release events might have occurred without
the guest knowing. Otherwise, no need to synchronize the modifiers.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Olivier Fourdan <ofourdan@redhat.com>
Acked-by: Victor Toso <victortoso@redhat.com>

This brings in the following changes:

Christophe Fergeau (8):
      canvas_base: Fix variable shadowing warning
      backtrace: Add missing include
      lz: Don't try to print uninitialized variable
      build: Add missing G_GNUC_PRINTF annotations
      build: Update verify.h to latest version
      test-marshallers: Fix header guard
      quic: Fix QUIC_VERSION definition
      log: Let gcc know about the logging macros which abort

Eduardo Lima (Etrunko) (5):
      meson: Use underscorify() instead of split()
      meson: Bump libcacard requirement to 2.5.1
      meson: switch smartcard option to auto feature
      meson: Bump requirement to 0.48
      meson: Make targets list store dictionaries instead of lists

Frediano Ziglio (31):
      Remove obsolete Autoconf macros
      log: remove deprecated SPICE_ABORT_LEVEL support
      log: remove deprecated SPICE_DEBUG_LEVEL support
      Obsolete Glib cleanup
      codegen: Document ptr_array attribute
      codegen: Use a better type for pointer converted to integer
      codegen: Reduce indentation
      codegen: Fix c_type result for TypeAlias
      codegen: Check wrong attribute
      codegen: Add a test for attribute combination
      mem: Fix compile error if alignment-checks option is used
      log: Remove useless includes
      proto: Remove obsolete TunnelChannel
      protocol: Add a dummy TunnelChannel
      messages: Remove fields not used by the protocol
      codegen: Remove support for --ptrsize
      codegen: Rename --prefix parameter to --suffix
      ci: Remove dependencies from copr build
      build: Remove snd_codec.h from EXTRA_DIST
      test-ssl-verify: Improve subject_to_x509_name coverage
      meson: Remove some useless checks
      codegen: Factor out a function to write output file
      codegen: Generate headers while generating code
      codegen: Allows to generate C declarations automatically
      Allow to generate C declarations for spice.proto
      Generate automatically most C message declarations
      recorder: Update
      build: Add new check for recorder library
      proto: Fix typo in message name
      meson: Fix dependency of generated files
      meson: Do not build generated files twice

Marc-André Lureau (1):
      docs: add spice URI scheme

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Acked-by: Eduardo Lima (Etrunko) <etrunko@redhat.com>

Yuri Benditovich authored Mar 19, 2019 and Christophe Fergeau committed Mar 27, 2019

Remove unused code related to GUdevDevice.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>

Yuri Benditovich authored Mar 19, 2019 and Christophe Fergeau committed Mar 27, 2019

Unify SpiceUsbDeviceInfo for Linux and Windows by using
persistent libusb_device. Probably there was some problem
doing it long time ago with winusb, but at least with
existing libusb and UsbDk the the libusb device can be
accessed as long as it is referenced.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>

Yuri Benditovich authored Mar 19, 2019 and Christophe Fergeau committed Mar 27, 2019

Change the signal to report libusb_device instead of GUdevDevice
object. This simplifies the callback procedure in usb-dev-manager
and avoids additional reenumeration immediately after reenumeration
that already done by win-usb-dev.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
Acked-by: Christophe Fergeau <cfergeau@redhat.com>