Skip to content

too little timeout in stop_daemon() of integration-test.py causes test_charge_cycles and test_battery_id_change to fail on longaarch64

Hi,

after applying the patch suggested in #195 (closed), i managed to fix the self-test on longaarch64 builders of Alpine Linux for upower-1.90.6. After that test_charge_cycles and test_battery_id_change started failing. To fix these, i have adjusted the following inside integration-test.py. If you want to see all patches, the Alpine MR is over here

diff --git a/src/linux/integration-test.py b/src/linux/integration-test.py
index 4cdefa8..70fbad6 100755
--- a/src/linux/integration-test.py
+++ b/src/linux/integration-test.py
@@ -243,7 +243,7 @@ class Tests(dbusmock.DBusTestCase):
             except OSError:
                 pass
             try:
-                self.assertEqual(self.daemon.wait(timeout=5.0), 0)
+                self.assertEqual(self.daemon.wait(timeout=10.0), 0)
             except subprocess.TimeoutExpired:
                 try:
                     self.daemon.kill()

Best wishes