Commit 60d190ef authored by Kristian Høgsberg's avatar Kristian Høgsberg
Browse files

2005-03-04 Kristian Høgsberg <krh@redhat.com>

        * test/gtk-cairo-test.cc (view_load):
        * test/gtk-splash-test.cc (view_load): Fix missing return
        statement, and remove unused variables.

        * configure.ac: Add configure option to enable the default KDE
        flags as described by Albert Astals Cid <tsdgeos@yahoo.es>.

        * TODO: Update with Jeff's items.

        * .cvsignore:
        * */.cvsignore: Add these to silence CVS.
parent e6706e50
2005-03-04 Kristian Høgsberg <krh@redhat.com>
* test/gtk-cairo-test.cc (view_load):
* test/gtk-splash-test.cc (view_load): Fix missing return
statement, and remove unused variables.
* configure.ac: Add configure option to enable the default KDE
flags as described by Albert Astals Cid <tsdgeos@yahoo.es>.
* TODO: Update with Jeff's items.
* .cvsignore:
* */.cvsignore: Add these to silence CVS.
......
Convert to use as much existing infra-structure as possible:
- drop t1lib
- use fontconfig
- dont use /etc/xpdf.rc, add abstraction that can work with
GNOME and KDE configuration systems (GConf and ?)
- improve cairo backend
- use jasper for jpeg2000 decoding
- use littlecms for color management?
- use libtiff for ccitt decoding?
Maybe:
Performance:
- make color space conversion stuff more sane (right now we
hack around some of it in the cairo backend)
- move away from getChar to a more read(2) like interface
- Install poppler-splash and poppler-cairo to indicate
Maybe:
- Install poppler-splash.pc and poppler-cairo.pc to indicate
available backends. Alternatively, just hide the backend
choice from the application.
choice from the application. This is done now, but for this
to work properly, we really need multiple .so's.
- make c-wrapper so GNOME projects won't need to use C++ (no
glib, just a plain c wrapper so you can compile against and
......
......@@ -137,6 +137,27 @@ elif test x$enable_gtk_test = xtry; then
fi
AM_CONDITIONAL(BUILD_GTK_TEST, test x$enable_gtk_test = xyes)
AC_ARG_ENABLE(compile-warnings,
AC_HELP_STRING([--enable-compile-warnings=@<:@no/yes/kde@:>@]
[Turn on compiler warnings.]),,
[enable_compile_warnings="yes"])
if test "x$GCC" != xyes; then
enable_compile_warnings=no
fi
case "$enable_compile_warnings" in
no) ;;
yes) CXXFLAGS="-Wall -Wno-unused $CXXFLAGS" ;;
kde) CXXFLAGS="-Wnon-virtual-dtor -Wno-long-long -Wundef -ansi \
-D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align \
-Wconversion -Wchar-subscripts -Wall -W -Wpointer-arith \
-Wwrite-strings -O2 -Wformat-security \
-Wmissing-format-attribute -fno-exceptions -fno-check-new \
-fno-common $CXXFLAGS" ;;
esac
AC_OUTPUT([
Makefile
goo/Makefile
......
......@@ -122,7 +122,6 @@ void GDKCairoOutputDev::redraw(int srcX, int srcY,
int destX, int destY,
int width, int height) {
GdkGC *gc;
int gdk_rowstride;
gc = gdk_gc_new (drawable);
gdk_draw_drawable (drawable, gc,
......@@ -146,7 +145,6 @@ drawing_area_expose (GtkWidget *drawing_area,
void *data)
{
View *v = (View*) data;
int x, y, w, h;
GdkRectangle document;
GdkRectangle draw;
......@@ -173,8 +171,6 @@ view_load (View *v,
PDFDoc *newDoc;
int err;
GooString *filename_g;
GtkAdjustment *hadj;
GtkAdjustment *vadj;
int w, h;
filename_g = new GooString (filename);
......@@ -203,6 +199,8 @@ view_load (View *v,
h = v->out->getPixmapHeight();
gtk_widget_set_size_request (v->drawing_area, w, h);
return errNone;
}
static void
......
......@@ -162,7 +162,6 @@ drawing_area_expose (GtkWidget *drawing_area,
void *data)
{
View *v = (View*) data;
int x, y, w, h;
GdkRectangle document;
GdkRectangle draw;
......@@ -189,8 +188,6 @@ view_load (View *v,
PDFDoc *newDoc;
int err;
GooString *filename_g;
GtkAdjustment *hadj;
GtkAdjustment *vadj;
int w, h;
filename_g = new GooString (filename);
......@@ -219,6 +216,8 @@ view_load (View *v,
h = v->out->getBitmapHeight();
gtk_widget_set_size_request (v->drawing_area, w, h);
return errNone;
}
static void
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment