Commit d0b7fc0d authored by Tim-Philipp Müller's avatar Tim-Philipp Müller 🐠
Browse files

ext/shout2/gstshout2.c: Don't crash in case the connection to the server...

ext/shout2/gstshout2.c: Don't crash in case the connection to the server fails: don't set pointer to NULL by assignin...

Original commit message from CVS:
* ext/shout2/gstshout2.c: (gst_shout2send_render):
Don't crash in case the connection to the server fails:
don't set pointer to NULL by assigning FALSE; error out
properly by using GST_ELEMENT_ERROR and returning
GST_FLOW_ERROR (fixes #338636). Lastly, free connection
before resetting the pointer.
parent 5ff46904
2006-04-17 Tim-Philipp Müller <tim at centricular dot net>
* ext/shout2/gstshout2.c: (gst_shout2send_render):
Don't crash in case the connection to the server fails:
don't set pointer to NULL by assigning FALSE; error out
properly by using GST_ELEMENT_ERROR and returning
GST_FLOW_ERROR (fixes #338636). Lastly, free connection
before resetting the pointer.
2006-04-17 Jan Schmidt <thaytan@mad.scientist.com>
* gst/id3demux/id3tags.c:
......
......@@ -384,10 +384,16 @@ gst_shout2send_render (GstBaseSink * sink, GstBuffer * buf)
shout2send->started = TRUE;
} else {
GST_ERROR ("Couldn't connect to server: %s",
GST_ERROR_OBJECT (shout2send, "Couldn't connect to server: %s",
shout_get_error (shout2send->conn));
shout2send->conn = FALSE;
GST_ELEMENT_ERROR (shout2send, RESOURCE, OPEN_WRITE,
(NULL), GST_ERROR_SYSTEM);
g_signal_emit (G_OBJECT (shout2send),
gst_shout2send_signals[SIGNAL_CONNECTION_PROBLEM], 0,
shout_get_errno (shout2send->conn));
shout_free (shout2send->conn);
shout2send->conn = NULL;
return GST_FLOW_ERROR;
}
}
......
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment