GitLab

Fixes distcheck.

gstreamer/gst-plugins-bad#457

void function cannot have return value

gst-plugins-bad/sys/msdk/gstmsdkbufferpool.c(332): warning C4098:
'gst_msdk_buffer_pool_release_buffer': ...

OpenAL.framework doesn't provide 'alext.h'.
Thus, openal is enabled only if the dependency
is set by pkg-config.

fixes: #852

Bitrate was logged a second time instead of the max_bitrate.

Fixes SSL errors in fast-start scenarios and whenever media stream may
be received before an answer is set.

Doing so before will cause SSL errors with fast-start implementations
like Chrome or if media data arrives before an answer.

set-*-description only takes the combined GstWebRTCSessionDescription
object

The former was only considering the first byte pair, for the latter we
have to convert raw CEA708 cc_data into CDP.

closedcaption: Add ccconverter element that can convert between different types of Closed Caption formats

Seungha Yang authored Dec 18, 2018 and Tim-Philipp Müller committed Dec 18, 2018

... and drop libxml2 dependency since it never be used by
both test and gstisoff.

Seungha Yang authored Dec 18, 2018 and Tim-Philipp Müller committed Dec 18, 2018

... to avoid mixing '/' and '\' in a path string on Windows.

Seungha Yang authored Dec 07, 2018 and Tim-Philipp Müller committed Dec 18, 2018

Allow run some unit tests on Windows.
* Add dependency explicitly for some test cases, otherwise plugins couldn't be
  loaded on uninstalled environment of Windows.
* Add missing GST_PLUGIN_LOADING_WHITELIST on meson build.

Nicolas Dufresne authored Nov 06, 2018 and Guillaume Desmottes committed Dec 18, 2018

Otherwise sdi_mode and similar properties would be canonicalised to
sdi-mode.

configure_mode_setting() keeps a ref on tmp_kmsmem which is released in
gst_kms_sink_show_frame().
But if for some reason configure_mode_setting() is re-called before
showing a frame or if none is showed this memory was leaked.

ACM is an ancient legacy API, and there's no point in
keeping it around for a licensed mp3 decoder now that
mp3 patents have expired and we have a decoder in -good.

We didn't ship this in cerbero anyway. If there's a good
case for the AAC encoder (which is LC only anyway) someone
should write a new plugin based on current APIs, that can
actually be built out of the box.

Fixes #850

ext/opencv/meson.build:103:2: ERROR:  Unknown variable "gstopencv_dep".

Need at least 0.4.2 apparently.

ext/wildmidi/meson.build:11:2: ERROR:  String '' cannot be converted to int

Jonathan Karlsson authored Dec 17, 2018 and Sebastian Dröge committed Dec 17, 2018

Not doing this would result in a memory leak.

Jan Alexander Steffens authored Dec 05, 2018 and Sebastian Dröge committed Dec 17, 2018

Mostly move some assignments out of conditionals that gst-indent
completely destroys.

Jan Alexander Steffens authored Dec 04, 2018 and Sebastian Dröge committed Dec 17, 2018

The decoder seems to default to 6 channels max, downmixing 7.1 to 5.1.
Disable the channel limit to expose all channels to GStreamer.

In addition, none of the standard configurations use ACT_SIDE channels.
The rear channels of the 7.1 configuration have to be taken from
ACT_BACK. See the table in aacenc_lib.h, reproduced here:

----------------------------------------------------------------------------------------
 ChannelMode           | ChCfg | Height | front_El      | side_El  | back_El  | lfe_El
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_1                 |     1 | NORM   | SCE           |          |          |
MODE_2                 |     2 | NORM   | CPE           |          |          |
MODE_1_2               |     3 | NORM   | SCE, CPE      |          |          |
MODE_1_2_1             |     4 | NORM   | SCE, CPE      |          | SCE      |
MODE_1_2_2             |     5 | NORM   | SCE, CPE      |          | CPE      |
MODE_1_2_2_1           |     6 | NORM   | SCE, CPE      |          | CPE      | LFE
MODE_1_2_2_2_1         |     7 | NORM   | SCE, CPE, CPE |          | CPE      | LFE
MODE_6_1               |    11 | NORM   | SCE, CPE      |          | CPE, SCE | LFE
MODE_7_1_BACK          |    12 | NORM   | SCE, CPE      |          | CPE, CPE | LFE
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_7_1_TOP_FRONT     |    14 | NORM   | SCE, CPE      |          | CPE      | LFE
                       |       | TOP    | CPE           |          |          |
-----------------------+-------+--------+---------------+----------+----------+---------
MODE_7_1_REAR_SURROUND |     0 | NORM   | SCE, CPE      |          | CPE, CPE | LFE
MODE_7_1_FRONT_CENTER  |     0 | NORM   | SCE, CPE, CPE |          | CPE      | LFE
----------------------------------------------------------------------------------------
- NORM: Normal Height Layer.     - TOP: Top Height Layer.  - BTM: Bottom Height Layer.
- SCE: Single Channel Element.   - CPE: Channel Pair.      - LFE: Low Frequency Element.

Restores 8 channels to
https://www2.iis.fraunhofer.de/AAC/7.1auditionOutLeader_v2_rtb.mp4

Jan Alexander Steffens authored Dec 04, 2018 and Sebastian Dröge committed Dec 17, 2018

These are MPEG-standard configurations so should be checked first,
before the PCE clones added by v0.1.4.

Jan Alexander Steffens authored Dec 04, 2018 and Sebastian Dröge committed Dec 17, 2018

We (currently?) prefer to use the REAR positions for what MPEG calls
"surround" channels.

Tim-Philipp Müller authored Dec 16, 2018 and Sebastian Dröge committed Dec 17, 2018

Not so useful now that all effort is focused on AV1 instead.
Was only ever enabled with --enable-experimental anyway.

Fixes #848

Otherwise gst-i18n-plugin.h can't be found.