Commit 38529675 authored by Nanley Chery's avatar Nanley Chery Committed by Marge Bot
Browse files

iris: Support clears in more GPU-based copies

Commit 7779b1d7

, disabled clear support
when copying to/from color buffers. According to the performance CI, it
falls within a range of commits that introduced a performance regression
on Bioshock Infinite with Tigerlake. Icelake isn't noticeably affected.

By analyzing a trace of the game, I found a couple cases where that
commit added new partial resolves. Update get_copy_region_aux_settings
to avoid them:

- The trace uploads to R8_UNORM textures. On TGL, these enter the
  COMPRESSED_CLEAR state on the upload and are partially resolved before
  every subsequent upload. Thankfully, they keep their initial clear
  color of all zeroes. Since zeros can survive format reinterpretation,
  allow clear support for it.

- The trace copies between RGBA16_FLOAT textures. The ones with zero
  clear color are helped by the optimization above. The ones with
  non-zero clear color are used as source textures. Thankfully on ICL+,
  the clear color used for sampling is in pixel form and can thus be
  sampled from with format reinterpretation. Allow clear support for
  this case.

I haven't tested the actual performance impact of this change, but it
should be beneficial regardless.
Reported-by: clayton craft's avatarClayton Craft <>
Reported-by: Jordan Justen's avatarJordan Justen <>
Reviewed-by: Kenneth Graunke's avatarKenneth Graunke <>
Part-of: <mesa/mesa!8262>
parent de853627
......@@ -599,6 +599,9 @@ get_copy_region_aux_settings(struct iris_context *ice,
bool *out_clear_supported,
bool is_render_target)
struct iris_screen *screen = (void *) ice->ctx.screen;
struct gen_device_info *devinfo = &screen->devinfo;
switch (res->aux.usage) {
......@@ -617,7 +620,27 @@ get_copy_region_aux_settings(struct iris_context *ice,
*out_aux_usage = res->aux.usage;
*out_clear_supported = false;
/* blorp_copy may reinterpret the surface format and has limited support
* for adjusting the clear color, so clear support may only be enabled
* in some cases:
* - On gen11+, the clear color is indirect and comes in two forms: a
* 32bpc representation used for rendering and a pixel representation
* used for sampling. blorp_copy doesn't change indirect clear colors,
* so clears are only supported in the sampling case.
* - A clear color of zeroes holds the same meaning regardless of the
* format. Although it could avoid more resolves, we don't use
* isl_color_value_is_zero because the surface format used by
* blorp_copy isn't guaranteed to access the same components as the
* original format (e.g. A8_UNORM/R8_UINT).
*out_clear_supported = (devinfo->gen >= 11 && !is_render_target) ||
(res->aux.clear_color.u32[0] == 0 &&
res->aux.clear_color.u32[1] == 0 &&
res->aux.clear_color.u32[2] == 0 &&
res->aux.clear_color.u32[3] == 0);
*out_aux_usage = ISL_AUX_USAGE_NONE;
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment