Commit 1520131d authored by Alyssa Rosenzweig's avatar Alyssa Rosenzweig Committed by Marge Bot
Browse files

pan/bi: Fix source mod testing for CMP

Outputs u32.

Signed-off-by: Alyssa Rosenzweig's avatarAlyssa Rosenzweig <>
Part-of: <mesa/mesa!4789>
parent 12ca99f2
...@@ -38,14 +38,15 @@ bi_has_outmod(bi_instruction *ins) ...@@ -38,14 +38,15 @@ bi_has_outmod(bi_instruction *ins)
return classy && floaty; return classy && floaty;
} }
/* Technically we should check the source type, not the dest /* Have to check source for e.g. compares */
* type, but the type converting opcodes (i2f, f2i) don't
* actually support mods so it doesn't matter. */
bool bool
bi_has_source_mods(bi_instruction *ins) bi_has_source_mods(bi_instruction *ins)
{ {
return bi_has_outmod(ins); bool classy = bi_class_props[ins->type] & BI_MODS;
bool floaty = nir_alu_type_get_base_type(ins->src_types[0]) == nir_type_float;
return classy && floaty;
} }
/* A source is swizzled if the op is swizzlable, in 8-bit or /* A source is swizzled if the op is swizzlable, in 8-bit or
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment