Skip to content
  • Faith Ekstrand's avatar
    anv: Push UBO ranges relative to the start of the binding · 4061ac85
    Faith Ekstrand authored
    There was a disconnect between anv_nir_compute_push_layout and the code
    which sets up the push_ubo_sizes array.  The NIR code we emit checks
    relative to the start of the bound UBO range so that, if we end up with
    a vector which straddles the start of the push range, we can perform the
    bounds check without risking overflow issues.  The code which sets up
    the push_ubo_sizes, on the other hand, assumed it was relative to the
    start of the push range.  Somehow, this didn't get get caught by any of
    the available tests.
    
    Fixes: e03f9652
    
     "anv: Bounds-check pushed UBOs when ..."
    Closes: #2623
    Reviewed-by: default avatarLionel Landwerlin <lionel.g.landwerlin@intel.com>
    Tested-by: Marge Bot <mesa/mesa!4195>
    Part-of: <mesa/mesa!4195>
    4061ac85