Commit 48a4fd4e authored by Miguel París Díaz's avatar Miguel París Díaz Committed by Sebastian Dröge

rtpsession: properly handle rtcp_feedback_retention_window

- Consider GST_CLOCK_TIME_NONE as not to be used.
- Complete "rtcp-feedback-retention-window" property getter/setter
  implementation.
parent 458741e4
...@@ -821,6 +821,9 @@ rtp_session_set_property (GObject * object, guint prop_id, ...@@ -821,6 +821,9 @@ rtp_session_set_property (GObject * object, guint prop_id,
if (sess->callbacks.reconsider) if (sess->callbacks.reconsider)
sess->callbacks.reconsider (sess, sess->reconsider_user_data); sess->callbacks.reconsider (sess, sess->reconsider_user_data);
break; break;
case PROP_RTCP_FEEDBACK_RETENTION_WINDOW:
sess->rtcp_feedback_retention_window = g_value_get_uint64 (value);
break;
case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD: case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD:
sess->rtcp_immediate_feedback_threshold = g_value_get_uint (value); sess->rtcp_immediate_feedback_threshold = g_value_get_uint (value);
break; break;
...@@ -900,6 +903,9 @@ rtp_session_get_property (GObject * object, guint prop_id, ...@@ -900,6 +903,9 @@ rtp_session_get_property (GObject * object, guint prop_id,
case PROP_RTCP_MIN_INTERVAL: case PROP_RTCP_MIN_INTERVAL:
g_value_set_uint64 (value, sess->stats.min_interval * GST_SECOND); g_value_set_uint64 (value, sess->stats.min_interval * GST_SECOND);
break; break;
case PROP_RTCP_FEEDBACK_RETENTION_WINDOW:
g_value_set_uint64 (value, sess->rtcp_feedback_retention_window);
break;
case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD: case PROP_RTCP_IMMEDIATE_FEEDBACK_THRESHOLD:
g_value_set_uint (value, sess->rtcp_immediate_feedback_threshold); g_value_set_uint (value, sess->rtcp_immediate_feedback_threshold);
break; break;
...@@ -2818,7 +2824,7 @@ rtp_session_process_feedback (RTPSession * sess, GstRTCPPacket * packet, ...@@ -2818,7 +2824,7 @@ rtp_session_process_feedback (RTPSession * sess, GstRTCPPacket * packet,
gst_buffer_unref (fci_buffer); gst_buffer_unref (fci_buffer);
} }
if (src && sess->rtcp_feedback_retention_window) { if (src && sess->rtcp_feedback_retention_window != GST_CLOCK_TIME_NONE) {
rtp_source_retain_rtcp_packet (src, packet, pinfo->running_time); rtp_source_retain_rtcp_packet (src, packet, pinfo->running_time);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment