Commit 486d3c3b authored by Matthew Waters's avatar Matthew Waters 🐨

qmlglsink: propagate GL context creation failure upwards

Otherwise an application cannot know if the qmlglsink will be displaying frames
incorrectly/at all.
parent f17e58f8
......@@ -414,6 +414,8 @@ QtGLVideoItem::onSceneGraphInvalidated ()
qt_item_init_winsys (QtGLVideoItem * widget)
GError *error = NULL;
g_return_val_if_fail (widget != NULL, FALSE);
g_mutex_lock (&widget->priv->lock);
......@@ -446,8 +448,12 @@ qt_item_init_winsys (QtGLVideoItem * widget)
return FALSE;
gst_gl_context_create (widget->priv->context, widget->priv->other_context,
if (!gst_gl_context_create (widget->priv->context, widget->priv->other_context,
&error)) {
GST_ERROR ("%s", error->message);
g_mutex_unlock (&widget->priv->lock);
return FALSE;
g_mutex_unlock (&widget->priv->lock);
return TRUE;
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment