Commit 3f511ec3 authored by Benjamin Otte's avatar Benjamin Otte

Add -Wwrite-strings to the configure flags

... and fix all warnings
parent 0f7631f8
......@@ -272,10 +272,10 @@ dnl set location of plugin directory
AG_GST_SET_PLUGINDIR
dnl define an ERROR_CFLAGS Makefile variable
AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef])
AG_GST_SET_ERROR_CFLAGS($GST_GIT, [-Wmissing-declarations -Wmissing-prototypes -Wredundant-decls -Wundef -Wwrite-strings])
dnl define an ERROR_CXXFLAGS Makefile variable
AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [-Wmissing-declarations -Wredundant-decls -Wundef])
AG_GST_SET_ERROR_CXXFLAGS($GST_GIT, [-Wmissing-declarations -Wredundant-decls -Wundef -Wwrite-strings])
dnl define correct level for debugging messages
AG_GST_SET_LEVEL_DEFAULT($GST_GIT)
......
......@@ -55,7 +55,8 @@ static gchar *
gst_hal_get_alsa_element (LibHalContext * ctx, const gchar * udi,
GstHalDeviceType device_type)
{
char *type, *element = NULL, *string = NULL;
char *type, *string = NULL;
const char *element = NULL;
DBusError error;
dbus_error_init (&error);
......@@ -145,7 +146,8 @@ static gchar *
gst_hal_get_oss_element (LibHalContext * ctx, const gchar * udi,
GstHalDeviceType device_type)
{
char *type, *element = NULL, *string = NULL;
char *type, *string = NULL;
const char *element = NULL;
DBusError error;
dbus_error_init (&error);
......
......@@ -1046,7 +1046,7 @@ gst_dv1394src_uri_get_type (void)
static gchar **
gst_dv1394src_uri_get_protocols (void)
{
static gchar *protocols[] = { "dv", NULL };
static gchar *protocols[] = { (char *) "dv", NULL };
return protocols;
}
......
......@@ -793,7 +793,7 @@ gst_hdv1394src_uri_get_type (void)
static gchar **
gst_hdv1394src_uri_get_protocols (void)
{
static gchar *protocols[] = { "hdv", NULL };
static gchar *protocols[] = { (char *) "hdv", NULL };
return protocols;
}
......
......@@ -1395,8 +1395,8 @@ gst_soup_http_src_uri_get_type (void)
static gchar **
gst_soup_http_src_uri_get_protocols (void)
{
static gchar *protocols[] = { "http", "https", NULL };
return protocols;
static const gchar *protocols[] = { "http", "https", NULL };
return (gchar **) protocols;
}
static const gchar *
......
......@@ -40,7 +40,7 @@ gst_wavpack_read_header (WavpackHeader * header, guint8 * buf)
g_memmove (header, buf, sizeof (WavpackHeader));
#ifndef WAVPACK_OLD_API
WavpackLittleEndianToNative (header, WavpackHeaderFormat);
WavpackLittleEndianToNative (header, (char *) WavpackHeaderFormat);
#else
little_endian_to_native (header, WavpackHeaderFormat);
#endif
......
......@@ -1093,7 +1093,7 @@ gst_avi_mux_write_tag (const GstTagList * list, const gchar * tag,
const struct
{
guint32 fcc;
gchar *tag;
const gchar *tag;
} rifftags[] = {
{
GST_RIFF_INFO_IARL, GST_TAG_LOCATION}, {
......
......@@ -152,7 +152,7 @@ gst_push_file_src_uri_get_type (void)
static gchar **
gst_push_file_src_uri_get_protocols (void)
{
static gchar *protocols[] = { "pushfile", NULL };
static gchar *protocols[] = { (char *) "pushfile", NULL };
return protocols;
}
......
......@@ -507,7 +507,7 @@ gst_flv_parse_audio_negotiate (GstFLVDemux * demux, guint32 codec_tag,
guint32 rate, guint32 channels, guint32 width)
{
GstCaps *caps = NULL;
gchar *codec_name = NULL;
const gchar *codec_name = NULL;
gboolean ret = FALSE;
switch (codec_tag) {
......@@ -890,7 +890,7 @@ gst_flv_parse_video_negotiate (GstFLVDemux * demux, guint32 codec_tag)
{
gboolean ret = FALSE;
GstCaps *caps = NULL;
gchar *codec_name = NULL;
const gchar *codec_name = NULL;
/* Generate caps for that pad */
switch (codec_tag) {
......
......@@ -28,7 +28,7 @@ empty_fct (PluginParam * dummy)
}
PluginParam
goom_secure_param ()
goom_secure_param (void)
{
PluginParam p;
......@@ -41,7 +41,7 @@ goom_secure_param ()
}
PluginParam
goom_secure_f_param (char *name)
goom_secure_f_param (const char *name)
{
PluginParam p = secure_param ();
......@@ -55,7 +55,7 @@ goom_secure_f_param (char *name)
}
PluginParam
goom_secure_f_feedback (char *name)
goom_secure_f_feedback (const char *name)
{
PluginParam p = secure_f_param (name);
......@@ -64,7 +64,7 @@ goom_secure_f_feedback (char *name)
}
PluginParam
goom_secure_s_param (char *name)
goom_secure_s_param (const char *name)
{
PluginParam p = secure_param ();
......@@ -75,7 +75,7 @@ goom_secure_s_param (char *name)
}
PluginParam
goom_secure_b_param (char *name, int value)
goom_secure_b_param (const char *name, int value)
{
PluginParam p = secure_param ();
......@@ -86,7 +86,7 @@ goom_secure_b_param (char *name, int value)
}
PluginParam
goom_secure_i_param (char *name)
goom_secure_i_param (const char *name)
{
PluginParam p = secure_param ();
......@@ -100,7 +100,7 @@ goom_secure_i_param (char *name)
}
PluginParam
goom_secure_i_feedback (char *name)
goom_secure_i_feedback (const char *name)
{
PluginParam p = secure_i_param (name);
......
......@@ -62,8 +62,8 @@ struct BoolVal {
typedef struct _PARAM {
char *name;
char *desc;
const char *name;
const char *desc;
char rw;
ParamType type;
union {
......@@ -99,20 +99,20 @@ typedef struct _PARAM {
PluginParam goom_secure_param(void);
PluginParam goom_secure_f_param(char *name);
PluginParam goom_secure_i_param(char *name);
PluginParam goom_secure_b_param(char *name, int value);
PluginParam goom_secure_s_param(char *name);
PluginParam goom_secure_f_param(const char *name);
PluginParam goom_secure_i_param(const char *name);
PluginParam goom_secure_b_param(const char *name, int value);
PluginParam goom_secure_s_param(const char *name);
PluginParam goom_secure_f_feedback(char *name);
PluginParam goom_secure_i_feedback(char *name);
PluginParam goom_secure_f_feedback(const char *name);
PluginParam goom_secure_i_feedback(const char *name);
void goom_set_str_param_value(PluginParam *p, const char *str);
void goom_set_list_param_value(PluginParam *p, const char *str);
typedef struct _PARAMETERS {
char *name;
char *desc;
const char *name;
const char *desc;
int nbParams;
PluginParam **params;
} PluginParameters;
......
......@@ -239,8 +239,8 @@ static const gchar *obsolete_frame_ids[] = {
const struct ID3v2FrameIDConvert
{
gchar *orig;
gchar *new;
const gchar *orig;
const gchar *new;
} frame_id_conversions[] = {
/* 2.3.x frames */
{
......
......@@ -152,7 +152,7 @@ gst_alaw_dec_getcaps (GstPad * pad)
GstPad *otherpad;
GstCaps *othercaps, *result;
const GstCaps *templ;
gchar *name;
const gchar *name;
gint i;
alawdec = GST_ALAW_DEC (GST_PAD_PARENT (pad));
......
......@@ -303,7 +303,7 @@ gst_alaw_enc_getcaps (GstPad * pad)
GstPad *otherpad;
GstCaps *othercaps, *result;
const GstCaps *templ;
gchar *name;
const gchar *name;
gint i;
alawenc = GST_ALAW_ENC (GST_PAD_PARENT (pad));
......
......@@ -95,7 +95,7 @@ mulawdec_getcaps (GstPad * pad)
GstPad *otherpad;
GstCaps *othercaps, *result;
const GstCaps *templ;
gchar *name;
const gchar *name;
gint i;
mulawdec = GST_MULAWDEC (GST_PAD_PARENT (pad));
......
......@@ -61,7 +61,7 @@ mulawenc_getcaps (GstPad * pad)
GstPad *otherpad;
GstCaps *othercaps, *result;
const GstCaps *templ;
gchar *name;
const gchar *name;
gint i;
mulawenc = GST_MULAWENC (GST_PAD_PARENT (pad));
......
......@@ -749,7 +749,8 @@ gst_ebml_replace_uint (GstEbmlWrite * ebml, guint64 pos, guint64 num)
* Write EBML header.
*/
void
gst_ebml_write_header (GstEbmlWrite * ebml, gchar * doctype, guint version)
gst_ebml_write_header (GstEbmlWrite * ebml, const gchar * doctype,
guint version)
{
guint64 pos;
......
......@@ -112,7 +112,7 @@ void gst_ebml_write_binary (GstEbmlWrite *ebml,
guchar *binary,
guint64 length);
void gst_ebml_write_header (GstEbmlWrite *ebml,
gchar *doctype,
const gchar *doctype,
guint version);
/*
......
......@@ -2934,8 +2934,8 @@ gst_matroska_demux_parse_metadata_id_simple_tag (GstMatroskaDemux * demux,
/* FIXME: check if there are more useful mappings */
struct
{
gchar *matroska_tagname;
gchar *gstreamer_tagname;
const gchar *matroska_tagname;
const gchar *gstreamer_tagname;
}
tag_conv[] = {
{
......@@ -4025,7 +4025,7 @@ gst_matroska_demux_check_subtitle_buffer (GstElement * element,
}
}
utf8 = g_convert_with_fallback (data, size, "UTF-8", encoding, "*",
utf8 = g_convert_with_fallback (data, size, "UTF-8", encoding, (char *) "*",
NULL, NULL, &err);
if (err) {
......@@ -4036,7 +4036,7 @@ gst_matroska_demux_check_subtitle_buffer (GstElement * element,
/* invalid input encoding, fall back to ISO-8859-15 (always succeeds) */
encoding = "ISO-8859-15";
utf8 = g_convert_with_fallback (data, size, "UTF-8", encoding, "*",
utf8 = g_convert_with_fallback (data, size, "UTF-8", encoding, (char *) "*",
NULL, NULL, NULL);
}
......@@ -5387,7 +5387,7 @@ gst_matroska_demux_chain (GstPad * pad, GstBuffer * buffer)
guint needed = 0;
guint32 id;
guint64 length;
gchar *name;
const gchar *name;
gst_adapter_push (demux->adapter, buffer);
buffer = NULL;
......
......@@ -1278,10 +1278,10 @@ speex_streamheader_to_codecdata (const GValue * streamheader,
return TRUE;
}
static gchar *
static const gchar *
aac_codec_data_to_codec_id (const GstBuffer * buf)
{
gchar *result;
const gchar *result;
gint profile;
/* default to MAIN */
......@@ -2080,8 +2080,8 @@ gst_matroska_mux_write_simple_tag (const GstTagList * list, const gchar * tag,
/* TODO: more sensible tag mappings */
struct
{
gchar *matroska_tagname;
gchar *gstreamer_tagname;
const gchar *matroska_tagname;
const gchar *gstreamer_tagname;
}
tag_conv[] = {
{
......
......@@ -6582,7 +6582,8 @@ qtdemux_tag_add_blob (GNode * node, GstQTDemux * demux)
gint len;
guint8 *data;
GstBuffer *buf;
gchar *media_type, *style;
gchar *media_type;
const gchar *style;
GstCaps *caps;
guint i;
guint8 ndata[4];
......@@ -6998,7 +6999,7 @@ gst_qtdemux_handle_esds (GstQTDemux * qtdemux, QtDemuxStream * stream,
guint8 *data_ptr = NULL;
int data_len = 0;
guint8 object_type_id = 0;
char *codec_name = NULL;
const char *codec_name = NULL;
GstCaps *caps = NULL;
GST_MEMDUMP_OBJECT (qtdemux, "esds", ptr, len);
......
......@@ -185,7 +185,7 @@ gst_rtp_dv_pay_setcaps (GstBaseRTPPayload * payload, GstCaps * caps)
static gboolean
gst_dv_pay_negotiate (GstRTPDVPay * rtpdvpay, guint8 * data, guint size)
{
gchar *encode, *media;
const gchar *encode, *media;
gboolean audio_bundled, res;
if ((data[3] & 0x80) == 0) { /* DSF flag */
......
......@@ -331,7 +331,7 @@ gst_rtp_mp4g_pay_setcaps (GstBaseRTPPayload * payload, GstCaps * caps)
GstRtpMP4GPay *rtpmp4gpay;
GstStructure *structure;
const GValue *codec_data;
gchar *media_type = NULL;
const gchar *media_type = NULL;
gboolean res;
rtpmp4gpay = GST_RTP_MP4G_PAY (payload);
......
......@@ -1245,7 +1245,7 @@ gst_rtspsrc_media_to_caps (gint pt, const GstSDPMedia * media)
pairs = g_strsplit (p, ";", 0);
for (i = 0; pairs[i]; i++) {
gchar *valpos;
gchar *val, *key;
const gchar *val, *key;
/* the key may not have a '=', the value can have other '='s */
valpos = strstr (pairs[i], "=");
......@@ -5564,9 +5564,9 @@ gst_rtspsrc_uri_get_type (void)
static gchar **
gst_rtspsrc_uri_get_protocols (void)
{
static gchar *protocols[] = { "rtsp", "rtspu", "rtspt", "rtsph", NULL };
static const gchar *protocols[] = { "rtsp", "rtspu", "rtspt", "rtsph", NULL };
return protocols;
return (gchar **) protocols;
}
static const gchar *
......
......@@ -258,7 +258,7 @@ gst_udpsink_uri_get_type (void)
static gchar **
gst_udpsink_uri_get_protocols (void)
{
static gchar *protocols[] = { "udp", NULL };
static gchar *protocols[] = { (char *) "udp", NULL };
return protocols;
}
......
......@@ -995,7 +995,7 @@ gst_udpsrc_uri_get_type (void)
static gchar **
gst_udpsrc_uri_get_protocols (void)
{
static gchar *protocols[] = { "udp", NULL };
static gchar *protocols[] = { (char *) "udp", NULL };
return protocols;
}
......
......@@ -394,7 +394,7 @@ static void
gst_video_balance_init (GTypeInstance * instance, gpointer g_class)
{
GstVideoBalance *videobalance = GST_VIDEO_BALANCE (instance);
char *channels[4] = { "HUE", "SATURATION",
const char *channels[4] = { "HUE", "SATURATION",
"BRIGHTNESS", "CONTRAST"
};
gint i;
......
......@@ -83,7 +83,7 @@ static void
fill_labels (void)
{
gint i, pos;
gchar *origs[SOUND_MIXER_NRDEVICES] = SOUND_DEVICE_LABELS;
const gchar *origs[SOUND_MIXER_NRDEVICES] = SOUND_DEVICE_LABELS;
const struct
{
const gchar *given;
......
......@@ -331,7 +331,7 @@ gst_v4l2_object_install_properties_helper (GObjectClass * gobject_class,
GstV4l2Object *
gst_v4l2_object_new (GstElement * element,
enum v4l2_buf_type type,
char *default_device,
const char *default_device,
GstV4l2GetInOutFunction get_in_out_func,
GstV4l2SetInOutFunction set_in_out_func,
GstV4l2UpdateFpsFunction update_fps_func)
......
......@@ -136,8 +136,8 @@ GType gst_v4l2_object_get_type (void);
/* create/destroy */
GstV4l2Object * gst_v4l2_object_new (GstElement * element,
enum v4l2_buf_type type,
char *default_device,
enum v4l2_buf_type type,
const char *default_device,
GstV4l2GetInOutFunction get_in_out_func,
GstV4l2SetInOutFunction set_in_out_func,
GstV4l2UpdateFpsFunction update_fps_func);
......
......@@ -969,7 +969,7 @@ gst_v4l2src_uri_get_type (void)
static gchar **
gst_v4l2src_uri_get_protocols (void)
{
static gchar *protocols[] = { "v4l2", NULL };
static gchar *protocols[] = { (char *) "v4l2", NULL };
return protocols;
}
......
......@@ -55,7 +55,7 @@ static GstStaticPadTemplate srcaudiotemplate = GST_STATIC_PAD_TEMPLATE ("src",
/* setup and teardown needs some special handling for muxer */
static GstPad *
setup_src_pad (GstElement * element,
GstStaticPadTemplate * template, GstCaps * caps, gchar * sinkname)
GstStaticPadTemplate * template, GstCaps * caps, const gchar * sinkname)
{
GstPad *srcpad, *sinkpad;
......@@ -84,7 +84,7 @@ setup_src_pad (GstElement * element,
}
static void
teardown_src_pad (GstElement * element, gchar * sinkname)
teardown_src_pad (GstElement * element, const gchar * sinkname)
{
GstPad *srcpad, *sinkpad;
gchar *padname;
......@@ -116,7 +116,7 @@ teardown_src_pad (GstElement * element, gchar * sinkname)
}
static GstElement *
setup_avimux (GstStaticPadTemplate * srctemplate, gchar * sinkname)
setup_avimux (GstStaticPadTemplate * srctemplate, const gchar * sinkname)
{
GstElement *avimux;
......@@ -131,7 +131,7 @@ setup_avimux (GstStaticPadTemplate * srctemplate, gchar * sinkname)
}
static void
cleanup_avimux (GstElement * avimux, gchar * sinkname)
cleanup_avimux (GstElement * avimux, const gchar * sinkname)
{
GST_DEBUG ("cleanup_avimux");
gst_element_set_state (avimux, GST_STATE_NULL);
......@@ -144,8 +144,9 @@ cleanup_avimux (GstElement * avimux, gchar * sinkname)
}
static void
check_avimux_pad (GstStaticPadTemplate * srctemplate, gchar * src_caps_string,
gchar * chunk_id, gchar * sinkname)
check_avimux_pad (GstStaticPadTemplate * srctemplate,
const gchar * src_caps_string, const gchar * chunk_id,
const gchar * sinkname)
{
GstElement *avimux;
GstBuffer *inbuffer, *outbuffer;
......
......@@ -153,7 +153,7 @@ GST_START_TEST (test_int16)
/* block wave of half amplitude has -5.94 dB for rms, peak and decay */
for (i = 0; i < 2; ++i) {
gchar *fields[3] = { "rms", "peak", "decay" };
const gchar *fields[3] = { "rms", "peak", "decay" };
for (j = 0; j < 3; ++j) {
list = gst_structure_get_value (structure, fields[j]);
value = gst_value_list_get_value (list, i);
......@@ -201,7 +201,7 @@ GST_START_TEST (test_int16_panned)
const GValue *list, *value;
GstClockTime endtime;
gdouble dB;
gchar *fields[3] = { "rms", "peak", "decay" };
const gchar *fields[3] = { "rms", "peak", "decay" };
level = setup_level ();
g_object_set (level, "message", TRUE, "interval", GST_SECOND / 10, NULL);
......
......@@ -61,7 +61,7 @@ static GstBuffer *header_buffer[2] = { NULL, NULL };
/* Some payload.
*/
static char *payload =
static const char *payload =
"0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF"
"0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF"
"0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF0123456789ABSDEF"
......
......@@ -105,7 +105,7 @@ done:
GST_START_TEST (test_rtp_payloaders)
{
gchar *s;
const gchar *s;
/* FIXME: going to playing would be nice, but thet leads to lot of failure */
GstState target_state = GST_STATE_PAUSED;
......@@ -223,7 +223,7 @@ GST_START_TEST (test_rtp_payloaders)
GST_END_TEST
GST_START_TEST (test_video_encoders_decoders)
{
gchar *s;
const gchar *s;
GstState target_state = GST_STATE_PLAYING;
/* no is-live on the source because we actually want to preroll since
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment