Commit 2d774554 authored by Whoopie's avatar Whoopie Committed by Nicolas Dufresne

v4l2object: Disable DMABuf for emulated formats

libv4l2 does not prevent exporting DMABuf even when emulated formats are
in use. As a side effect, userspace ends up with buffers of the original
formats which will cause issues.

https://bugzilla.gnome.org/show_bug.cgi?id=795097
parent ebf8a6d0
......@@ -2878,6 +2878,12 @@ gst_v4l2_object_is_dmabuf_supported (GstV4l2Object * v4l2object)
.flags = O_CLOEXEC | O_RDWR,
};
if (v4l2object->fmtdesc->flags & V4L2_FMT_FLAG_EMULATED) {
GST_WARNING_OBJECT (v4l2object->dbg_obj,
"libv4l2 converter detected, disabling DMABuf");
ret = FALSE;
}
/* Expected to fail, but ENOTTY tells us that it is not implemented. */
v4l2object->ioctl (v4l2object->video_fd, VIDIOC_EXPBUF, &expbuf);
if (errno == ENOTTY)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment